updated pr with last set of feedback from https://github.com/twitter/heron/pull/780. Remaining potential issues
heron/ui/src/python/handler/api/topology.py:
W:231, 0: FIXME: is there a purpose to saving the return value of this? (fixme)
W:234, 0: FIXME: estate not defined (fixme)
E:240,13: Undefined variable 'estate' (undefined-variable)
W:232, 4: Unused variable 'scheduler_location' (unused-variable)
---- pylint output for heron/cli ------------------------------------------------------------------
************* Module main
I: 42, 0: Locally disabling protected-access (W0212) (locally-disabled)
I: 64, 0: Locally disabling bad-super-call (E1003) (locally-disabled)
************* Module color
I: 18, 0: Locally disabling invalid-name (C0103) (locally-disabled)
************* Module log
I: 19, 0: Locally disabling invalid-name (C0103) (locally-disabled)
************* Module activate
I: 24, 0: Locally disabling unused-argument (W0613) (locally-disabled)
************* Module args
I: 24, 0: Locally disabling protected-access (W0212) (locally-disabled)
************* Module deactivate
I: 24, 0: Locally disabling unused-argument (W0613) (locally-disabled)
************* Module execute
W: 87, 0: TODO: We need to extract heron-core to separate folder. (fixme)
************* Module help
I: 27, 0: Locally disabling protected-access (W0212) (locally-disabled)
I: 40, 0: Locally disabling unused-argument (W0613) (locally-disabled)
************* Module jars
W: 21, 0: TODO, make the jars independent version free (fixme)
W: 33, 0: TODO, make the jars independent version free (fixme)
************* Module kill
I: 24, 0: Locally disabling unused-argument (W0613) (locally-disabled)
************* Module opts
I: 19, 0: Locally disabling invalid-name (C0103) (locally-disabled)
I: 19, 0: Locally disabling global-variable-not-assigned (W0602) (locally-disabled)
I: 19, 0: Locally disabling global-statement (W0603) (locally-disabled)
************* Module restart
I: 50, 0: Locally disabling unused-argument (W0613) (locally-disabled)
************* Module submit
I:234, 0: Locally disabling unused-argument (W0613) (locally-disabled)
************* Module utils
I: 86, 0: Locally disabling protected-access (W0212) (locally-disabled)
R:218, 0: Too many branches (14/12) (too-many-branches)
************* Module version
I: 34, 0: Locally disabling unused-argument (W0613) (locally-disabled)
Report
618 statements analysed.
Statistics by type
+---------+-------+-----------+-----------+------------+---------+
|type |number |old number |difference |%documented |%badname |
+=========+=======+===========+===========+============+=========+
|module |16 |16 |= |100.00 |0.00 |
+---------+-------+-----------+-----------+------------+---------+
|class |2 |2 |= |100.00 |0.00 |
+---------+-------+-----------+-----------+------------+---------+
|method |2 |2 |= |100.00 |0.00 |
+---------+-------+-----------+-----------+------------+---------+
|function |73 |73 |= |100.00 |0.00 |
+---------+-------+-----------+-----------+------------+---------+
External dependencies
::
utils (help)
Raw metrics
+----------+-------+------+---------+-----------+
|type |number |% |previous |difference |
+==========+=======+======+=========+===========+
|code |732 |42.43 |732 |= |
+----------+-------+------+---------+-----------+
|docstring |442 |25.62 |442 |= |
+----------+-------+------+---------+-----------+
|comment |339 |19.65 |339 |= |
+----------+-------+------+---------+-----------+
|empty |212 |12.29 |212 |= |
+----------+-------+------+---------+-----------+
Duplication
+-------------------------+------+---------+-----------+
| |now |previous |difference |
+=========================+======+=========+===========+
|nb duplicated lines |0 |0 |= |
+-------------------------+------+---------+-----------+
|percent duplicated lines |0.000 |0.000 |= |
+-------------------------+------+---------+-----------+
Messages by category
+-----------+-------+---------+-----------+
|type |number |previous |difference |
+===========+=======+=========+===========+
|convention |0 |0 |= |
+-----------+-------+---------+-----------+
|refactor |1 |1 |= |
+-----------+-------+---------+-----------+
|warning |3 |3 |= |
+-----------+-------+---------+-----------+
|error |0 |0 |= |
+-----------+-------+---------+-----------+
% errors / warnings by module
+--------+------+--------+---------+-----------+
|module |error |warning |refactor |convention |
+========+======+========+=========+===========+
|jars |0.00 |66.67 |0.00 |0.00 |
+--------+------+--------+---------+-----------+
|execute |0.00 |33.33 |0.00 |0.00 |
+--------+------+--------+---------+-----------+
|utils |0.00 |0.00 |100.00 |0.00 |
+--------+------+--------+---------+-----------+
Messages
+------------------+------------+
|message id |occurrences |
+==================+============+
|locally-disabled |17 |
+------------------+------------+
|fixme |3 |
+------------------+------------+
|too-many-branches |1 |
+------------------+------------+
Global evaluation
Your code has been rated at 9.94/10 (previous run: 9.94/10, +0.00)
---- pylint output for heron/ui ------------------------------------------------------------------
************* Module main
I: 39, 0: Locally disabling line-too-long (C0301) (locally-disabled)
I: 39, 0: Locally disabling bad-whitespace (C0326) (locally-disabled)
I: 93, 0: Locally disabling unused-argument (W0613) (locally-disabled)
W: 37, 0: TODO: Change these to query string parameters, since (fixme)
************* Module args
I: 19, 0: Locally disabling protected-access (W0212) (locally-disabled)
I: 42, 0: Locally disabling bad-super-call (E1003) (locally-disabled)
************* Module heron
I: 46, 0: Locally disabling invalid-name (C0103) (locally-disabled)
I:617, 0: Locally disabling no-self-use (R0201) (locally-disabled)
************* Module metrics
I: 22, 0: Locally disabling invalid-name (C0103) (locally-disabled)
************* Module topology
W:231, 0: FIXME: is there a purpose to saving the return value of this? (fixme)
W:234, 0: FIXME: estate not defined (fixme)
E:240,13: Undefined variable 'estate' (undefined-variable)
W:232, 4: Unused variable 'scheduler_location' (unused-variable)
************* Module graph
I: 26, 0: Locally disabling invalid-name (C0103) (locally-disabled)
************* Module utils
I: 15, 0: Locally disabling invalid-name (C0103) (locally-disabled)
************* Module notfound
I: 19, 0: Locally disabling unused-argument (W0613) (locally-disabled)
I:239, 0: Locally disabling attribute-defined-outside-init (W0201) (locally-disabled)
I:273, 0: Locally disabling attribute-defined-outside-init (W0201) (locally-disabled)
W: 71, 0: TODO: get the list of clusters from tracker and fetch the topologies (fixme)
************* Module log
I: 19, 0: Locally disabling invalid-name (C0103) (locally-disabled)
R: 1, 0: Similar lines in 2 files
==heron:531
==topology:153
cluster=cluster,
environ=environ,
topology=topology,
container=container,
path=path
) (duplicate-code)
R: 1, 0: Similar lines in 2 files
==heron:505
==topology:210
cluster=cluster,
environ=environ,
topology=topology,
container=container,
path=path, (duplicate-code)
Report
614 statements analysed.
Statistics by type
+---------+-------+-----------+-----------+------------+---------+
|type |number |old number |difference |%documented |%badname |
+=========+=======+===========+===========+============+=========+
|module |21 |21 |= |100.00 |0.00 |
+---------+-------+-----------+-----------+------------+---------+
|class |31 |31 |= |100.00 |0.00 |
+---------+-------+-----------+-----------+------------+---------+
|method |39 |39 |= |100.00 |0.00 |
+---------+-------+-----------+-----------+------------+---------+
|function |33 |33 |= |100.00 |3.03 |
+---------+-------+-----------+-----------+------------+---------+
External dependencies
::
base (topology)
fetch (heron)
Raw metrics
+----------+-------+------+---------+-----------+
|type |number |% |previous |difference |
+==========+=======+======+=========+===========+
|code |939 |44.74 |939 |= |
+----------+-------+------+---------+-----------+
|docstring |533 |25.39 |533 |= |
+----------+-------+------+---------+-----------+
|comment |341 |16.25 |341 |= |
+----------+-------+------+---------+-----------+
|empty |286 |13.63 |286 |= |
+----------+-------+------+---------+-----------+
Duplication
+-------------------------+------+---------+-----------+
| |now |previous |difference |
+=========================+======+=========+===========+
|nb duplicated lines |11 |11 |= |
+-------------------------+------+---------+-----------+
|percent duplicated lines |0.529 |0.529 |= |
+-------------------------+------+---------+-----------+
Messages by category
+-----------+-------+---------+-----------+
|type |number |previous |difference |
+===========+=======+=========+===========+
|convention |0 |0 |= |
+-----------+-------+---------+-----------+
|refactor |2 |2 |= |
+-----------+-------+---------+-----------+
|warning |5 |5 |= |
+-----------+-------+---------+-----------+
|error |1 |1 |= |
+-----------+-------+---------+-----------+
% errors / warnings by module
+---------+------+--------+---------+-----------+
|module |error |warning |refactor |convention |
+=========+======+========+=========+===========+
|topology |0.00 |20.00 |0.00 |0.00 |
+---------+------+--------+---------+-----------+
|main |0.00 |20.00 |0.00 |0.00 |
+---------+------+--------+---------+-----------+
|log |0.00 |0.00 |100.00 |0.00 |
+---------+------+--------+---------+-----------+
Messages
+-------------------+------------+
|message id |occurrences |
+===================+============+
|locally-disabled |14 |
+-------------------+------------+
|fixme |4 |
+-------------------+------------+
|duplicate-code |2 |
+-------------------+------------+
|unused-variable |1 |
+-------------------+------------+
|undefined-variable |1 |
+-------------------+------------+
Global evaluation
Your code has been rated at 9.80/10 (previous run: 9.80/10, +0.00)