Hello, first of all, thanks for sharing your work. I imported the sources and called it with the suggested code:

public static void main(String[] argv) throws IOException { File root = new File(System.getProperty("user.dir")); NativeFileSystem fs = new NativeFileSystem(root); NoOpAuthenticator auth = new NoOpAuthenticator(fs); FTPServer server = new FTPServer(auth); server.listenSync(21); }

When connecting to localhost:21 from Filezilla client, it fails almost immediately:

Comando: PWD Risposta: 257 "/" CWD Name Comando: TYPE I Risposta: 200 Type set to I Comando: EPSV Risposta: 229 Enabled Passive Mode (|||52773|) Comando: MLSD Risposta: 501 Missing parameters Errore: Non è stato possibile leggere il contenuto della cartella

Sorry for the italian, the last line means "it wasn't possible to read the contents of the folder". Am I missing something?

Cheers, and thanks again,

  Germano

Hi! I have found a bug! You have to replace one line in your code: FileHandler.list:236: Object dir = args.length > 0 && !args[0].equals("-l") && !args[0].equals("-a") ? getFile(args[0]) : cwd; Instead of: Object dir = args.length > 0 && !args[0].equals("-l") ? getFile(args[0]) : cwd; It doesn't work when client sends LIST -a. "-a" interprets as file that not exists. Client will have con.sendResponse(550, "Not a directory"); error. After bug having been fixed you may do things like this: sudo curlftpfs 127.0.0.1:2121 ~/mnt Than you may exec command line commands like ls, cd, cat, rm -rf and so on this ftp server being mounted on local filesystem.

Hi, I'm testing MinimalFTP under Linux (x86-64, Arch Linux, JVM 10.0.2) and it doesn't seem to work when accessing it from Filezilla. I thought it was my app, but the minimal code example in your README doesn't work either.

Please note that:

• it doesn't work with Filezilla (remote), but the standard linux "ftp" commandline client (localhost) works fine
• running the server under windows and accessing it with Filezilla (locahost) works
• running the server under windows and accessing it with the linux "ftp" util (remote) works, as well
• either server works accessing it from Firefox (both remote and localhost; read only, of course)
• it doesn't seems to be the case that "localhost works, and everything else don't" (also: no firewall, local LAN)
• no errors on the console (is there a way to "step up" the logging level?)

This is the Filezilla log:

Command: PWD Response: 257 "/" CWD Name Command: TYPE I Response: 200 Type set to I Command: PASV Response: 227 Enabled Passive Mode (127,0,0,1,146,245) Command: MLSD Response: 150 Sending file information list... Error: Data connection can't be estabilished. ECONNREFUSED - Connection refused by the server

(I translated from italian, sorry for any imprecision).

Thanks,

--Germano

Hi, when delete() is called on a directory, is it called also recursively on its contents? In Filezilla it seems so, but I don't know if it's true in general.

I know that in a filesystem, deleting a directory deletes its contents, but I need to release resources for files.

Thanks again,

--Germano

PS: I don't use links, neither hard nor symbolic

Hi, the class that implements IFileSystem must be thread safe, right? Are there methods that are called by one thread only? Is there a way to make everything "one thread only"?

Also, is it possible that two clients write on the same file, at the same time, so that the two OutputStream(s) must be "coordinated" (i.e., the second call to write() doesn't return until the close() method on the first OutputStream is called)? It's important for me to know this because the implementation is quite difficult, as it must take into account what happens when close() is not called because the client crashes.

I'm developing a project in which FTP is not backed by a filesystem, and so I can't use the out-of-the-box locking primitives of the "real" filesystem as you seem to do in the "reference" implementation.

Cheers, and thanks, and you did an excellent (excellent!) work,

--Germano

Exception in thread "Thread-97" java.lang.NullPointerException
   at com.guichaguri.minimalftp.FTPConnection.sendResponse(FTPConnection.java:198)
   at com.guichaguri.minimalftp.FTPConnection.processCommand(FTPConnection.java:519)
   at com.guichaguri.minimalftp.FTPConnection.process(FTPConnection.java:444)
   at com.guichaguri.minimalftp.FTPConnection.update(FTPConnection.java:556)
   at com.guichaguri.minimalftp.FTPConnection$ConnectionThread.run(FTPConnection.java:603)

Improper closing by client causes infinite handling exception SocketException inside IOException catch block produced by reader.readline(): https://github.com/Guichaguri/MinimalFTP/blob/801754d65cf2005446e85cdfec16ffcb6efbbce1/src/main/java/com/guichaguri/minimalftp/FTPConnection.java#L558-L568

Due to simple return the thread ConnectionThread hangs forever and consume a lot of CPU because of handling exceptions and filling stacktraces.

Specifically, how do we create a simple SSLContext to pass in?

// Creates a native file system
File ftpRootDir = getFtpRootDir();
NativeFileSystem fs = new NativeFileSystem(ftpRootDir);

// Creates a noop authenticator, which allows anonymous authentication
NoOpAuthenticator auth1 = new NoOpAuthenticator(fs);

// Creates a secure SSL server with the noop authenticator
server3 = new FTPServer(auth1);
server3.setExplicitSSL(false); // support SSL connections

SSLContext sslContext = howDoWeBuildSimpleSSLContext(); // ???
server3.setSSLContext(sslContext);

// Start listening asynchronously
server3.listen(InetAddress.getLoopbackAddress(), 3333);