What feature do you want to see added?

An action or an option in each inventory menu to close the menu whenever the player successfully clicks on a button.

Are there any alternatives?

Run a command that closes the menu

Describe the bug

When creating many forms, and when using /forms reload, thread dumps occur as the server cannot keep up with registering both permissions 'use' and 'commands'.

To Reproduce

1. Write a bunch of forms
2. use 'forms reload' in console
3. watch thread dumps.

Expected behaviour

The /forms reload command should reload the plugin, while not causing thread dumps.

Screenshots / Videos

15:07:10 ERROR: Current Thread: Server thread 15:07:10 ERROR: PID: 23 | Suspended: false | Native: false | State: RUNNABLE 15:07:10 ERROR: Stack: 15:07:10 ERROR: [email protected]/java.lang.StringLatin1.toLowerCase(StringLatin1.java:441) 15:07:10 ERROR: [email protected]/java.lang.String.toLowerCase(String.java:3388) 15:07:10 ERROR: org.bukkit.plugin.SimplePluginManager.unsubscribeFromPermission(SimplePluginManager.java:869) 15:07:10 ERROR: org.bukkit.permissions.PermissibleBase.clearPermissions(PermissibleBase.java:185) 15:07:10 ERROR: org.bukkit.permissions.PermissibleBase.recalculatePermissions(PermissibleBase.java:165) 15:07:10 ERROR: org.bukkit.craftbukkit.v1_19_R1.entity.CraftHumanEntity.recalculatePermissions(CraftHumanEntity.java:257) 15:07:10 ERROR: org.bukkit.plugin.SimplePluginManager.dirtyPermissibles(SimplePluginManager.java:850) 15:07:10 ERROR: org.bukkit.plugin.SimplePluginManager.calculatePermissionDefault(SimplePluginManager.java:835) 15:07:10 ERROR: org.bukkit.plugin.SimplePluginManager.addPermission(SimplePluginManager.java:796) 15:07:10 ERROR: org.bukkit.plugin.SimplePluginManager.addPermission(SimplePluginManager.java:784) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.spigot.common.handler.SpigotHandler.registerPermission(SpigotHandler.java:117) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.handler.ServerHandler.registerPermission(ServerHandler.java:61) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.interfacing.bedrock.BedrockFormRegistry.load(BedrockFormRegistry.java:53) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.interfacing.bedrock.BedrockFormRegistry.reload(BedrockFormRegistry.java:71) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.reloadable.ReloadableRegistry.reloadAll(ReloadableRegistry.java:46) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.command.defaults.ReloadCommand.lambda$register$0(ReloadCommand.java:26) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.command.defaults.ReloadCommand$$Lambda$9463/0x0000000802a361e8.execute(Unknown Source) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.shaded.cloud.execution.CommandExecutionHandler.executeFuture(CommandExecutionHandler.java:95) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.shaded.cloud.execution.CommandExecutionCoordinator$SimpleCoordinator.coordinateExecution(CommandExecutionCoordinator.java:123) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.shaded.cloud.CommandManager.executeCommand(CommandManager.java:188) 15:07:10 ERROR: CrossplatForms-Spigot.jar//dev.kejona.crossplatforms.shaded.cloud.bukkit.BukkitCommand.execute(BukkitCommand.java:116) 15:07:10 ERROR: org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:155) 15:07:10 ERROR: org.bukkit.craftbukkit.v1_19_R1.CraftServer.dispatchCommand(CraftServer.java:911) 15:07:10 ERROR: org.bukkit.craftbukkit.v1_19_R1.command.BukkitCommandWrapper.run(BukkitCommandWrapper.java:64) 15:07:10 ERROR: com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:264) 15:07:10 ERROR: net.minecraft.commands.Commands.performCommand(Commands.java:305) 15:07:10 ERROR: net.minecraft.commands.Commands.performCommand(Commands.java:289) 15:07:10 ERROR: net.minecraft.server.network.ServerGamePacketListenerImpl.performChatCommand(ServerGamePacketListenerImpl.java:2292) 15:07:10 ERROR: net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$20(ServerGamePacketListenerImpl.java:2246) 15:07:10 ERROR: net.minecraft.server.network.PlayerConnection$$Lambda$13500/0x0000000803b2bd90.run(Unknown Source) 15:07:10 ERROR: net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:59) 15:07:10 ERROR: net.minecraft.util.thread.IAsyncTaskHandler$$Lambda$13501/0x0000000803b2e000.get(Unknown Source) 15:07:10 ERROR: [email protected]/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) 15:07:10 ERROR: net.minecraft.server.TickTask.run(TickTask.java:18) 15:07:10 ERROR: net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) 15:07:10 ERROR: net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) 15:07:10 ERROR: net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1361) 15:07:10 ERROR: net.minecraft.server.MinecraftServer.d(MinecraftServer.java:185) 15:07:10 ERROR: net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) 15:07:10 ERROR: net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1338) 15:07:10 ERROR: net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1331) 15:07:10 ERROR: net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:114) 15:07:10 ERROR: net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1465) 15:07:10 ERROR: net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1193) 15:07:10 ERROR: net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305) 15:07:10 ERROR: net.minecraft.server.MinecraftServer$$Lambda$4309/0x00000008014d5618.run(Unknown Source) 15:07:10 ERROR: [email protected]/java.lang.Thread.run(Thread.java:833) 15:07:10 ERROR: ------------------------------ 15:07:10 ERROR: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH --- 15:07:10 ERROR: ------------------------------ s

Server Version and Plugins

No response

Geyser Dump

No response

CrossplatForms Version

CForms Version: 1.4.0, Branch: main, Build: 28, Commit: 9b2ad7c

Additional Context

Suggestion:

allow on config setup to decide which permissions need to be registered, instead of them doing so automatically for each form/command.

Describe the bug

The filler list that shows all of the players currently online as an input argument doesn't show player head icons next to names as intended. The form tries to load head icons but then fails and the buttons turn to full width buttons instead.

To Reproduce

1.Make any form that uses the player filler for an argument (/tpa for example or /pay ) 2. Attempt to use the form and get to the list of players

Expected behaviour

Expecting that player heads show up next to their names.

Screenshots / Videos

Server Version and Plugins

No response

Geyser Dump

https://dump.geysermc.org/mHGpHiHz50VC9JIfwc1jvBhxrxq99uP9

CrossplatForms Version

Version: 1.4.0 Branch:main Build:28 Commit:9b2ad7c

Additional Context

No response

Bumps actions/setup-java from 3.1.1 to 3.2.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

What feature do you want to see added?

Automatically convert configs from GeyserHub or a command to convert the file.

If anyone is interested in attempting this you'll need to learn or know how to use Configurate's Transformations (see 1 and 2). And everything that GeyserHub and CrossplatForms has in common will have to be translated. Start with MenuConfig and FormConfig and traverse all the fields.

Are there any alternatives?

Convert it by hand.

Bumps cumulus from 1.0-SNAPSHOT to 1.1-SNAPSHOT.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Good day.

So, what do I mean with CommandInterceptor? Basically, when a user on Bedrock runs a command the CrossplatForms plugin would do something else. For example if you have a GUI plugin for Java players that opens a GUI with the command /server, the CrosplatForms plugin would check if a Bedrock player executes the command, and if so it redirects the user to the Bedrock GUI instead. I hope that is understandable. If not, please feel free to ask me, and I will try my best to clear up any confusion. Thanks in advance for your reply.

Sincerely Rob

Bumps net.kyori.indra from 2.2.0 to 3.0.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

What feature do you want to see added?

Similar to how plugins like DeluxeMenus and ShopGUI+ do it, have each form (or menu for Java players) be in a separate yaml file. Example directory: Files/plugins/CrossplatForms/bedrock-forms/spawn-menu.yml or Files/plugins/CrossplatForms/java-menus/warps.yml

Are there any alternatives?

As mentioned above, deluxemenus and shopgui have their menus separated, but those aren't designed for Bedrock edition

Bumps adventure-api from 4.10.0 to 4.10.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps api from 2.1.0-SNAPSHOT to 2.1.1-SNAPSHOT.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

What feature do you want to see added?

Add the requirement run actions option, whose function is for the player to meet the requirement to execute the button actions, something like the following.

requirement_run_actions: #option
    1: #Requirement Name
      placeholder: '%player_empty_slots%' #placeholder 
      should_give: '5' #Value returned by the placeholder to fulfill the requirement

And that several requirements can be set and that at least one or all of them must be met

Are there any alternatives?

None

What feature do you want to see added?

Add a file like messages.yml (not in config.yml) in which you can customize the plugin's messages when you don't have permissions etc.

Are there any alternatives?

What?

What feature do you want to see added?

There could be a feature to fill empty inventory spaces with materials like glass panes.

Are there any alternatives?

Manually adding buttons of glass pane to every empty slot

What feature do you want to see added?

Ability to change SKINAPI used ether add more options or an area where we can change the skinAPI with another one

Are there any alternatives?

no not really

What feature do you want to see added?

Denizen (and its Addons) is a great Plugin with which you can do almost anything. One of the few things that you cannot do is creating cumulus for Bedrock Players so it would be great to create task/event scripts for Denizen which you can then trigger with forms.

Are there any alternatives?

Well, I could create a command script to and call that command with the needed arguments to do what I want but a direct access would be

1. More convenient
2. It is more possible to do with other plugins as Denizen (thanks to Depenizen) has a huge compatibility other plugins and make things possible that you cannot do by just running commands.

What feature do you want to see added?

Add the possibility to use should-show for dropdown components in custom forms.

Ex.:

form:
  type: custom_form
  title: "title"
  components:
    - type: dropdown
      text: "label"
      default: 0
      options:
      - "option 0"
        should-show:
        - "%placeholder_0%"
      - "option 1"
        should-show:
        - "%placeholder_1%"
      - "option 2"
        should-show:
        - "%placeholder_2%"

Are there any alternatives?

Besides creating an extra form for each option or adding a notice as a lable of what options a user can use? - None.

And those alternatives are also not really good solutions.