This is the follow up on https://github.com/hornetq/hornetq/pull/831 .

I couldn't find a way to reopen the old PR, so a new one. And I got a bit lost with Git. I'm learning that on the fly here, so I hope everything went fine. Although I'm not 100% sure.

In any case, I ran the test suite as specified with this change set and they all passed.

This patch abstracts the different HA policy configurations into their own classes. This avoids having unrelated configuration elements in the same configuration class or xml chunk.

Because of this the HornetQServerImpl class has been simplified by extracting the different Activations into their own class and moving into the Activation any code that is specific to the actual Activation. This should make it easier to extend or add any new Activation code.

This basically extends the getFirstMessageAsJSON() concept to extract just the timestamp.

For large messages in particular, this is much more efficient than returning the whole message as JSON and then extracting the timestamp.

I tested with JConsole and it is OK, but there are a few things that could be done differently, if anybody has an opinion on these things I don't mind changing them:

• should getFirstMessageTimestamp() return a java.util.Date object, the Java way of doing things, or return a long, just like the message header?
• when there are no messages in the queue, should the methods return null? There are two other possibilities that came to mind: if the return values are doubles, they could return NaN when the queue is empty. The other possibility is throwing IllegalStateException.

I'd like to have this merged into 2.3.x as well, so I've tried to keep it as simple as possible.

This is the first PR.

Some Details about the Openwire Support Implementation

OpenWire support implementation follows the mechanism HornetQ uses to support other protocols like AMQP and Stomp.

The service factory is OpenWireProtocolManagerFactory which produces OpenWireProtocolManager.

The OpenWireConnection class is responsible for the marshalling/unmarshalling of OpenWire Commands.

The AMQSession and AMQConsumer wrap hornetq core sessions and consumers. Most message related commands like (message sending, delivering, acknowledges, and transactions) are processed here.

The code has some util classes imported from ActiveMQ code base (either directly use or created from them if they are not in the activemq-client jars). They are used to hold some state informations about Openwire Connections/Sessions/Consumers/Transactions etc. Some of them may be redundant and Some may be used for ActiveMQ specific features (The first PR doesn't have much of them implemented yet). They may be cleaned up or enhanced as further works are added.

Most of them are in package org.hornetq.core.protocol.openwire.amq.

My original need is to be able to identify message producer according to it's certificate. I'm doing it using an interceptor and setting a property to each message received.

With the actual NettyConnection it's impossible to get any SSL related information so I added a getter.

Possible improvement :

• Resolve a complete different way to achieve it because interceptor are called for ALL message type.
• return more or less information (SSLEngine, Certificate chain...)
• Add this getter into Connection interface.

Note: I found out using ChannelPipeline.get(Class handlerType) was better than ChannelPipeline.get(String name) so I've also edited NettyConnection.close() method.

Here is what my interceptor looks like :

public class HornetQInterceptor implements Interceptor{

    Logger log = Logger.getLogger(HornetQInterceptor.class);

    public boolean intercept(Packet msg, RemotingConnection con)
            throws HornetQException {

        if(msg instanceof SessionSendMessage){
            SSLSession sslSession = ((NettyConnection)con.getTransportConnection()).getSSLSession();
            if(sslSession != null)
                try {
                    ((SessionSendMessage)msg).getMessage().putStringProperty("client.auth.dn", sslSession.getPeerCertificateChain()[0].getSubjectDN().getName());
                } catch (SSLPeerUnverifiedException e) {
                    log.error(e.getMessage() + " Is NettyAcceptor's param need-client-auth set to true ?");
                }
        }
        return true;
    }
}

https://issues.jboss.org/browse/JBPAPP-11049 backport changes in pull request #1037 to 2.2.eap5 branch (only difference is that I did not add the test inside due to some api changes)

blockOnAcknowledge should be true to avoid unacked messages being resent after live server crashes.

Default this attribute is false. Meaning it's possible when server crashes the messages haven't been acknowledged on server. So after fail over those unacked messages are re-delivered to client, making the test (like testReplicationDuringSync) fail.

[HORNETQ-1237] Add a HornetQ-specific system property for setting the keystore and truststore path on the client BZ 6.4.x https://bugzilla.redhat.com/show_bug.cgi?id=1288578 pr to 2.3.x https://github.com/hornetq/hornetq/pull/2066 no upstream required

In a cluster if a node is shut down (or crashed) when a message is being routed to a remote binding, a internal property may be added to the message and persisted. The name of the property is like _HQ_ROUTE_TOsf.my-cluster*. if the node starts back, it will reroute this message and if it goes to a local consumer, this property won't get removed and goes to the client.

The fix is to remove this internal property before it is sent to any client.

Implement OpenWire producer flow control. Based on configuration, when a queue's memory space is full, the producer can either be blocked (via client side window size or server side blocking), or get a relevant failure exception. The details are given in this link:

http://activemq.apache.org/producer-flow-control.html

Without this I see quite a few "method/ctor def throws at indentation level X not at correct indentation, Y" errors in Eclipse, seemingly for all throws statements that are placed on a new line.