See JENKINS-56109.

Initially discussed in #3859

Test this

• Quick-start: https://github.com/oleg-nenashev/jenkins-tabs-to-divs-config-migration-testenv
• Manual setup: docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester

Screenshots

Current status:

Needs reviews, also see: https://groups.google.com/d/msg/jenkinsci-dev/MpJMqa1Yc9A/Vex1yix8AAAJ

Proposed changelog entries

• JENKINS-56109, Tables are no longer used for layout in forms

Submitter checklist

• [x] JIRA issue is well described
• [x] Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
• [x] Appropriate autotests or explanation to why this change has no tests
• [x] UI Acceptance test / changes necessary
• [x] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@daniel-beck

Notes:

List of plugins provided by Daniel Beck which have jelly files that contain <td but not <table, indicating a reliance on existing structures at least in config.jelly and global.jelly files https://gist.github.com/daniel-beck/ef4a6f38d78014343a0ef5e85285c4ac. These therefore make a good test case for these changes in core, as we don't want all plugins to start breaking.

Description

See JENKINS-43786.

• Apply a semantic HTML
• Remove the <table> tag usage for implementing layouts and content structures. If you need reasons or arguments.
• Small re-style focused on spacing, margins, etc...
• Accesibility

Screenshots

There are more screenshots along the PR comments.

Before

After

Changelog entries

Proposed changelog entries:

• Re-styled the Manage Jenkins page, including the administrative monitors.

Submitter checklist

• [x] JIRA issue is well described
• [x] Link to JIRA ticket in description, if appropriate
• [x] An existing test was reviewed

Desired reviewers

@jenkinsci/code-reviewers

https://user-images.githubusercontent.com/43062514/141851540-cd38b475-5165-4033-a7e3-54a143fadd61.mov

What's new?

• Existing components such as textareas, selects, checkboxes and other input fields have been updated to use the new styling introduced in #5842
• Titles have been added to some settings pages to provide hierarchy and consistency
• The design for re-orderable blocks has been updated slightly so borders are always visible and remove buttons are always in the same consistent space. Picture. This is an area I'm interested in looking into/improving further. NOTE: Some plugins don't use the available Jenkins repeatableDeleteButton component, these plugins will need to be updated to use this component otherwise they may look a little odd, but still functional.
• Form widths have been increased by a fair amount over #5842. Job config pages will be updated further in a future PR to improve usage of space as seen in November UX Sig

Proposed changelog entries

• Modernise form components.

Proposed upgrade guidelines

N/A

Submitter checklist

• [ ] (If applicable) Jira issue is well described
• [ ] Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• [ ] Appropriate autotests or explanation to why this change has no tests
• [ ] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• [ ] There are at least 2 approvals for the pull request and no outstanding requests for change
• [ ] Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• [ ] Changelog entries in the PR title and/or Proposed changelog entries are correct
• [ ] Proper changelog labels are set so that the changelog can be generated automatically
• [ ] If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

This is the first of two PRs which intend to replace the existing YUI implementation of tooltips and menus with Tippy.js. This PR focuses solely on tooltips and brings native support for Tippy.js to Jenkins.

https://user-images.githubusercontent.com/43062514/160298962-5e39f965-a868-4e0a-bc3a-78bd68fe0481.mov

This brings several advantages:

• Better experience for users, animations, better placement engine
• Cleaner and better defined codebase
• Tippy is far more flexible than YUI, so we can be more creative with our designs
• Far easier to find support online
• YUI 2 is also abandoned since 2011

This implementation intends to maintain 100% backwards compatibility with the existing implementation of tooltips, it also introduces a new way to host HTML content in tooltips which is used for the project status tooltip using html-tooltip=" ... "

This change is documented in the updated Jenkins Design Library plugin.

For plugin developers

• For developers that are using Tippy.js as part of their plugin, they can now remove the dependency and instead rely on the Jenkins implementations (tooltip="hello world" or data-html-tooltip="<p>hello world</p>")

Proposed changelog entries

• Update appearance and framework for tooltips

Proposed upgrade guidelines

N/A

Submitter checklist

• [ ] (If applicable) Jira issue is well described
• [ ] Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• [ ] Appropriate autotests or explanation to why this change has no tests
• [ ] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
• [ ] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• [ ] There are at least 2 approvals for the pull request and no outstanding requests for change
• [ ] Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• [ ] Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
• [ ] Proper changelog labels are set so that the changelog can be generated automatically
• [ ] If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

JENKINS-31162

As part of this PR you can find:

• [x] a new API for managing ItemCategory
• [x] a new REST API for exposing the current configuration /jenkins/view/[...]/categories?depth=2
• [x] new UI for new items (frontend)

@reviewbybees

As part of this issue, there are other PR on the way (involved):

• [x] Maven plugin, sent a PR https://github.com/jenkinsci/maven-plugin/pull/62
• [x] Matrix project plugin, sent a PR https://github.com/jenkinsci/matrix-project-plugin/pull/33
• [x] External Monitor plugin, sent a PR https://github.com/jenkinsci/external-monitor-job-plugin/pull/9
• [x] Pipeline jobs, sent a PR https://github.com/jenkinsci/workflow-plugin/pull/375
• [x] CloudBees Folder plugin, sent a PR https://github.com/jenkinsci/cloudbees-folder-plugin/pull/56
• [x] Multibranch projects, sent a PR https://github.com/jenkinsci/workflow-multibranch-plugin/pull/1
• [x] GitHub Organization, sent a PR https://github.com/jenkinsci/github-branch-source-plugin/pull/37
• [x] Bitbucket Team, sent a PR https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/1

Known issues:

1. JENKINS-33759. Fixed
2. Copy Project option does not auto-complete (regression). Fixed

Improvements to do:

1. New Item form validation. Done

This is to make the flyweight tasks to be part of the buildable list if the executor they are restricted to run on (if any) is not available and needs to be provisioned. See: JENKINS-30084

At the moment if a flyweight task is restricted to a specific node, but the node is offline, we put the task in blocked-state. At the next iteration we check if the node is online, if not we leave the task in the blocked queue. This means we never ask the node to be provisioned.

This fix creates a buildable item if no executors are available, so that the node can be provisioned. Once the node is provisioned, the task is executed and the item removed from the list.

The change will provide a new designed login page that is using no external deps to prevent any possible malicious javascript.

new design

See JENKINS-50447.

Proposed changelog entries

• Entry 1: JENKINS-50447, new designed login page that is using no external deps to prevent any possible malicious javascript.

Proposed changelog (@oleg-nenashev)

• Major RFE, JENKINS-50447: Introduce new design of the Login page
• RFE, JENKINS-50447: Introduce new SimplePageDecorator extension point, which allows decorating the Login Page

Compatibility notes: The new Login page UI will no longer accept common PageDecorator extension points, so plugins like Simple Theme Plugin will no longer be able to apply changes to the page. SimplePageDecorator extension point should be used instead

Submitter checklist

• [x] JIRA issue is well described
• [x] Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
• [ ] Appropriate autotests or explanation to why this change has no tests
• [ ] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/code-reviewers @reviewbybees @cloudbees/team-astro

JENKINS-34670

• [x] Modify the Setup Wizard for using the full screen layout as a clear use-case.

The About page using the three different layout types (1024px x 768px).

full-screen: no header, no footer, no spaces

one-column: full width

two-column: side-panel + main-panel

@reviewbybees

https://user-images.githubusercontent.com/43062514/146660255-662a6793-3385-439c-8414-bba274548f51.mov

See JENKINS-67396

What's changed

• The way link and breadcrumb dropdowns are rendered has changed, the chevron now belongs to the link/breadcrumb which means it can propagate hover events to its parent (essentially it'll behave and look better)
• The appearance of the chevron has been updated (now using Ionicons) and it now has some subtle animations
• Added dropdowns back for job build numbers - thanks Diego and Tim (https://issues.jenkins.io/browse/JENKINS-67396)

Proposed changelog entries

• Update link and breadcrumb dropdowns.

Proposed upgrade guidelines

N/A

Submitter checklist

• [ ] (If applicable) Jira issue is well described
• [ ] Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• [ ] Appropriate autotests or explanation to why this change has no tests
• [ ] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• [ ] There are at least 2 approvals for the pull request and no outstanding requests for change
• [ ] Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• [ ] Changelog entries in the PR title and/or Proposed changelog entries are correct
• [ ] Proper changelog labels are set so that the changelog can be generated automatically
• [ ] If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

See JENKINS-59136. Related to/downstream of https://github.com/jenkins-infra/update-center2/pull/344. Triggered by this discussion in GItter

This admin monitor does not yet have a built-in dismiss button, and doesn't allow hiding individual plugins, like the security warnings monitor does. If there's a need we can add this later.

Testing notes

docker run --rm -ti -p 8080:8080 -e ID=4073 jenkins/core-pr-tester.

Some plugins get their deprecation URLs from https://github.com/jenkins-infra/update-center2/blob/master/resources/deprecations.properties, other deprecations are driven by regular labels, and those plugins use the normal plugin URL (to the plugin site).

Proposed changelog entries

• Plugins marked as deprecated in update site metadata will now have a banner about it, and if any are installed, a notification is shown to admins.

Submitter checklist

• [x] JIRA issue is well described
• [x] Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
• [x] Appropriate autotests or explanation to why this change has no tests
• [ ] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@daniel-beck @oleg-nenashev @stopalopa

JENKINS-27268

See governance meeting for brackground (starting at around 18:29 until 18:55).

Slave was literally replaced by Agent in most cases. And only two semantic change were done:

1. Dumb Slave is now Permanent Slave
2. JNLP slave agent is now JNLP Agent

• [x] Rename UI labels (properties and jelly files), only for english.
• [x] Remove language keys (properties) for other languages (agreed in the PR comments)
• [x] Rename javadocs
• [x] Rename logs and exception messages (which are visible to users or admins)
• [x] Rename "Esclavo" to "Agente" in spanish translation (sorry, I have no knowledge on any other language)

We expect to have others (native speakers) re-adding the removed keys for other languages.

@reviewbybees

Draft until tests are passing etc.

This PR introduces the Command Palette concept to Jenkins, first discussed back in the day in the November 2021 UX SIG meeting. You've probably used something similar if you've used VS Code, Jenkins.io, GitHub, Spotify etc. They're handy overlays that allow you to quickly use your keyboard to navigate, be that searching for different pages or finding functions in menus.

This is an early implementation and as such doesn't have all the features I want it to have, such as grouped results, icons and richer details for results, all aimed at making the search experience in Jenkins easier to use. I'd also like for plugin developers to eventually be able to integrate with the Command Palette so they can provide their own rich results/actions, for example being able to change theme from the palette.

Testing done

TODO

Proposed changelog entries

• Add Command Palette as replacement for search bar

Proposed upgrade guidelines

N/A

Submitter checklist

• [ ] The Jira issue, if it exists, is well-described.
• [ ] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
  • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• [ ] There is automated testing or an explanation as to why this change has no tests.
• [ ] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• [ ] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
• [ ] For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

• [ ] There are at least two (2) approvals for the pull request and no outstanding requests for change.
• [ ] Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• [ ] Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• [ ] Proper changelog labels are set so that the changelog can be generated automatically.
• [ ] If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Do not report implied dependencies for WMI Windows Agents plugin

JENKINS-70301 notes that the WMI Windows Agents plugin (id:windows-slaves) was split from core in 1.547 and is now deprecated. Because it is deprecated, users want to remove it. They cannot remove it if they have plugins installed that depend on a Jenkins version prior to 1.547.

Only two plugins in the jenkinsci GitHub organization actually depend of any classes from the WMI Windows Agent plugin.

• cli-extras-plugin - never released, no tags, no install history
• multi-slave-config - already requires windows-slaves plugin explicitly and already requires a Jenkins core version newer than 1.547. 1340 installations, last released 8 years ago

Rather than require updates of all the plugins that require a Jenkins version less than 1.547, this removes the windows-slaves plugin from the split plugins list. Users will not be warned that their plugin might have a dependency on windows-slaves because the analysis has confirmed that there is only 1 delivered plugin with that dependency, and it is an explicitly declared dependency with a newer Jenkins minimum version than the version from which the WMI Windows Agents plugin was split from Jenkins core.

A google sheet lists the plugins that have an implied dependency on the WMI Windows Agents plugin.

No automated tests because this is a one-time operation that has been tested interactively.

Testing done

• Installed suggested plugins from wizard and confirmed WMI Windows Agents plugin is not installed
• Installed slave-setup plugin (has implied WMI Windows Agents plugin dependency) and confirmed that WMI Windows Agents plugin is not installed
• Installed multi-slave-setup plugin (has explicit WMI Windows Agents plugin dependency) and confirmed that WMI Windows Agents plugin was installed as a dependency
• Remove multi-slave-setup plugin and WMI Windows Agents plugin and confirmed that Jenkins reported no errors or issues
• Installed five plugins with old base versions and confirmed that WMI Windows Agents plugin was not installed. The five plugins included backup-plugin, cloudbees-credentials-plugin, unity3d-plugin, groovy-label-assignment-plugin, and maven-deployment-linker plugin.
• Performed a backup with the backup plugin and confirmed that it was well behaved
• Removed the windows-slaves plugin as a bundled plugin so that it is not included in the war file. Confirmed the result war file loaded the five plugins tested earlier and was well behaved before and after those five plugins were uninstalled

Proposed changelog entries

• Do not report implied dependencies for WMI Windows Agents plugin.

Proposed upgrade guidelines

N/A

Submitter checklist

• [x] The Jira issue, if it exists, is well-described.
• [x] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
  • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• [x] There is automated testing or an explanation as to why this change has no tests.
• [x] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• [x] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• [x] New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• [x] For dependency updates, there are links to external changelogs and, if possible, full differentials.
• [x] For new APIs and extension points, there is a link to at least one consumer.
• [ ] Run plugin compatibility tester with an incremental build

Desired reviewers

@jglick or @bcrow

Maintainer checklist

Before the changes are marked as ready-for-merge:

• [x] There are at least two (2) approvals for the pull request and no outstanding requests for change.
• [ ] Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• [ ] Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• [ ] Proper changelog labels are set so that the changelog can be generated automatically.
• [ ] If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | eslint-config-prettier | 8.5.0 -> 8.6.0 | | | | |

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

See JENKINS-70119.

Before

After

Testing done

Proposed changelog entries

• Manage nodes and clouds table content is not align

Proposed upgrade guidelines

N/A

Submitter checklist

• [x] The Jira issue, if it exists, is well-described.
• [x] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
  • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• [x] There is automated testing or an explanation as to why this change has no tests.
• [ ] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• [ ] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
• [ ] For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• [ ] There are at least two (2) approvals for the pull request and no outstanding requests for change.
• [ ] Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• [ ] Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• [ ] Proper changelog labels are set so that the changelog can be generated automatically.
• [ ] If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).