The comment Create a cache using infinite heap. is wrong. The JCache standard only requires a cache to store at least "some" values to pass the TCK. It is not required to be heap or infinite. cache2k limits to 2000 entries by default and passes the TCK.

Is there any chance that this project would be converted to the Gradle build system? Seems like Gradle is the future and it would really come in handy to see how such a project would utilize it.

I tried converting it but as this is the first real spring project I've dealt with, I cant wrap my head around all the configuration files :)

This implementation here should be improved by not fetching single items at a time:

for (JdbcPet pet : pets) {
    owner.addPet(pet);
    pet.setType(EntityUtils.getById(getPetTypes(), PetType.class, pet.getTypeId()));
    List<Visit> visits = this.visitRepository.findByPetId(pet.getId()); // Problematic call
    for (Visit visit : visits) {
        pet.addVisit(visit);
    }
}

I'm not 100% convinced that the JDBC implementation of the pet clinic is very sensible in general. With SQL, I might be doing things a bit differently from JPA. It looks as though the whole example has been shoehorned into some pre-existing repositories.

But anyway, this one should be a no-brainer. There should be a method like:

interface VisitRepository {
    Map<Integer, List<Visit>> findByPetIds(Integer... ids);
}

Vet, Owner, Visit. The Visit "aggregate" is a little artificial but it demonstrates a useful point about not holding on to references of "parent" (reference data) objects, i.e. the Visit has an Integer petId, instead of a Pet field. In principle this app is now almost ready to migrate to multiple services if anyone wanted to do that.

I am not sure if you have to addPet() to owner again, after you find the pet for that owner using owner's ID.

Owner owner = this.ownerRepository.findById(pet.getOwnerId());

owner.addPet(pet);

@Override
    public Pet findById(int id) throws DataAccessException {
        JdbcPet pet;
        try {
            Map<String, Object> params = new HashMap<>();
            params.put("id", id);
            pet = this.namedParameterJdbcTemplate.queryForObject(
                "SELECT id, name, birth_date, type_id, owner_id FROM pets WHERE id=:id",
                params,
                new JdbcPetRowMapper());
        } catch (EmptyResultDataAccessException ex) {
            throw new ObjectRetrievalFailureException(Pet.class, id);
        }
        Owner owner = this.ownerRepository.findById(pet.getOwnerId());
        owner.addPet(pet);
        pet.setType(EntityUtils.getById(findPetTypes(), PetType.class, pet.getTypeId()));
        List<Visit> visits = this.visitRepository.findByPetId(pet.getId());
        for (Visit visit : visits) {
            pet.addVisit(visit);
        }
        return pet;
    }

cpepool6cmts1-62:SpringExamples earlbingham$ mvn tomcat7:run [INFO] Scanning for projects... Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-metadata.xml Downloading: http://repo1.maven.org/maven2/org/codehaus/mojo/maven-metadata.xml Downloaded: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-metadata.xml (12 KB at 110.0 KB/sec) Downloaded: http://repo1.maven.org/maven2/org/codehaus/mojo/maven-metadata.xml (22 KB at 170.1 KB/sec) [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.552s [INFO] Finished at: Wed Aug 07 21:00:47 PDT 2013 [INFO] Final Memory: 3M/81M [INFO] ------------------------------------------------------------------------ [ERROR] No plugin found for prefix 'tomcat7' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/Users/earlbingham/.m2/repository), central (http://repo1.maven.org/maven2)] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/NoPluginFoundForPrefixException

Problem: A test method with many individual assertions stops being executed on the first failed assertion, which prevents the remaining ones' execution.

Solution: Using AssertJ soft assertions feature, all assertions are executed, and all failures will be reported together. In this refactoring, no original assertion was changed.

Result: Before:

assertThat(owner.getLastName()).startsWith("Franklin");
assertThat(owner.getPets()).hasSize(1);
assertThat(owner.getPets().get(0).getType()).isNotNull();
assertThat(owner.getPets().get(0).getType().getName()).isEqualTo("cat");

After:

SoftAssertions softly = new SoftAssertions();
softly.assertThat(owner.getLastName()).startsWith("Franklin");
softly.assertThat(owner.getPets()).hasSize(1);
softly.assertThat(owner.getPets().get(0).getType()).isNotNull();
softly.assertThat(owner.getPets().get(0).getType().getName()).isEqualTo("cat");
softly.assertAll();

The Spring petlinic does not work on Jetty 9. The DandelionFilter throws an org.eclipse.jetty.io.EofException. I've open an issue on the Dandelion project: https://github.com/dandelion/dandelion/issues/113 Either we are waiting a fix or we replace Dandelion by another solution.

Hi there, the styling of the site displaying incorrectly, Chrome debug console shows that request for petclinic.css was failed with an error code of 404, and i looked through both my local and online repository, and I couldn't find the file in path "/resources/css/petclinic.css". Could you guys provide the css file please? Thanks. The Chrome debug console screenshot:

in addition to h2, Petclinic app comes with support for mysql, it would be nice to have similar support for the second (maybe first ;-)) most popular open source database Postgres.

Support can be done along the same lines as the one for mysql, namely to add the following files and folders:

• resources/
  • application-postgres.properties
  • db/
    • postgres/
      • data.sql
      • schema.sql

And finally, posgres jdbc driver should be added to the runtime dependencies in pom.xml

I have also attached to this issue all of the above files, for review.

resources.zip schema.sql

Content negotiation via path extension is disabled by default in Spring Boot. This was causing the /vets.json page to show XML instead of JSON.

More info about content negotiation found here: https://docs.spring.io/spring-boot/docs/2.0.0.RC1/reference/html/boot-features-developing-web-applications.html#boot-features-spring-mvc-pathmatch

When I run ./mvnw package I get this:

Exception in thread "main" java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.maven.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:39) at org.apache.maven.wrapper.WrapperExecutor.execute(WrapperExecutor.java:122) at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:61) Caused by: java.lang.NoClassDefFoundError: org/apache/commons/cli/UnrecognizedOptionException at java.lang.Class.getDeclaredMethods0(Native Method) at java.lang.Class.privateGetDeclaredMethods(Class.java:2701) at java.lang.Class.privateGetMethodRecursive(Class.java:3048) at java.lang.Class.getMethod0(Class.java:3018) at java.lang.Class.getMethod(Class.java:1784) at org.codehaus.plexus.classworlds.launcher.Launcher.getEnhancedMainMethod(Launcher.java:168) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:261) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347) ... 7 more Caused by: java.lang.ClassNotFoundException: org.apache.commons.cli.UnrecognizedOptionException at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50) at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239) ... 17 more

https://github.com/PebbleTemplates/spring-petclinic/blob/master/readme.md?plain=1#L13 The link to clone the project is not correct. It should be https://github.com/PebbleTemplates/spring-petclinic.git