When we upgraded from 1.12.13 to 1.13.4 we can't create the injector due to this exception

1) Explicit bindings are required and com.netflix.governator.LifecycleManager is not explicitly bound.
  while locating com.netflix.governator.LifecycleManager
    for parameter 0 at com.netflix.governator.LifecycleListenerModule$LifecycleListenerProvisionListener.initialize(LifecycleListenerModule.java:43)
  at com.netflix.governator.LifecycleListenerModule$LifecycleListenerProvisionListener.initialize(LifecycleListenerModule.java:43)
  at com.netflix.governator.LifecycleListenerModule.configure(LifecycleListenerModule.java:24)
1 error
    at com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:466)
    at com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
    at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
    at com.google.inject.internal.InjectorImpl.createChildInjector(InjectorImpl.java:226)
    at com.netflix.governator.guice.LifecycleInjector.createChildInjector(LifecycleInjector.java:327)
    at com.netflix.governator.guice.LifecycleInjector.createInjector(LifecycleInjector.java:399)
    at com.netflix.governator.guice.LifecycleInjector.createInjector(LifecycleInjector.java:348)

We tracked this bug to start at 1.12.15 (1.12.14 is messed up - lots of compilation errors).

Not sure if this belongs here or in Karyon or elsewhere...

When I try to use @AutoBindSingleton with multibindings to achieve plugin style auto discovery of things, I'm getting binding errors.

INFO: Initiating Jersey application, version 'Jersey: 1.17.1 02/28/2013 03:28 PM'
Oct 28, 2013 1:05:36 PM com.sun.jersey.guice.spi.container.GuiceComponentProviderFactory getComponentProvider
SEVERE: Cannot bind com.xxx.MyResource
com.google.inject.ConfigurationException: Guice configuration errors:

1) Unable to create binding for java.util.Set<com.xxx.features.Feature>. It was already configured on one or more child injectors or private modules
    bound at com.netflix.governator.guice.InternalAutoBindModule.bindAutoBindSingleton(InternalAutoBindModule.java:196)
  If it was in a PrivateModule, did you forget to expose the binding?
  while locating java.util.Set<com.xxx.features.Feature>
    for field at com.xxx.MyResource.feature(MyResource.java:53)
  while locating com.xxx.MyResource

1 error
    at com.google.inject.internal.InjectorImpl.getBinding(InjectorImpl.java:150)
    at com.google.inject.internal.InjectorImpl.getBinding(InjectorImpl.java:66)
    at com.sun.jersey.guice.spi.container.GuiceComponentProviderFactory.getComponentProvider(GuiceComponentProviderFactory.java:136)
    at com.sun.jersey.server.impl.component.IoCResourceFactory.getComponentProvider(IoCResourceFactory.java:76)
    at com.sun.jersey.server.impl.application.WebApplicationImpl.getResourceComponentProvider(WebApplicationImpl.java:579)
    at com.sun.jersey.server.impl.application.WebApplicationImpl.initiateResource(WebApplicationImpl.java:657)
    at com.sun.jersey.server.impl.application.WebApplicationImpl.initiateResource(WebApplicationImpl.java:652)
    at com.sun.jersey.server.impl.application.RootResourceUriRules.<init>(RootResourceUriRules.java:124)
    at com.sun.jersey.server.impl.application.WebApplicationImpl._initiate(WebApplicationImpl.java:1331)
    at com.sun.jersey.server.impl.application.WebApplicationImpl.access$700(WebApplicationImpl.java:168)
    at com.sun.jersey.server.impl.application.WebApplicationImpl$13.f(WebApplicationImpl.java:774)
    at com.sun.jersey.server.impl.application.WebApplicationImpl$13.f(WebApplicationImpl.java:770)
    at com.sun.jersey.spi.inject.Errors.processWithErrors(Errors.java:193)
    at com.sun.jersey.server.impl.application.WebApplicationImpl.initiate(WebApplicationImpl.java:770)
    at com.sun.jersey.guice.spi.container.servlet.GuiceContainer.initiate(GuiceContainer.java:121)
    at com.sun.jersey.spi.container.servlet.ServletContainer$InternalWebComponent.initiate(ServletContainer.java:319)
    at com.sun.jersey.spi.container.servlet.WebComponent.load(WebComponent.java:605)
    at com.sun.jersey.spi.container.servlet.WebComponent.init(WebComponent.java:210)
    at com.sun.jersey.spi.container.servlet.ServletContainer.init(ServletContainer.java:374)
    at com.sun.jersey.spi.container.servlet.ServletContainer.init(ServletContainer.java:557)
    at javax.servlet.GenericServlet.init(GenericServlet.java:241)
    at com.google.inject.servlet.ServletDefinition.init(ServletDefinition.java:117)
    at com.google.inject.servlet.ManagedServletPipeline.init(ManagedServletPipeline.java:82)
    at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:102)
    at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:172)
    at org.mortbay.jetty.servlet.FilterHolder.doStart(FilterHolder.java:97)
    at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
    at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:713)
    at org.mortbay.jetty.servlet.Context.startContext(Context.java:140)
    at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1282)
    at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:518)
    at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:499)
    at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
    at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
    at org.mortbay.jetty.Server.doStart(Server.java:224)
    at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
    at runjettyrun.Bootstrap.main(Bootstrap.java:97)

My best guess is that MyResource is being internally bound by Governator since it depends on my auto-injected stuff, so when it gets to the GuiceComponent, it has already been bound.

Anyone hit this before? Are there known workarounds, or maybe I'm just missing some config?

Say I have a cache implementation with a number of configuration parameters. My application may have 5 instances of this cache used for different purposes. I want all 5 caches to be independently configurable.

This seems like a use case right in Governator's sweet spot, but its not explicitly called out in the documentation. What is the recommended way to do this?

Thanks.

Integrate the JDK ServiceLoader with Guice making it possible to inject a Set of services and allowing member injection on these services. Two modes will be supported.

1. Eager loading of services at startup with support for multibinding so additional bindings for services can be added outside of the ServiceLoader
2. Lazy loading of services until Set is injected but without allowing for additional bindings to be added using multibindings

Example,

Eager binding,

injectorBuilder.withAdditionalModules(new ServiceLoaderModule() {
    void configure() {
        // Instantiate and load services of type MyService.  
        bindServices(MyService.class).usingMultibinding();
        // This is legal,
        Multibinder.newSetBinder(binder(), MyService.class).addBinding().to(MyServiceImpl.class);
    }
});

Lazy binding

injectorBuilder.withAdditionalModules(new ServiceLoaderModule() {
    void configure() {
        bindServices(MyService.class);
        // This is illegal now because the above line fully implements the binding for Set<MyService>
        // Multibinder.newSetBinder(binder(), MyService.class).addBinding().to(MyServiceImpl.class);
    }
});

Injecting

public class SomeApplicationClass {
    @Inject
    public SomeApplicationClass(Set<MyService> services) {  

    }
}

Example service,

public class MyServiceImpl Implements MyService {
    public MyServiceImpl() {
    }

    // This injection will be done when Set<MyService> is first injected
    @Inject
    public voidSetSomeDependency(SomeDependency dep) {  
    }
}

In order to show the necessity of https://github.com/Netflix/governator/pull/397 , I tried building governator with Java11. I was unable to do so because the version string parser couldn't parse JDK11 version:

* What went wrong:
Could not determine java version from '11.0.2'.

This pull requests adds the concept of an application runner that will handle the runtime lifecycle of an entire application (i.e starting LifecycleManager, waiting for the application to exit, closing LifecycleManager) as part of the LifecycleInjector bootstrapping and allow for much simpler integration with the container in which Governator is used (i.e Standalone, Jetty, Tomcat, …). This method is an alternative to having to get the instance of LifecycleManager and calling start() and close() outside of governator. A specific runner implementation is implemented as a BootstrapModule which must provide a binding to LifecycleRunner.

Example standalone application,

public class Application {
    @Inject
    public Application(@Main List<String> args) {
    }

    public static void main(String[] args) {
        LifecycleInjector.builder()
            .withAdditionalBootstrapModules(
                StandaloneRunnerModule.builder()
                    .withTerminateEvent(new SelfDestructingTerminationEvent(10, TimeUnit.SECONDS))
                    .withArgs(args)
                    .withMainClass(Application.class)
                    .build())
            .build();  // Calling build will trigger creating the runner
    }
}

I also prototyped a simple Jetty based runner and would like to add it as a sub project but governor has not been set up for sub projects yet. Any suggesting for how to proceed would be greatly appreciated.

A Jetty based hello world app would look like this

@Path("/")
public class HelloWorldWebApp {

    public static void main(String[] args) {
        LifecycleInjector.builder()
            .withModules(new JerseyServletModule() {
                @Override
                protected void configureServlets() {
                    bind(HelloWorldWebApp.class);
                    bind(GuiceContainer.class).asEagerSingleton();
                    serve("/*").with(GuiceContainer.class);
                }
            })
            .withAdditionalBootstrapModules(new JettyRunnerModule())
            .build();
    }

    @GET
    public String hello() {
        return "hello";
    }
}

Guice doesn't consider these classes as "injected", so LifecycleManager isn't made aware of them.

Not necessarily a bug, but might not be behavior people expect.

For singleton objects that need warmup / preDestroy, they can be manually added the LifecycleManager as a workaround it seems.

We have a custom annotation that let's us declare our module dependencies. At startup time, we search for these annotations and install the modules in our injector. It would be very helpful if Governator had something functionally similar.

Here is an example:

@DependsOn({
   SomeGuiceModule.class,
   AnotherGuiceModule.class,
});
class MyModule extends AbstractModule { ... } 

Using child injectors can be problematic in certain situations where the injector must be injected (usually part of framework code with dynamic class loading) resulting in the wrong injector being injected. While there are some workarounds to this problem they are not obvious and have issues of their own. This pull request make it possible to have the LifecycleInjector discard the bootstrap injector thereby making the injector returned by createInjector() a root injector.

When I use CompositeConfigurationProvider such as the following code:

binder.bindConfigurationProvider().toInstance(
                                                new CompositeConfigurationProvider(
                                                        ArchaiusConfigurationProvider.builder().build(),
                                                        new PropertiesConfigurationProvider(properties)));

ArchaiusConfigurationProvider owns all properties even they are not defined. If the property is not defined in Archaius, it should fall back to other configuration provider chained above.

The temporary solution can be the following:

ConfigurationOwnershipPolicy ownershipPolicy = new ConfigurationOwnershipPolicy() {
                                            @Override
                                            public boolean has(ConfigurationKey key, Map<String, String> variableValues) {
                                                return !properties.containsKey(key.getKey(variableValues));
                                            }
                                        };

and hook up the above ownershipPolicy with ArchiausConfigurationProvider at withOwnershipPolicy.

Please add support for injection via @Resource annotation: @Resource public void setResource(Jsr250Resource resource) { this.resource = resource; }

With this feature Governator will be fully JSR-250 compliant and can fully replace old Mycila-Guice project.

You can see implementation example in Mycila-Guice project: com.mycila.inject.jsr250.Jsr250KeyProvider

I've tried to combine Mycila-Guice and Governator with:

injector = LifecycleInjector.builder().withBootstrapModule(new BootstrapModule() { @Override public void configure(BootstrapBinder binder) { binder.install(Jsr250.newJsr250Module()); } }).withModules(allModules).inStage(Stage.PRODUCTION).createInjector();

But in this case @PostConstruct methods called twice :(

Parallel builds. This project contains multiple modules. Parallel builds can improve the build speed by executing tasks in parallel. We can enable this feature by setting org.gradle.parallel=true.

File system watching. Since Gradle 6.5, File system watching was introduced which can help to avoid unnecessary I/O. This feature is the default since 7.0. For an older version, we can enable this feature by setting org.gradle.vfs.watch=true.

Configuration on demand. Configuration on demand tells Gradle to configure modules that only are relevant to the requested tasks instead of configuring all of them. We can enable this feature by setting org.gradle.configureondemand=true.

gradle caching. Shared caches can reduce the number of tasks you need to execute by reusing outputs already generated elsewhere. This can significantly decrease build times. We can enable this feature by setting org.gradle.caching=true.

===================== If there are any inappropriate modifications in this PR, please give me a reply and I will change them.

When LifecycleInjectorCreator.createInjector is failed, there is attempt to close preDestroyMonitor. But it may not be initialized yet, it is causing NPE to be logged.

Suggestion is to check preDestroyMonitor for null before calling close() on it or log warn instead of error with stacktrace.

java.lang.NullPointerException: null
	at com.netflix.governator.LifecycleModule$LifecycleProvisionListener.onStopped(LifecycleModule.java:136) ~[governator-core-1.17.7.jar]
	at com.netflix.governator.SafeLifecycleListener.onStopped(SafeLifecycleListener.java:58) ~[governator-core-1.17.7.jar]
	at com.netflix.governator.LifecycleManager.notifyStartFailed(LifecycleManager.java:118) ~[governator-core-1.17.7.jar]
	at com.netflix.governator.LifecycleInjectorCreator.createInjector(LifecycleInjectorCreator.java:131) ~[governator-core-1.17.7.jar]
	at com.netflix.governator.LifecycleInjectorCreator.createInjector(LifecycleInjectorCreator.java:38) ~[governator-core-1.17.7.jar]
	at com.netflix.governator.InjectorBuilder.createInjector(InjectorBuilder.java:209) ~[governator-core-1.17.7.jar]
	at com.netflix.governator.InjectorBuilder.createInjector(InjectorBuilder.java:223) ~[governator-core-1.17.7.jar]

Please update wiki's content according to the latest release .e.g

https://github.com/Netflix/governator/wiki/Module-Dependencies

LifecycleInjector.builder()
   .withAdditionalModuleClasses(ApplicationModule.class)
   .build().createInjector();

withAdditionalModuleClasses() has been deprecated

https://github.com/Netflix/governator/wiki/Getting-Started

LifecycleManager   manager = injector.getInstance(LifecycleManager.class);
manager.start();

Method LifecycleManager ::start() has been removed or renamed

Travis are now recommending removing the sudo tag.

"If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration"