Catch common Java mistakes as compile-time errors

Last update: Dec 31, 2022

Related tags

Overview

Error Prone

Error Prone is a static analysis tool for Java that catches common programming mistakes at compile-time.

public class ShortSet {
  public static void main (String[] args) {
    Set<Short> s = new HashSet<>();
    for (short i = 0; i < 100; i++) {
      s.add(i);
      s.remove(i - 1);
    }
    System.out.println(s.size());
  }
}

error: [CollectionIncompatibleType] Argument 'i - 1' should not be passed to this method;
its type int is not compatible with its collection's type argument Short
      s.remove(i - 1);
              ^
    (see https://errorprone.info/bugpattern/CollectionIncompatibleType)
1 error

Getting Started

Our documentation is at errorprone.info.

Error Prone works with Bazel, Maven, Ant, and Gradle. See our installation instructions for details.

Developing Error Prone

Developing and building Error Prone is documented on the wiki.

Links

Mailing lists
- General discussion
- Announcements
Javadoc
Pre-release snapshots are available from Sonatype's snapshot repository.

Comments

JDK 14/15 compatibility

What version of Error Prone are you using?

2.3.4 (originally 2.3.1)

Does this issue reproduce with the latest release?

Yes

What did you do?

Error-prone does not work with JDK12 EA b09 and produces the following exception:

    [javac] 1 warning
    [javac] An exception has occurred in the compiler (12-ea). Please file a bug against the Java compiler via the Java bug reporting page (http://bugreport.java.com) after checking the Bug Database (http://bugs.java.com) for duplicates. Include your program and the following diagnostic in your report. Thank you.
    [javac] java.lang.NoSuchMethodError: com.sun.tools.javac.util.Log.error(Lcom/sun/tools/javac/util/JCDiagnostic$DiagnosticPosition;Ljava/lang/String;[Ljava/lang/Object;)V
    [javac] 	at com.google.errorprone.ErrorProneError.logFatalError(ErrorProneError.java:55)
    [javac] 	at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:155)
    [javac] 	at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
    [javac] 	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1418)
    [javac] 	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1365)
    [javac] 	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:960)
    [javac] 	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:311)
    [javac] 	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:170)
    [javac] 	at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:57)
    [javac] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [javac] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    [javac] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    [javac] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    [javac] 	at org.apache.tools.ant.taskdefs.compilers.Javac13.execute(Javac13.java:57)
    [javac] 	at org.apache.tools.ant.taskdefs.Javac.compile(Javac.java:1404)
    [javac] 	at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:1133)
    [javac] 	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
    [javac] 	at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
    [javac] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    [javac] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    [javac] 	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
    [javac] 	at org.apache.tools.ant.Task.perform(Task.java:350)
    [javac] 	at org.apache.tools.ant.Target.execute(Target.java:449)
    [javac] 	at org.apache.tools.ant.Target.performTasks(Target.java:470)
    [javac] 	at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1388)
    [javac] 	at org.apache.tools.ant.Project.executeTarget(Project.java:1361)
    [javac] 	at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
    [javac] 	at org.apache.tools.ant.Project.executeTargets(Project.java:1251)
    [javac] 	at org.apache.tools.ant.Main.runBuild(Main.java:834)
    [javac] 	at org.apache.tools.ant.Main.startAnt(Main.java:223)
    [javac] 	at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
    [javac] 	at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)

It works fine with previous build (JDK 12 EA b08). I don't know what change causes this error.

opened by don-vip 48

Full Java 8 support
Original issue created by [email protected] on 2014-03-27 at 04:19 PM

Right now we have a build for javac 8 but are missing two important items needed for full support:

Our Jenkins continuous build does not run Java 8 yet, only 6 and 7.

We don't yet distribute the error-prone 8 jars to Sonatype. We probably want to distribute two sets of jars, one for versions 6 and 7, and one for 8. It would be nice if Maven could figure out which dependency to use based on the version of javac installed.

Priority-High migrated Status-Accepted
opened by cushon 26

'An illegal reflective access operation has occurred' warnings

The warning:

Changes detected - recompiling the module!
Compiling 8 source files to /home/my_stuff/target/classes
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.errorprone.bugpatterns.FutureReturnValueIgnored (file:/my_home/.m2/repository/com/google/errorprone/error_prone_core/2.3.2/error_prone_core-2.3.2.jar) to field com.sun.tools.javac.code.Type$StructuralTypeMapping$4.this$0
WARNING: Please consider reporting this to the maintainers of com.google.errorprone.bugpatterns.FutureReturnValueIgnored
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

$ java --version
openjdk 11.0.1 2018-10-16
OpenJDK Runtime Environment 18.9 (build 11.0.1+13)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.1+13, mixed mode)

Java code that (rightfully) triggers the warning:

@SuppressWarnings("FutureReturnValueIgnored")
private void schedule(Runnable runnable, long delayMs) {
    try {
        scheduledExecutorService.schedule(runnable, delayMs, TimeUnit.MILLISECONDS);
    } catch (RejectedExecutionException ex) {
        // shutting down, no more checks
    }
}

I'm using the maven plugin as such:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-compiler-plugin</artifactId>
    <version>3.8.0</version>
    <configuration>
        <release>11</release>
        <debug>true</debug>
        <showDeprecation>true</showDeprecation>
        <showWarnings>true</showWarnings>
        <compilerArgument>-parameters</compilerArgument>
        <compilerArgs>
            <arg>-Xlint:all</arg>
            <arg>-Xlint:-processing</arg>
            <arg>-Werror</arg>
            <arg>-XDcompilePolicy=simple</arg>
            <arg>-Xplugin:ErrorProne</arg> 
        </compilerArgs>
        <annotationProcessorPaths>
            <path>
                <groupId>com.google.errorprone</groupId>
                <artifactId>error_prone_core</artifactId>
                <version>2.3.2</version>
            </path>
        </annotationProcessorPaths> 
    </configuration>
</plugin>

opened by zimmi 24

lombok causes an IndexOutOfBoundsException in ParameterName

After #690 was fixed, I removed the exclusions for the problematic bug patterns and tried to compile a project using Lombok, but it looks like the new bug pattern ParameterName also does not work well with Lombok it seems. Next time I'll make sure to try out Error Prone snapshots before a release :)

Versions

Error Prone version: 2.1.2 Lombok version: 1.16.18 / 1.16.16 Maven version: Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-04T04:39:06+09:00) Java version: 1.8.0_144, vendor: Oracle Corporation

Note that I am also able to reproduce the issue with JDK 9.

Reproducing Class:

import lombok.Data;

@Data
public class SomeData {}

Stack trace

[ERROR]      Please report this at https://github.com/google/error-prone/issues/new and include the following:
[ERROR]   
[ERROR]      error-prone version: 2.1.2
[ERROR]      Stack Trace:
[ERROR]      java.lang.IndexOutOfBoundsException
[ERROR]         at java.nio.HeapCharBuffer.subSequence(HeapCharBuffer.java:580)
[ERROR]         at java.nio.HeapCharBuffer.subSequence(HeapCharBuffer.java:42)
[ERROR]         at com.google.errorprone.bugpatterns.ParameterName.checkArguments(ParameterName.java:85)
[ERROR]         at com.google.errorprone.bugpatterns.ParameterName.matchMethodInvocation(ParameterName.java:64)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitMethodInvocation(ErrorProneScanner.java:907)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitMethodInvocation(ErrorProneScanner.java:146)
[ERROR]         at com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1644)
[ERROR]         at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)
[ERROR]         at com.sun.source.util.TreeScanner.visitUnary(TreeScanner.java:612)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitUnary(ErrorProneScanner.java:1126)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitUnary(ErrorProneScanner.java:146)
[ERROR]         at com.sun.tools.javac.tree.JCTree$JCUnary.accept(JCTree.java:1956)
[ERROR]         at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)
[ERROR]         at com.sun.source.util.TreeScanner.visitIf(TreeScanner.java:418)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitIf(ErrorProneScanner.java:758)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitIf(ErrorProneScanner.java:146)
[ERROR]         at com.sun.tools.javac.tree.JCTree$JCIf.accept(JCTree.java:1427)
[ERROR]         at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)
[ERROR]         at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:90)
[ERROR]         at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105)
[ERROR]         at com.sun.source.util.TreeScanner.visitBlock(TreeScanner.java:248)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitBlock(ErrorProneScanner.java:530)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitBlock(ErrorProneScanner.java:146)
[ERROR]         at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
[ERROR]         at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)
[ERROR]         at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:90)
[ERROR]         at com.sun.source.util.TreeScanner.visitMethod(TreeScanner.java:206)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitMethod(ErrorProneScanner.java:898)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitMethod(ErrorProneScanner.java:146)
[ERROR]         at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:898)
[ERROR]         at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)
[ERROR]         at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:90)
[ERROR]         at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105)
[ERROR]         at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:113)
[ERROR]         at com.sun.source.util.TreeScanner.visitClass(TreeScanner.java:187)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:590)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:146)
[ERROR]         at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)
[ERROR]         at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)
[ERROR]         at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105)
[ERROR]         at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:113)
[ERROR]         at com.sun.source.util.TreeScanner.visitCompilationUnit(TreeScanner.java:144)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:605)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:146)
[ERROR]         at com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:591)
[ERROR]         at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:64)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:41)
[ERROR]         at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:145)
[ERROR]         at com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:120)
[ERROR]         at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1425)
[ERROR]         at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1374)
[ERROR]         at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
[ERROR]         at com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:100)
[ERROR]         at com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:142)
[ERROR]         at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:96)
[ERROR]         at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:90)
[ERROR]         at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:137)
[ERROR]         at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:108)
[ERROR]         at com.google.errorprone.ErrorProneCompiler.run(ErrorProneCompiler.java:118)
[ERROR]         at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne$CompilerInvoker.compile(JavacCompilerWithErrorProne.java:222)
[ERROR]         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR]         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[ERROR]         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR]         at java.lang.reflect.Method.invoke(Method.java:498)
[ERROR]         at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile(JavacCompilerWithErrorProne.java:91)
[ERROR]         at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1075)
[ERROR]         at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:168)
[ERROR]         at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
[ERROR]         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
[ERROR]         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
[ERROR]         at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
[ERROR]         at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
[ERROR]         at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
[ERROR]         at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
[ERROR]         at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
[ERROR]         at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
[ERROR]         at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
[ERROR]         at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
[ERROR]         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR]         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[ERROR]         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR]         at java.lang.reflect.Method.invoke(Method.java:498)
[ERROR]         at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
[ERROR]         at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
[ERROR]         at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
[ERROR]         at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
[ERROR]         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR]         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[ERROR]         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR]         at java.lang.reflect.Method.invoke(Method.java:498)
[ERROR]         at org.apache.maven.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:39)
[ERROR]         at org.apache.maven.wrapper.WrapperExecutor.execute(WrapperExecutor.java:122)
[ERROR]         at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:50)

Workaround

Disable the newly introduced ParameterName bug pattern via a compiler argument: -Xep:ParameterName:OFF

lombok

opened by shakuzen 24

NullPointerException in 2.1.1 in Android compilation

I can't see an obvious check that's failing here. This is compiling an Android application.

3 warnings
An exception has occurred in the compiler (1.8.0_112-release). Please file a bug against the Java compiler via the Java bug reporting page (http://bugreport.java.com) after checking the Bug Database (http://bugs.java.com) for duplicates. Include your program and the following diagnostic in your report. Thank you.
java.lang.NullPointerException
	at com.sun.tools.javac.comp.Flow$FlowAnalyzer.visitApply(Flow.java:1233)
	at com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1628)
	at com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
	at com.sun.tools.javac.comp.Flow$BaseAnalyzer.scan(Flow.java:393)
	at com.sun.tools.javac.tree.TreeScanner.visitExec(TreeScanner.java:213)
	at com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1446)
	at com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
	at com.sun.tools.javac.comp.Flow$BaseAnalyzer.scan(Flow.java:393)
	at com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:57)
	at com.sun.tools.javac.comp.Flow$FlowAnalyzer.visitBlock(Flow.java:995)
	at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1014)
	at com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
	at com.sun.tools.javac.comp.Flow$BaseAnalyzer.scan(Flow.java:393)
	at com.sun.tools.javac.comp.Flow$FlowAnalyzer.visitMethodDef(Flow.java:962)
	at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:866)
	at com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
	at com.sun.tools.javac.comp.Flow$BaseAnalyzer.scan(Flow.java:393)
	at com.sun.tools.javac.comp.Flow$FlowAnalyzer.visitClassDef(Flow.java:925)
	at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:774)
	at com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
	at com.sun.tools.javac.comp.Flow$BaseAnalyzer.scan(Flow.java:393)
	at com.sun.tools.javac.comp.Flow$FlowAnalyzer.analyzeTree(Flow.java:1325)
	at com.sun.tools.javac.comp.Flow$FlowAnalyzer.analyzeTree(Flow.java:1315)
	at com.sun.tools.javac.comp.Flow.analyzeTree(Flow.java:213)
	at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1410)
	at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1374)
	at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
	at com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:100)
	at com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:142)
	at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:96)
	at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:90)
	at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:137)
	at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:108)
	at com.google.errorprone.ErrorProneCompiler.run(ErrorProneCompiler.java:118)
	at com.google.errorprone.ErrorProneCompiler.compile(ErrorProneCompiler.java:65)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.ltgt.gradle.errorprone.ErrorProneCompiler.execute(ErrorProneCompiler.java:76)
	at net.ltgt.gradle.errorprone.ErrorProneCompiler.execute(ErrorProneCompiler.java:26)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.delegateAndHandleErrors(NormalizingJavaCompiler.java:104)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:53)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:38)
	at org.gradle.api.internal.tasks.compile.CleaningJavaCompilerSupport.execute(CleaningJavaCompilerSupport.java:35)
	at org.gradle.api.internal.tasks.compile.CleaningJavaCompilerSupport.execute(CleaningJavaCompilerSupport.java:25)
	at org.gradle.api.tasks.compile.JavaCompile.performCompilation(JavaCompile.java:206)
	at org.gradle.api.tasks.compile.JavaCompile.compile(JavaCompile.java:187)
	at org.gradle.api.tasks.compile.JavaCompile.compile(JavaCompile.java:130)
	at com.android.build.gradle.tasks.factory.AndroidJavaCompile.compile(AndroidJavaCompile.java:49)
	at sun.reflect.GeneratedMethodAccessor1187.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
	at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$IncrementalTaskAction.doExecute(DefaultTaskClassInfoStore.java:163)
	at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)
	at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)
	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)
	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)
	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)
	at org.gradle.internal.Transformers$4.transform(Transformers.java:169)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)
	at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)
	at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
	at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

 FAILED

FAILURE: Build failed with an exception.

opened by leepa 24

Infinite compilation on JDK11
When upgrading to JDK 11.01, the compilation never finishes but has high CPU activity. When removing ErrorProne, the compilation completes without a problem. I am unsure how to debug, e.g. to see what the javac process is doing, to provide more details.

Environment:

JDK 11.01 (upgrading from 10+46)

Mac OS X Mojave

Gradle 5.0

ErrorProne:

core: 2.3.2

javac: 9+181-r4173-1

plugin: 0.6

Annotation Processors:

autoFactory: 1.0-beta6

autoValue: 1.6.3

autoValueBuilder: 2.9.1

Of course if I disable the annotation processors then it fails due to the missing generated classes, but does terminate. Removing autoFactory leads to the hang, while autoValue is used too frequently to get a hang prior. So there is a chance that it is related to annotation processing (such as due to Gradle's incremental support), but could be something else.
opened by ben-manes 21

Lombok breaks NestedInstanceOfConditions and InstanceOfAndCastMatchWrongType

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T15:39:06-04:00) Java version: 1.8.0_131, vendor: Oracle Corporation Lombok version: 1.16.16

java.lang.NullPointerException
        at lombok.javac.apt.LombokFileObjects.createEmpty(LombokFileObjects.java:123)
        at lombok.javac.apt.InterceptingJavaFileManager.getJavaFileForOutput(InterceptingJavaFileManager.java:47)
        at com.sun.tools.javac.processing.JavacFiler.createSourceOrClassFile(JavacFiler.java:478)
        at com.sun.tools.javac.processing.JavacFiler.createSourceFile(JavacFiler.java:417)
        at lombok.javac.apt.LombokProcessor.forceNewRound(LombokProcessor.java:333)
        at lombok.javac.apt.LombokProcessor.process(LombokProcessor.java:322)
        at lombok.core.AnnotationProcessor$JavacDescriptor.process(AnnotationProcessor.java:114)
        at lombok.core.AnnotationProcessor.process(AnnotationProcessor.java:164)
        at lombok.launch.AnnotationProcessorHider$AnnotationProcessor.process(AnnotationProcessor.java:74)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:968)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:884)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$2200(JavacProcessingEnvironment.java:108)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1204)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1313)
        at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1267)
        at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:943)
        at com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:100)
        at com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:142)
        at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:96)
        at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:90)
        at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:137)
        at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:108)
        at com.google.errorprone.ErrorProneCompiler.run(ErrorProneCompiler.java:118)
        at com.google.errorprone.ErrorProneCompiler.compile(ErrorProneCompiler.java:65)
        at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne$CompilerInvoker.compile(JavacCompilerWithErrorProne.java:219)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile(JavacCompilerWithErrorProne.java:91)
        at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:825)
        at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:129)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
        at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)

error-prone version: 2.0.21                                                                                                                                                 
Stack Trace:                                                                                                                                                                
java.lang.ClassCastException: com.sun.tools.javac.tree.JCTree$JCBinary cannot be cast to com.sun.source.tree.ParenthesizedTree                                              
   at com.google.errorprone.bugpatterns.NestedInstanceOfConditions.matchIf(NestedInstanceOfConditions.java:53)                                                              
   at com.google.errorprone.scanner.ErrorProneScanner.visitIf(ErrorProneScanner.java:752)                                                                                   
   at com.google.errorprone.scanner.ErrorProneScanner.visitIf(ErrorProneScanner.java:146)                                                                                   
   at com.sun.tools.javac.tree.JCTree$JCIf.accept(JCTree.java:1427)                                                                                                         
   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)                                                                                                     
   at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)                                                                                                           
   at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)                                                                                                           
   at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105)                                                                                                            
   at com.sun.source.util.TreeScanner.visitBlock(TreeScanner.java:248)                                                                                                      
   at com.google.errorprone.scanner.ErrorProneScanner.visitBlock(ErrorProneScanner.java:530)                                                                                
   at com.google.errorprone.scanner.ErrorProneScanner.visitBlock(ErrorProneScanner.java:146)                                                                                
   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)                                                                                                      
   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)                                                                                                     
   at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)                                                                                                           
   at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)                                                                                                           
   at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:90)                                                                                                    
   at com.sun.source.util.TreeScanner.visitMethod(TreeScanner.java:206)                                                                                                     
   at com.google.errorprone.scanner.ErrorProneScanner.visitMethod(ErrorProneScanner.java:898)                                                                               
   at com.google.errorprone.scanner.ErrorProneScanner.visitMethod(ErrorProneScanner.java:146)                                                                               
   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:898)                                                                                                  
   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)                                                                                                     
   at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)                                                                                                           
   at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)                                                                                                           
   at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:90)                                                                                                    
   at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105)                                                                                                            
   at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:113)                                                                                                   
   at com.sun.source.util.TreeScanner.visitClass(TreeScanner.java:187)                                                                                                      
   at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:590)                                                                                
   at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:146)                                                                                
   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)                                                                                                   
   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)                                                                                                     
   at com.google.errorprone.scanner.Scanner.scan(Scanner.java:82)                                                                                                           
   at com.google.errorprone.scanner.Scanner.scan(Scanner.java:42)                                                                                                           
   at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105)                                                                                                            
   at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:113)                                                                                                   
   at com.sun.source.util.TreeScanner.visitCompilationUnit(TreeScanner.java:144)                                                                                            
   at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:605)                                                                      
   at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:146)                                                                      
   at com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:591)                                                                                             
   at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)                                                                                                     
   at com.google.errorprone.scanner.Scanner.scan(Scanner.java:64)                                                                                                           
   at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:41)                                                                
   at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:145)                                                                                        
   at com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:120)                                                                                        
   at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1425)                                                                                                    
   at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1374)                                                                                                    
   at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)                                                                                                  
   at com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:100)                                                                                         
   at com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:142)                                                                                        
   at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:96)                                                                                                   
   at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:90)                                                                                                     
   at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:137)                                                                                     
   at com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:108)                                                                                     
   at com.google.errorprone.ErrorProneCompiler.run(ErrorProneCompiler.java:118)                                                                                             
   at com.google.errorprone.ErrorProneCompiler.compile(ErrorProneCompiler.java:65)                                                                                          
   at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne$CompilerInvoker.compile(JavacCompilerWithErrorProne.java:219)                               
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)                                                                                                           
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)                                                                                         
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)                                                                                 
   at java.lang.reflect.Method.invoke(Method.java:498)                                                                                                                      
   at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile(JavacCompilerWithErrorProne.java:91)                                         
   at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:825)                                                                          
   at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:129)                                                                                          
   at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)                                                                     
   at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)                                                                                       
   at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)                                                                                       
   at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)                                                                                       
   at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)                                                              
   at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)                                                               
   at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)                                                 
   at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)                                                                               
   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)                                                                                                        
   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)                                                                                                        
   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)                                                                                                          
   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)                                                                                                              
   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)                                                                                                               
   at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)                                                                                                                 
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)                                                                                                           
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)                                                                                         
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)                                                                                 
   at java.lang.reflect.Method.invoke(Method.java:498)                                                                                                                      
   at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)                                                                                   
   at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)                                                                                           
   at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)                                                                                 
   at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)

opened by davidmontoyago 20

Upgrade javac to JDK10 to support classfile version 54
When running error-prone with JDK 10-ea+35 we get the following compilation warnings:

[javac] warning: /modules/java.base/java/lang/Deprecated.class: major version 54 is newer than 53, the highest major version supported by this compiler. [javac] It is recommended that the compiler be upgraded.

for each class of the JDK. This is due to JDK-8188870: Bump classfile version number to 54.

With the new release cycle, the compiler will have to be updated every 6 months to support the new classfile version.

Maybe you could directly switch to JDK11 as classfile version 55 is coming soon, see JDK-8191913: Bump classfile version number to 55.
opened by don-vip 19
Calling Map/Collection methods with arguments that are not compatible with type parameters
Original issue created by [email protected] on 2013-03-05 at 03:23 PM

There are some methods on Map<K,V> or Collection<V> that accept Object because of compatibility reasons, while in fact they should accept <V>. We can check that arguments passed to those methods are compatible with V.

Example: Map<MyProto, Integer> map = ...; MyProto.Builder proto = MyProto.newBuilder()...; if (map.get(proto)) { ... };

Following checks can be introduced for all "Map<K,V> map" and "T arg" variables:

map.containsKey(arg) --> check that either "T extends K" or "T super K"

map.containsValue(arg) --> check that either "T extends V" or "T super V"

map.get(arg) --> check that either "T extends K" or "T super K"

map.remove(arg) --> check that either "T extends K" or "T super K"

Following checks can be introduced for all "Collection<V> coll" and "T arg" variables:

coll.contains(arg) --> check that either "T extends V" or "T super V"

coll.remove(arg) --> check that either "T extends V" or "T super V"

Same for List.indexOf, List.lastIndexOf.
Priority-High Type-NewCheck migrated Status-Accepted
opened by cushon 19
error_prone_core 2.0.6 adds Objects.requireNonNull() to source (which can crash Android)
I've been using the error-prone compiler for my Android application. java.util.Objects was only added recently to Android (API 19). The most recent version of error_prone_core (2.0.6) can add Objects.requireNonNull() to the source, which causes the Android app to crash if run on an older device.

I haven't been able to track down exactly how this happens; I'm not super familiar with error-prone's internals.

I've been using error-prone via the gradle-errorprone-plugin for Android builds. By default it pulls in the latest error_prone_core for use. As a workaround you can force it to use 2.0.5.

As an aside, the stack traces that result are quite mystifying since the source will contain no references to java.util.Objects. For example:

Fatal Exception: java.lang.NoClassDefFoundError: java.util.Objects at com.trello.syncadapter.StarredBoardsSync.execute(StarredBoardsSync.java:66) at com.trello.syncadapter.StarredBoardsSync.performSync(StarredBoardsSync.java:58) at com.trello.syncadapter.TSyncAdapter.onPerformSync(TSyncAdapter.java:49) at android.content.AbstractThreadedSyncAdapter$SyncThread.run(AbstractThreadedSyncAdapter.java:254)

...Where StarredBoardsSync didn't even import java.util.Objects in the original source.
opened by dlew 17
Checks on exception handling code
In our recent research paper with the title "Simple Testing Can Prevent Most Critical Failures", we found that a large number of the most deadly failures in production distributed systems are the result of trivial mistakes in exception handling code. Exception handling code is particularly critical to distributed systems as they're often the last line of defence. We observed three simple, yet deadly, bug patterns:

"TODO"/"FIXME" in the catch block

Empty catch block

Abort in exception over-catch

We implemented a simple checker called Aspirator to detect these three types of mistakes, and it found and fixed hundreds of bugs from Hadoop, HBase, Spark, etc. HBase developers asked us to implement these checks into error-prone, therefore I'm providing these three checks in this pull request.
Type-NewCheck cla: yes
opened by diy1 17
Fix Finalize bugpattern to match protected finalize()

Object#finalize() is protected, but the Finalize bugpattern would only find overridden PUBLIC finalizers. Fix it to look for protected methods too. The example finalizer in the Object#finalize() javadocs is protected, previously it would not be matched.

https://docs.oracle.com/javase/9/docs/api/java/lang/Object.html#finalize--

opened by rmuir 0
StatementSwitchToExpressionSwitch: only trigger on compatible target versions

This change introduces a SourceVersion utility class, analogous to the existing RuntimeVersion class. The new class tells whether selected language features are available for the source version used by the compiler.

The new utility class is used to make sure that StatementSwitchToExpressionSwitch flags statement switches only if the source version supports expression switches, irrespective of whether the current runtime supports such switch types. Concretely this makes the check compatible with projects that target JDK 11, yet support building with JDK 17.

opened by Stephan202 3

[2.17.0] GuardedBy on lambda

The constructor assigns a Consumer to which is invoked under a lock. However the checker now fails by assuming it was invoked in the constructor.

final Consumer<Node<K, V>> accessPolicy;
...
accessPolicy = (evicts() || expiresAfterAccess()) ? this::onAccess : e -> {};
...
/** Drains the read buffer. */
@GuardedBy("evictionLock")
void drainReadBuffer() {
  if (!skipReadBuffer()) {
    readBuffer.drainTo(accessPolicy);
  }
}

/Users/ben/projects/caffeine/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java:270: error: [GuardedBy] This access should be guarded by 'this.evictionLock', which is not currently held
    accessPolicy = (evicts() || expiresAfterAccess()) ? this::onAccess : e -> {};
                                                        ^
    (see https://errorprone.info/bugpattern/GuardedBy)
1 error

opened by ben-manes 1

An unhandled exception was thrown by the Error Prone static analysis plugin - UnusedMethod / SameNameButDifferent

[ERROR]      error-prone version: 2.15.0
[ERROR]      BugPattern: UnusedMethod
[ERROR]      Stack Trace:
[ERROR]      java.lang.IndexOutOfBoundsException: Range [4068, 3949) out of bounds for length 4074
[ERROR]         at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
[ERROR]         at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Preconditions.java:76)
[ERROR]         at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Preconditions.java:313)
[ERROR]         at java.base/java.util.Objects.checkFromToIndex(Objects.java:385)
[ERROR]         at java.base/java.nio.HeapCharBuffer.subSequence(HeapCharBuffer.java:664)
[ERROR]         at java.base/java.nio.HeapCharBuffer.subSequence(HeapCharBuffer.java:44)
[ERROR]         at com.google.errorprone.VisitorState.getOffsetTokens(VisitorState.java:595)
[ERROR]         at com.google.errorprone.fixes.SuggestedFixes.replaceIncludingComments(SuggestedFixes.java:1667)
[ERROR]         at com.google.errorprone.bugpatterns.UnusedMethod.fixNonConstructors(UnusedMethod.java:352)
[ERROR]         at com.google.errorprone.bugpatterns.UnusedMethod.matchCompilationUnit(UnusedMethod.java:326)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:449)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:555)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:150)
[ERROR]         at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:614)
[ERROR]         at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:60)
[ERROR]         at com.google.errorprone.scanner.Scanner.scan(Scanner.java:58)
[ERROR]         at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43)
[ERROR]         at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:152)
[ERROR]         at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
[ERROR]         at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1394)
[ERROR]         at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1341)
[ERROR]         at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:933)
[ERROR]         at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
[ERROR]         at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.invocationHelper(JavacTaskImpl.java:152)
[ERROR]         at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
[ERROR]         at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
[ERROR]         at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
[ERROR]         at org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:174)
[ERROR]         at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1129)
[ERROR]         at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:188)
[ERROR]         at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
[ERROR]         at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
[ERROR]         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
[ERROR]         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
[ERROR]         at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
[ERROR]         at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
[ERROR]         at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
[ERROR]         at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
[ERROR]         at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
[ERROR]         at org.apache.maven.cli.MavenCli.execute(MavenCli.java:972)
[ERROR]         at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:293)
[ERROR]         at org.apache.maven.cli.MavenCli.main(MavenCli.java:196)
[ERROR]         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR]         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[ERROR]         at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR]         at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[ERROR]         at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
[ERROR]         at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
[ERROR]         at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
[ERROR]         at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)

lombok

opened by Pavan47Rao 8

Bump snakeyaml from 1.30 to 1.32 in /docgen
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR

@dependabot recreate will recreate this PR, overwriting any edits that have been made to it

@dependabot merge will merge this PR after your CI passes on it

@dependabot squash and merge will squash and merge this PR after your CI passes on it

@dependabot cancel merge will cancel a previously requested merge and block automerging

@dependabot reopen will reopen this PR if it is closed

@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)

@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)

@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

dependencies
opened by dependabot[bot] 0

Releases(v2.17.0)

v2.17.0(Dec 30, 2022)
New Checkers:

AvoidObjectArrays

Finalize

IgnoredPureGetter

ImpossibleNullComparison

MathAbsoluteNegative

NewFileSystem

StatementSwitchToExpressionSwitch

UnqualifiedYield

Fixed issues: #2321, #3144, #3297, #3428, #3437, #3462, #3482, #3494

Full Changelog: https://github.com/google/error-prone/compare/v2.16...v2.17.0
Source code(tar.gz)
Source code(zip)
v2.16(Oct 11, 2022)
New Checkers:

ASTHelpersSuggestions

CanIgnoreReturnValueSuggester

LenientFormatStringValidation

UnnecessarilyUsedValue

Fixed issues: #3092, #3220, #3225, #3267, #3441

Full Changelog: https://github.com/google/error-prone/compare/v2.15.0...v2.16
Source code(tar.gz)
Source code(zip)
v2.15.0(Aug 3, 2022)
New Checkers:

BuilderReturnThis

CanIgnoreReturnValueSuggester

CannotMockFinalClass

CannotMockFinalMethod

DirectInvocationOnMock

ExtendsObject

MockNotUsedInProduction

NoCanIgnoreReturnValueOnClasses

NullArgumentForNonNullParameter

SelfAlwaysReturnsThis

UnsafeWildcard

UnusedTypeParameter

Fixed issues: #1562, #3236, #3245, #3321

Full Changelog: https://github.com/google/error-prone/compare/v2.14.0...v2.15.0
Source code(tar.gz)
Source code(zip)
v2.14.0(May 24, 2022)
New checkers:

BanJNDI

EmptyTopLevelDeclaration

ErroneousBitwiseExpression

FuzzyEqualsShouldNotBeUsedInEqualsMethod

Interruption

NullableOnContainingClass

Fixed issues: #3110, #3193

Full Changelog: https://github.com/google/error-prone/compare/v2.13.1...v2.14.0
Source code(tar.gz)
Source code(zip)
v2.13.1(Apr 15, 2022)
What's Changed

Fix a crash in UnnecessaryBoxedVariable in https://github.com/google/error-prone/pull/3118

Include the unicode character in the diagnostic message in https://github.com/google/error-prone/pull/3119

Full Changelog: https://github.com/google/error-prone/compare/v2.13.0...v2.13.1
Source code(tar.gz)
Source code(zip)
v2.13.0(Apr 14, 2022)
Handle all annotations with the simple name Generated in -XepDisableWarningsInGeneratedCode (#3094)

Reconcile BugChecker#isSuppressed with suppression handling in ErrorProneScanner (#3094)

Fix a bug in enclosingPackage (8fa64d48f3a1d8df852ed2546ba02b0e2b7585af)

Improve performance of fix application (186334bcc45d9c275037cdcce3eb509ae8b7ff50)

Implicitly treat @AutoBuilder setter methods as @CanIgnoreReturnValue.

Remove some obsolete checks (PublicConstructorForAbstractClass, HashCodeToString)

Release Diff: v2.12.1...v2.13.0.
Source code(tar.gz)
Source code(zip)
v2.12.1(Apr 5, 2022)
This release adds an infrastructure optimization to AppliedFix source code processing.

Release Diff: v2.12.0...v2.12.1.

Source code(tar.gz)
Source code(zip)
v2.12.0(Apr 5, 2022)
New checks

BoxedPrimitiveEquality

DoubleBraceInitialization

IgnoredPureGetter

LockOnBoxedPrimitive

IncorrectMainMethod

LongDoubleConversion

RobolectricShadowDirectlyOn

StaticAssignmentOfThrowable

UnnecessaryLongToIntConversion

Varifier

Fixed issues: #58, #65, #1327, #1654, #2858, #2867, #2916, #2951, #2954, #3006, #3008

Full Changelog: https://github.com/google/error-prone/compare/v2.11.0...v2.12.0
Source code(tar.gz)
Source code(zip)
v2.11.0(Jan 25, 2022)
Error Prone now requires JDK 11 or newer (https://github.com/google/error-prone/issues/2730).

New checks

AutoValueBuilderDefaultsInConstructor

FloggerLogString

UnicodeDirectionalityCharacters

UnicodeInCode

AlreadyChecked

BugPatternNaming

MissingImplementsComparable

NegativeCharLiteral

PreferredInterfaceType

StronglyTypeByteString

UsingJsr305CheckReturnValue

Fixed issues: #2641, #2705, #2776, #2798, #2799, #2819, #2820, #2831, #2833, #2834, #2835, #2861, #2873, #2889, #2892, #2901

Full Changelog: https://github.com/google/error-prone/compare/v2.10.0...v2.11.0
Source code(tar.gz)
Source code(zip)
v2.10.0(Nov 4, 2021)
New checks

AlwaysThrows

StackTraceElementGetClass

BareDotMetacharacter

DistinctVarargsChecker

MalformedInlineTag

MemoizeConstantVisitorStateLookups

UnicodeEscape

FieldMissingNullable

Java8ApiChecker

ParameterMissingNullable

TooManyParameters

TryWithResourcesVariable

UnnecessaryFinal

VoidMissingNullable

Fixed issues: #2616, #2629

Full Changelog: https://github.com/google/error-prone/compare/v2.9.0...v2.10.0
Source code(tar.gz)
Source code(zip)
v2.9.0(Aug 20, 2021)
Release Error Prone 2.9.0

New checks:

DeprecatedVariable

PublicApiNamedStreamShouldReturnStream

Fixes #2124, #2371, #2393, #2470
Source code(tar.gz)
Source code(zip)
v2.8.1(Aug 3, 2021)

This release adds a new check (LoopOverCharArray), and a handful of other small improvements (https://github.com/google/error-prone/compare/v2.8.0...v2.8.1).
Source code(tar.gz)
Source code(zip)
v2.8.0(Jul 23, 2021)
New Checks:

JUnit4TestsNotRunWithinEnclosed

OptionalOfRedundantMethod

UnnecessaryAssignment

UnrecognisedJavadocTag

AnnotationMirrorToString

AnnotationValueToString

EqualsMissingNullable

ReturnMissingNullable

Fixes #1652, #2122, #2122, #2366, #2404, #2411
Source code(tar.gz)
Source code(zip)
v2.7.1(May 14, 2021)

Everything in Error Prone 2.7.0, plus an additional fix for JDK 17.
Source code(tar.gz)
Source code(zip)
v2.7.0(May 14, 2021)
Changes

Initial support for running on JDK 17 EA builds. Supports for Java 17 languages features is incomplete; bug reports for issues with Java 17 are welcome.

@InlineMe is a deprecation mechanism that allows automated tools to cleanup existing callers: http://errorprone.info/docs/inlineme

New checks:

EqualsNull

MissingBraces

NullablePrimitiveArray

OptionalMapUnusedValue

TestParametersNotInitialized

Closed issues: #2257, #2260, #2282, #2301, #2322, #2323, #2324
Source code(tar.gz)
Source code(zip)
v2.6.0(Apr 1, 2021)
Checkers Added:

CharacterGetNumericValue

ErroneousThreadPoolConstructorChecker

FloggerArgumentToString

FloggerStringConcatenation

ProtoBuilderReturnValueIgnored

RethrowReflectiveOperationExceptionAsLinkageError

SystemOut

UnnecessaryAnonymousClass

Issues Closed:

RFE: configurable DoNotCall/RestrictedApi/JdkObsolete/DefaultCharset/JavaTimeDefaultTimeZone check (#1211)

Add SystemOut checker (#1534)

WellKnownMutability: add java.awt.Color (#1682)

IdentityHashMapUsage warnings differ from its documentation (#2095)

UnusedMethod no longer works (#2215)

Document naming convention for UnusedMethod (#2223)

Source code(tar.gz)
Source code(zip)
v2.5.1(Jan 15, 2021)
Changes

NoSuchMethodError: 'com.sun.tools.javac.util.List com.sun.tools.javac.code.Symbol$TypeSymbol.getEnclosedElements

Fixed NoSuchMethodError crash in HidingField (#2092)

Fixed NoSuchElementException crash in RestrictedApiChecker (#2099)

False positive in DifferentNameButSame (#2094)

False positive in UnnecessaryOptionalGet (#2101)

False positive in UnnecessaryMethodReference (#2102)

Fixed a regression in JDK 16-EA support (#2105)

Source code(tar.gz)
Source code(zip)
v2.5.0(Jan 12, 2021)
New checks:

BanSerializableRead

CatchingUnchecked

ComputeIfAbsentAmbiguousReference

DangerousLiteralNull

DateChecker

DifferentNameButSame

DoNotCallSuggester

DoNotClaimAnnotations

DoNotMockAutoValue

FloggerFormatString

FloggerLogVarargs

FloggerLogWithCause

FloggerMessageFormat

FloggerPassedAround

FloggerRedundantIsEnabled

FloggerRequiredModifiers

FloggerSplitLogStatement

FloggerWithCause

FloggerWithoutCause

HashCodeToString

IdentityHashMapUsage

ImmutableMemberCollection

ImmutableSetForContains

InitializeInline

InvalidThrowsLink

IsInstanceIncompatibleType

JavaUtilDate

JodaConstructors

JodaDateTimeConstants

LongFloatConversion

MemberName

MisplacedScopeAnnotations

ObjectEqualsForPrimitives

OptionalMapUnusedValue

ReturnsNullCollection

StaticMockMember

StreamToIterable

SymbolToString

TypeToString

UnnecessarilyVisible

UnnecessaryMethodReference

UnnecessaryOptionalGet

UnsafeLocaleUsage

UseEnumSwitch

UseTimeInScope

WrongOneof

ZoneIdOfZ

Fixed issues: #1044 #1177 #1275 #1322 #1326 #1503 #1529 #1563 #1645 #1650 #1652 #1653 #1655 #1665 #1670 #1672 #1694 #1699 #1705 #1767 #1788 #1809 #1849 #1873 #1916 #1981 #1982 #1986 #1987 #2009 #2026 #2029 #2059 #2064
Source code(tar.gz)
Source code(zip)
v2.4.0(May 29, 2020)
Support for latest JDK versions: Error Prone is now compatible with JDK 8 through JDK 14, as well as early access builds of JDK 15.

New checks:

AutoValueSubclassLeaked

CacheLoaderNull

CheckedExceptionNotThrown

CollectionUndefinedEquality

ConstantPatternCompile

DefaultPackage

EmptyCatch

FieldCanBeStatic

ForEachIterable

FromTemporalAccessor

IdentityHashMapBoxing

IgnoredPureGetter

InlineFormatString

InvalidLink

LockOnBoxedPrimitive

LossyPrimitiveCompare

MisusedDayOfYear

MutablePublicArray

NonCanonicalType

NullOptional

ProtectedMembersInFinalClass

PublicConstructorForAbstractClass

RedundantCondition

StaticAssignmentInConstructor

StronglyTypeTime

SuppressWarningsWithoutExplanation

TruthGetOrDefault

UnnecessarilyFullyQualified

UrlInSee

Fixed issues: #1070, #1106, #1107, #1110, #1111, #1187, #1208, #1239, #1265, #1428, #1432, #1433, #1439, #1444, #1447, #1449, #1451, #1454, #1455, #1458, #1462, #1473, #1491, #1531, #1558, #1565, #1570, #1573, #1586, #1587, #1590, #1591, #1602, #1606, #1609, #1624, #776, #785, #930
Source code(tar.gz)
Source code(zip)
v2.3.4(Dec 2, 2019)
Performance Improvements: 40% speedup when run against Google's codebase with errors enabled.

New Checks:

AlmostJavadoc

BoxedPrimitiveEquality

ChainedAssertionLosesContext

CheckNotNullMultipleTimes

DescribeMatch

DoNotMockChecker and @DoNotMock

DurationTemporalUnit

EmptyBlockTag

ExtendsAutoValue

FieldCanBeLocal

ImplementAssertionWithChaining

Incomparable

InstantTemporalUnit

InterruptedExceptionSwallowed

InvalidJavaTimeConstant

JavaLocalDateTimeGetNano

JavaLocalTimeGetNano

JavaPeriodGetDays

LiteEnumValueOf

LiteProtoToString

LocalDateTemporalAmount

ModifySourceCollectionInStream

ParametersButNotParameterized

PreferJavaTimeOverload

PrimitiveAtomicReference

SameNameButDifferent

TheoryButNoTheories

ThrowSpecificExceptions

TransientMisuse

UnnecessaryAnonymousClass

UnnecessaryBoxedAssignment

UnnecessaryBoxedVariable

UnnecessaryLambda

UnnecessaryMethodInvocationMatcher

WithSignatureDiscouraged

XorPower

Removed, moved, or disabled:

Moved Mockito checks into Mockito Error Prone Subproject.

Merged PreconditionsCheckNotNull and PreconditionsCheckNotNullPrimitive into UnnecessaryCheckNotNull.

Deleted DeprecatedThreadMethods in favour of general-purpose deprecation warnings.

Disabled ProvidesFixChecker as it causes too much noise.

Fixed issues: #1106, #1225, #1231, #1234, #1238, #1241, #1246, #1252, #1259, #1260, #1271, #1274, #1287, #1308, #1316, #1329, #1373, #1391, #1408
Source code(tar.gz)
Source code(zip)
v2.3.3(Mar 20, 2019)
New checks:

AssignmentToMock: Fields annotated with @Mock should not be manually assigned to.

AutoValueImmutableFields: AutoValue recommends using immutable collections

CompareToZero: The result of #compareTo or #compare should only be compared to 0. It is an implementation detail whether a given type returns strictly the values {-1, 0, +1} or others.

DeduplicateConstants: This expression was previously declared as a constant; consider replacing this occurrence.

DiscardedPostfixExpression: The result of this unary operation on a lambda parameter is discarded

DuplicateMapKeys: Map#ofEntries will throw an IllegalArgumentException if there are any duplicate keys

EscapedEntity: HTML entities in @code/@literal tags will appear literally in the rendered javadoc.

InheritDoc: Invalid use of @inheritDoc.

InterfaceWithOnlyStatics: This interface only contains static fields and methods; consider making it a final class instead to prevent subclassing.

InvalidBlockTag: This tag is invalid.

InvalidInlineTag: This tag is invalid.

MissingSummary: A summary line is required on public/protected Javadocs.

MixedDescriptors: The field number passed into #getFieldByNumber belongs to a different proto to the Descriptor.

MixedMutabilityReturnType: This method returns both mutable and immutable collections or maps from different paths. This may be confusing for users of the method.

MockitoInternalUsage: org.mockito.internal.* is a private API and should not be used by clients

OptionalMapToOptional: Mapping to another Optional will yield a nested Optional. Did you mean flatMap?

OutlineNone: Setting CSS outline style to none or 0 (while not otherwise providing visual focus indicators) is inaccessible for users navigating a web page without a mouse.

PreconditionsCheckNotNullRepeated: Including the first argument of checkNotNull in the failure message is not useful, as it will always be null.

RedundantOverride: This override is redundant, and can be removed.

RefersToDaggerCodegen: Don't refer to Dagger's internal or generated code

RxReturnValueIgnored: Returned Rx objects must be checked. Ignoring a returned Rx value means it is never scheduled for execution

TreeToString: Tree#toString shouldn't be used for Trees deriving from the code being compiled, as it discards whitespace and comments.

TypeEquals: com.sun.tools.javac.code.Type doesn't override Object.equals and instances are not interned by javac, so testing types for equality should be done with Types#isSameType instead

UnescapedEntity: Javadoc is interpreted as HTML, so HTML entities such as &, <, > must be escaped.

UnusedMethod: Unused.

UnusedNestedClass: This nested class is unused, and can be removed.

UnusedVariable: Unused.

New date and time related checks:

JavaDurationGetSecondsGetNano: duration.getNano() only accesses the underlying nanosecond adjustment from the whole second.

JavaDurationWithNanos: Use of java.time.Duration.withNanos(int) is not allowed.

JavaDurationWithSeconds: Use of java.time.Duration.withSeconds(long) is not allowed.

JavaInstantGetSecondsGetNano: instant.getNano() only accesses the underlying nanosecond adjustment from the whole second.

JavaTimeDefaultTimeZone: java.time APIs that silently use the default system time-zone are not allowed.

JodaDurationConstructor: Use of new Duration(long) is not allowed. Please use Duration.millis(long) instead.

JodaDurationWithMillis: Use of duration.withMillis(long) is not allowed. Please use Duration.millis(long) instead.

JodaInstantWithMillis: Use of instant.withMillis(long) is not allowed. Please use new Instant(long) instead.

JodaNewPeriod: This may have surprising semantics, e.g. new Period(LocalDate.parse("1970-01-01"), LocalDate.parse("1970-02-02")).getDays() == 1, not 32.

JodaPlusMinusLong: Use of JodaTime's type.plus(long) or type.minus(long) is not allowed (where = {Duration,Instant,DateTime,DateMidnight}). Please use type.plus(Duration.millis(long)) or type.minus(Duration.millis(long)) instead.

JodaTimeConverterManager: Joda-Time's ConverterManager makes the semantics of DateTime/Instant/etc construction subject to global static state. If you need to define your own converters, use a helper.

JodaToSelf: Use of Joda-Time's DateTime.toDateTime(), Duration.toDuration(), Instant.toInstant(), Interval.toInterval(), and Period.toPeriod() are not allowed.

JodaWithDurationAddedLong: Use of JodaTime's type.withDurationAdded(long, int) (where = {Duration,Instant,DateTime}). Please use type.withDurationAdded(Duration.millis(long), int) instead.

TemporalAccessorGetChronoField: TemporalAccessor.get() only works for certain values of ChronoField.

TimeUnitConversionChecker: This TimeUnit conversion looks buggy: converting from a smaller unit to a larger unit (and passing a constant), converting to/from the same TimeUnit, or converting TimeUnits where the result is statically known to be 0 or 1 are all buggy patterns.

DurationFrom: Duration.from(Duration) returns itself; from(Period) throws a runtime exception.

DurationGetTemporalUnit: Duration.get() only works with SECONDS or NANOS.

DurationToLongTimeUnit: Unit mismatch when decomposing a Duration or Instant to call a <long, TimeUnit> API

InvalidZoneId: Invalid zone identifier. ZoneId.of(String) will throw exception at runtime.

PeriodFrom: Period.from(Period) returns itself; from(Duration) throws a runtime exception.

PeriodGetTemporalUnit: Period.get() only works with YEARS, MONTHS, or DAYS.

PeriodTimeMath: When adding or subtracting from a Period, Duration is incompatible.

ProtoDurationGetSecondsGetNano: getNanos() only accesses the underlying nanosecond-adjustment of the duration.

ProtoTimestampGetSecondsGetNano: getNanos() only accesses the underlying nanosecond-adjustment of the instant.

ProtoTruthMixedDescriptors: The arguments passed to ignoringFields are inconsistent with the proto which is the subject of the assertion.

TimeUnitMismatch: An value that appears to be represented in one unit is used where another appears to be required (e.g., seconds where nanos are needed)

API changes:

@BugPattern.category is no longer supported; prefer @BugPattern.tags as a means to apply general tags to checks.

Other changes:

Suppress checks thoroughly when -XepDisableWarningsInGeneratedCode is passed.

Make UnusedVariable match unused assignments too.

Handle static methods in InfiniteRecursion

Add common java.time types to ReturnValueIgnored.

ModifiedButNotUsed: match orphaned chains of proto/collection builders

Improve NarrowingCompoundAssignment's fixes for ternary

Allow suppressing AutoValueImmutableFields at the field level rather than just for the entire class.

Handle DateTimeFormat and DateTimeFormatter in MisusedWeekYear

Allow suppressing UnusedException on the CatchTree's VariableTree.

require constructors invoking a @MustBeClosed constructor to be marked @MustBeClosed too

support Android's @RecentlyXxx annotations and @CheckForNull in nullness analysis.

Match methods instead of classes in AutoValueImmutableFields checker.

Add a bunch more mutable types to the AutoValueImmutableFields matcher.

Fix bug in WellKnownMutability incorrectly identifying proto1 as proto2.

Don't flag java.lang.Object in EqualsHashCode check

Improve AutoValueFinalMethods check by adding more specific diagnostic at first matched method.

The NoAllocationChecker now requires the @NoAllocation annotation to be propagated to all overrides of a method that has the annotation, to reflect the contractual nature of the annotation.

Catch unescaped entities in Javadocs.

Source code(tar.gz)
Source code(zip)
v2.3.2(Oct 11, 2018)
Highlights:

Opt-in check AndroidJdkLibsChecker enforces which JDK libraries can be used in Android applications, and, with the -XepOpt:Android:Java8Libs flag, can allow select Java 8 library support via https://developer.android.com/studio/write/java8-support. Look out for this in bazel.build after the next release.

Immutable{Annotation,Enum}Checker now requires the Error Prone @Immutable annotation, not the JSR-305 @Immutable annotation

New Checks:

Javadoc Checkers: InvalidParam, InvalidTag, InvalidThrows, ReturnFromVoid

API Checkers: AndroidJdkLibsChecker, Java7ApiChecker, ApiDiffChecker

AnnotateFormatMethod

AnnotationPosition

ArrayAsKeyOfSetOrMap

AutoValueFinalMethods

BadInstanceof

BigDecimalEquals

ClassNamedLikeTypeParameter

CloseableProvides

ComparingThisWithNull

DeprecatedThreadMethods

EqualsBrokenForNull

EqualsGetClass

EqualsUnsafeCast

EqualsUsingHashCode

EqualsWrongThing

ExpectedExceptionRefactoring

ExtendingJUnitAssert

FloatingPointAssertionWithinEpsilon

ImmutableRefactoring

InconsistentHashCode

InjectOnMemberAndConstructor

LockNotBeforeTry

MathAbsoluteRandom

MathRoundIntLong

MissingTestCall

ModifiedButNotUsed

NoFunctionalReturnType

NullableDereference

ObjectsHashCodePrimitive

ProtoRedundantSet

ProtosAsKeyOfSetOrMap

SubstringOfZero

SwigMemoryLeak

SystemExitOutsideMain

TestExceptionRefactoring

ThreadPriorityCheck

ToStringReturnsNull

TruthAssertExpected

TypeNameShadowing

UndefinedEquals

UnnecessaryParentheses

UnsafeReflectiveConstructionCast

UnusedException

VariableNameSameAsType

Fixes Issues:

#1008, #1028, #1038, #1040, #1077, #1078, #1079, #1083, #1084, #1085, #1095, #1096, #1101, #1125, #1129, #1130, #35, #607, #783, #849, #926
Source code(tar.gz)
Source code(zip)
v2.3.1(Apr 20, 2018)
New checks:

[AssertThrowsMultipleStatements] The lambda passed to assertThows should contain exactly one statement

[FieldCanBeFinal] This field is only assigned during initialization; consider making it final

[ObjectToString] Calling toString on Objects that don't override toString() doesn't provide useful information

Other changes:

Make ParcelableCreator check an ERROR

OrphanedFormatString detects string literals correctly passed to @FormatMethod methods

Fixes issues: #996, #999, #1001, #1004
Source code(tar.gz)
Source code(zip)
v2.3.0(Apr 19, 2018)
New checks:

[ParcelableCreator]: Detects classes which implement Parcelable but don't have CREATOR

[InconsistentCapitalization] It is confusing to have a field and a parameter under the same scope that differ only in capitalization

[TruthIncompatibleType] Argument is not compatible with the subject's type

[ByteBufferBackingArray] ByteBuffer.array() shouldn't be called unless ByteBuffer.arrayOffset() is used or if the ByteBuffer was initialized using ByteBuffer.wrap() or ByteBuffer.allocate()

[OrphanedFormatString] String literal contains format specifiers, but is not passed to a format method

[ScopeOnModule] Scopes on modules have no function and will soon be an error

[CatchAndPrintStackTrace] Logging or rethrowing exceptions should usually be preferred to catching and calling printStackTrace

[VarTypeName] var should not be used as a type name

Other changes:

Remove MoreAsserts from TryFailThrowable

Add java.util.Arrays to ReturnValueIgnored check

Improve BugCheckerRefactoringTestHelper usability

Extend SizeGreaterThanOrEqualsZero check to check proto repeated fields

Disallow method references to @DoNotCall methods

Disallow Error Prone BugPattern names that includes spaces.

Add an optional suffix comment to SuggestedFixes.addSuppressWarnings

Allow @CompatibleWith to be used on varargs parameters.

Make StreamResourceLeak a warning

Recognize null test methods in java.util.Objects in nullness analysis

Detect more cases of nested and ignored futures.

Make the failure message in DiagnosticTestHelper easier to read.

Enable QualifierOrScopeOnInjectMethod as a WARNING

Consolidate NamedParameters and ParameterName

Fixes issues: #789, #893, #897, #899, #899, #904, #914, #921, #931, #942, #945, #954, #993
Source code(tar.gz)
Source code(zip)
v2.2.0(Jan 8, 2018)
New errors:

[ComparableType] A new check for detecting incompatibility of types between the type of a class implementing Comparable<T> and T.

[ConditionalExpressionNumericPromotion] A conditional expression with numeric second and third operands of differing types may give surprising results.

New warnings:

[CatchFail] detects tests that ignore exceptions and then call fail()

[ModifyCollectionInEnhancedForLoop] detects collections modified within loops.

[ThreadLocalUsage] ThreadLocals should be stored in static fields.

New optional checks:

[StringSplit] detects String.split(String), which has surprising behaviour.

[StringSplitter] refactors uses of String.split to Splitter.

[TypeParameterNaming] enforces that type parameters are named according to the google style guide.

[RandomCast] casting a random number in the range [0.0, 1.0) to an integer or long always results in 0.

Changes to existing checks

ArrayEquals now detects misuse of android.support.v4.util.ObjectsCompat#equals.

EqualsIncompatibleType now detects misuse of android.support.v4.util.ObjectsCompat#equals.

SizeGreaterThanOrEqualsZero now detects misuse of common Android-specific collections.

FilesLinesLeak was renamed to StreamResourceLeak, and now checks other methods in Files.

FunctionalInterfaceClash is no longer enabled by default.

JUnit4{SetUp,TearDown}NotRun will find methods that look like setup or teardown methods, but have a @Before or @After annotation that are not org.junit.Before or org.junit.After.

SimpleDateFormatConstant now handles all DateFormats, and is renamed to DateFormatConstant

Disable RestrictToEnforcer by default (fixes #812).

EqualsIncompatibleType/PredicateIncompatibleType/CollectionIncompatible now explore type parameters to ensure their compatibility: Foo<A> is incompatible with Foo<B> if A and B are incompatible with each-other.

Other changes

Update to javac 9+181-r4173-1 (fixes #781 and #784).

Remove BugPattern.suppressibility and BugPattern.customSuppressionAnnotations: suppressionAnnotations should be used instead.

Source code(tar.gz)
Source code(zip)