Shortly describe your proposed changes:

• All the tests for Binomial Tree Node
• All the tests for insertions of BinomialHeap

Link any issues if they have led to changes in the request:

• None

Note the (sub-)exercises the tests are meant for:

• GAD 08 - Binomial Heap

The tests for deletions and exceptions follow shortly

Shortly describe your proposed changes:

• https://github.com/N0W0RK/TUM_GAD_Tests_SS21/pull/45#pullrequestreview-676780843

Link any issues if they have led to changes in the request:

• https://github.com/N0W0RK/TUM_GAD_Tests_SS21/issues/44

Note the (sub-)exercises the tests are meant for:

• GAD 06 - Verbessertes Sortieren

The idea is to build a helper class that eases the creation of large tests with simmilar inputs. This issue tries to resolve the codestyle limitations discussed in #47

Goals:

• [x] Test symlink copatibility across systems.
• [ ] Offload Test Inputs and Outputs into structured text (e.g. JSON, XML, etc.).
• [ ] Create a general tester class that can be used for every exercise.

Note that this should be merged after the GPL license has been accepted (issue #15, pull request #19)!

Changes introduced during this "clean-up" are:

• A rewritten README file with a improved structure, proper relative hyperlinks, a better description of the repository structure and simplified textual layout
• An updated CONTRIBUTING.md file that reflects changes in the README and minor grammar improvements
• Moving the pull request template from docs into .github (because it has actually nothing to do with the project's documentation, if we had one)
• Small extension to the issue template
• Removed the .project file which is only useful for the Eclipse IDE
• Edited the .gitignore file to include a bunch of other file types that should not find their way into this repository
• Renamed other files in the dedicated directories if they didn't meet the structure description
• Cleaned up the test environment of exercise 2 (a1de7b7d4f4dccde14c6402d7b3ecf89047c28af)
• Cleaned up the test environment of exercise 3 (1aeb2706f2cdbe3a869cdf3867820442582c09dd)

If anyone has something in mind, feel free to comment on those proposed changes here or on Zulip :)

Link any issues if they have led to changes in the request

Please describe the (sub-)exercises the tests are meant for

• GAD 6
• Tests for DualPivotFinder.

I had passed all tests on artemis and created some random cases with my implementation. I hope it works also fine with you. Make sure to run them on your computer before merging into main branch.

Shortly describe your proposed changes: Tests for BinomialHeap.java

Link any issues if they have led to changes in the request:

sorry for creating another pull request... one year into computer science and i still dont get git :/

Note the (sub-)exercises the tests are meant for:

• GAD 8 - Binomial Heap: BinomialHeap.java

Link any issues if they have led to changes in the request
https://github.com/N0W0RK/TUM_GAD_Tests_SS21/pull/28#discussion_r639720165

Please describe the (sub-)exercises the tests are meant for

• GAD 06 - Verbessertes Sortieren

Added tests for QuickSort using all the pivot options without any selection sort based optimisation

Would appreciate a review before I blindly merge it with main again

Except for the final sort

Shortly describe your proposed changes:

• None

Link any issues if they have led to changes in the request:

• None

Note the (sub-)exercises the tests are meant for:

• GAD 07 - RadixSort

Is your test request linked to a subexercise? Please describe: This is an issue with the dual MedianDistributed Pivot Tests

Describe the behaviour you want:

• Multiple possible pivots: When a value appears multiple times in the considered elements, the tests only allow for one of those elements to be returned as pivots.

  In this case for example:

  Considered Elements: [ -9, -28, 13, -28, -22]
  At indices           [  9,  14, 19,  24,  29]
  

  The pivots would be -28 and -9. The Test only accepts 24 as index for -28 but 14 would in my opinion also be correct.

• Undefined behaviour According to artemis, results for arrays smaller then 5 only have to make sense. This implies that the indices have to be inside the given range. The tests however only permit certain values for range sizes smaller then 5 and notr just any values inside the range.

Considering EiST with their exercise point reductions for bad code style... I would suggest to add a CI pipeline (e.g. Travis CI) to accomplish the following goals on our test suite(s):

• Prevent Java build errors
• Point out bad practices to avoid them later on
• Improve general coding style
• Encourage other students to adapt the idea of testing their own projects in this or similar way as well

After a quick search, there are some style guides around, e.g. this one from Google or this draft for OpenJDK (or this very old PDF document from Oracle?). From a quick point of overview, they seem to be quiet abstract but also consistent.

But that's not of particular interest now. The questions are: Do we need it at all? What tools should be used (if we agree on that)? I'm open for further discussion. :)

Link any issues if they have led to changes in the request

Please describe the (sub-)exercises the tests are meant for

• GAD 06 - Verbessertes Sortieren

Shortly describe your proposed changes:

Code cleanup of older tests, without functional changes

Link any issues if they have led to changes in the request:

#49

Note the (sub-)exercises the tests are meant for:

Any previous exercise(s), so everything below GAD 8.

Issue #38 has added a CI pipeline to check for Java style guide violations. However, the existing problems (look here) are not addressed yet. This issue aims to be a reference for everyone who wants to introduce fixes to the existing code base. Most of the problems may be fixed easily using an automatic linter, others may need manual edits.

I would also like to add a status badge on the README like the example below:

But actually, even though we have lots of style violations the badge says 'passing' (at least currently). As that's not accurate yet, I won't add it yet.

Code snippet for this particular badge:

[![Java Style Checker](https://github.com/N0W0RK/TUM_GAD_Tests_SS21/actions/workflows/checkstyle.yml/badge.svg)](https://github.com/N0W0RK/TUM_GAD_Tests_SS21/actions/workflows/checkstyle.yml)

For some users it might be obvious how to use our test suite, but others might have problems with it. For example, the Windows-specific setup description is just as short as:

This has to be executed in the command line, run as administrator:

$ mklink /J \path\to\src\tests \path\to\repository\tests

Besides the fact that on Windows there are no paths that start with a "drive-less" \ but C:\ or D:\ instead, we need a much better and possible longer description for this. Of course, this would also apply to the *nix/BSD/MacOS part, which is just a ln call without further explanation.

Parts of this issue may be tracked in certain Zulip threads as well.