Hi.

I've asked that people porting our mods please do not re-use the original project names, as it causes player confusion and muddies the conversation around the original mod. There's a longer version of the reasoning on my FAQ page here.

This is not the first time I've tried to reach out to port authors to ask this, as was the case with Halogen. That issue also contains some additional reasoning for the request, and the respective maintainers seemed to be happy to change the name.

Ultimately, it's your project, and what name you want to use it up to you -- I'm just asking that it isn't referred to as "Sodium", "Sodium for Forge", or any other variant of that.

Thanks in advance.

When using Pupil-Magnesium or Iris-Magnesium game will crash when loading into world. Even with/without Base Magnesium inside the mods folder.

Mods also contained in Mods folder: emotecraft-for-MC1.16.5-2.1-SNAPSHOT-build.11-forge Neat-Mod-1.16.5 jei-1.16.3-7.4.0.40 Hwyla-forge-1.10.11-B78_1.16.2

Crash Report txt: crash-2022-02-26_15.32.18-client.txt

I see you may be attempting a port of Iris.

Please read this section in full: https://github.com/IrisShaders/Iris#but-wheres-the-forge-version

How do you plan to address these issues? If you do not have a plan, then I ask that you do not port Iris because that will create a lot of problems for me and my support team in addition to damaging my mod's reputation.

You should see the corresponding version of that document for CaffeineMC as well: https://github.com/CaffeineMC/caffeine-meta/wiki/FAQ#where-are-the-forge-versions-of-your-mods

I know vsync caps fps to your monitors refresh rate, and I know the frame limit caps to the limit you set. However, when comparing performance it seems that the vsync and frame limit hurt performance.

If fps is always above 200 with vsync off and frame limit unlimited but you turn on vsync on a 144hz monitor it will go to 144 fps but half the time it will be between 100-144 fps. And the same for a 144 frame limit. So compared to the always above 200 on vsync off unlimited the performance is lesser.

Maybe something in the vsync and frame limit code could be improved to fixx this? I hope my explanation makes sense. Can anyone replicate this problem?

magnesium-1.4.1.1.jar

When running stop the server will not fully close when Magnesium is install instead it gets stuck (hangs) on saving chunks on whatever the last dimension to be saved is. This is a major issue as it prevents servers from automatically restarting after a crash or auto restarting as part of a normal process as if the server can't exit most scripts can't run a command to start the server. The only way to exit this hang is to press ctrl+c twice.

whenever I put a netherite sword in a workbench or check advancements the game crashes. In the case of the netherite sword crash it also makes the world I was playing on unusable.

Magnesium 1.2.2

We have a large server with Quark, Minecolies, Eidolon, Ice And Fire mods. And for some players the world is not rendered correctly, they can see blocks and dungeons under them! Sometimes they can't see anything at all. Other players are fine.

Here are the characteristics of a person with a problem, if that I do not have this problem, and it occurs in some people

Laptop CPU Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz 1.80 GHz RAM 8,00 ГБ System 64-x, cpu x64 Video; Intel UHD Graphics 620

Crash: https://paste.loliidc.cn/?51f3224e82133ad5#5eLmjQdvd2HASrSVQkMMDt9upSBuPF9cmYDhAyLUv7uP Full log: https://paste.loliidc.cn/?2fbaac37ebe048ad#Bniav2UjXGAqUvgyf5n8VfWAdM9jZMuwituW5y5hpKVB

https://media.discordapp.net/attachments/897871478542975057/904102705671323668/2021-10-30_23.17.03.png?width=1191&height=670

https://media.discordapp.net/attachments/897871478542975057/904102742862213200/2021-10-30_23.17.17.png?width=1191&height=670

https://media.discordapp.net/attachments/897871478542975057/904102764047638568/2021-10-30_23.17.49.png?width=1191&height=670

There is/used to be a crash with Magnesium/Sodium Reforged.

This was reported to this spoorn/sodium-forge here: https://github.com/spoorn/sodium-forge/issues/63 and fixed in that repository: https://github.com/spoorn/sodium-forge/commit/701eb80dd1e46708a91a52960fb549d76ba3e2cf

In this repository however, the fix is not applied: https://github.com/Someone-Else-Was-Taken/Periodic-Table-Reforged/blob/beaa6b747a0a846dfddf993395b17dc83139db9a/Legacy%20Sodium/src/main/java/me/jellysquid/mods/sodium/mixin/core/model/MixinBlockColors.java

For me it is unclear from what sources the Magnesium releases from on CurseForge are built. However, it seems like they trigger the same bug.

Exception message: java.lang.ArrayIndexOutOfBoundsException: 1024
Stacktrace:
	at it.unimi.dsi.fastutil.objects.Reference2ReferenceOpenHashMap.rehash(Reference2ReferenceOpenHashMap.java:908) ~[fastutil-8.2.1.jar:?] {re:classloading}
	at it.unimi.dsi.fastutil.objects.Reference2ReferenceOpenHashMap.insert(Reference2ReferenceOpenHashMap.java:273) ~[fastutil-8.2.1.jar:?] {re:classloading}
	at it.unimi.dsi.fastutil.objects.Reference2ReferenceOpenHashMap.put(Reference2ReferenceOpenHashMap.java:281) ~[fastutil-8.2.1.jar:?] {re:classloading}
	at net.minecraft.client.renderer.color.BlockColors.handler$baa000$preRegisterColor(BlockColors.java:532) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.renderer.color.BlockColors.func_186722_a(BlockColors.java) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:A,pl:runtimedistcleaner:A}

Full crashreport: crash-2021-11-05_11.52.37-fml.txt

current release is NOT compatible with https://www.curseforge.com/minecraft/mc-mods/lucent but prev release is lmao

by compatible I mean that the game starts. With the current release the game doesn't even start

This uses Architectury Loom to keep the codebase the same as the Fabric version, which allows for easy updating with upstream without a need to migrate mappings. The mod has also been renamed to Retina on the user side, and a fork of Oxygen with Iris support is included.

When using Create's ponder system, the client crashes due to a rendering issue with Magnesium. To replicate, simply install Magnesium v1.5, along with any version of Create, and use the ponder mechanic by holding down "W" when hovering over an appropriate Create item in inventory or JEI.

Error: [14:05:02] [Render thread/FATAL]: Mixin apply failed magnesium.mixins.json:core.pipeline.MixinBufferBuilder -> com.mojang.blaze3d.vertex.BufferBuilder: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException @Shadow field f_85647_ was not located in the target class com.mojang.blaze3d.vertex.BufferBuilder. Using refmap magnesium.refmap.json org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: @Shadow field f_85647_ was not located in the target class com.mojang.blaze3d.vertex.BufferBuilder. Using refmap magnesium.refmap.json at org.spongepowered.asm.mixin.transformer.MixinPreProcessorStandard.attachFields(MixinPreProcessorStandard.java:629) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.mixin.transformer.MixinPreProcessorStandard.attach(MixinPreProcessorStandard.java:305) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.mixin.transformer.MixinPreProcessorStandard.createContextFor(MixinPreProcessorStandard.java:280) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.mixin.transformer.MixinInfo.createContextFor(MixinInfo.java:1288) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:292) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:383) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:365) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:250) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.service.modlauncher.MixinTransformationHandler.processClass(MixinTransformationHandler.java:131) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at org.spongepowered.asm.launch.MixinLaunchPluginLegacy.processClass(MixinLaunchPluginLegacy.java:131) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] at cpw.mods.modlauncher.serviceapi.ILaunchPluginService.processClassWithFlags(ILaunchPluginService.java:156) ~[modlauncher-9.1.3.jar:9.1.3+9.1.3+main.9b69c82a] at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:88) ~[modlauncher-9.1.3.jar:?] at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-9.1.3.jar:?] at cpw.mods.modlauncher.TransformingClassLoader.maybeTransformClassBytes(TransformingClassLoader.java:50) ~[modlauncher-9.1.3.jar:?] at cpw.mods.cl.ModuleClassLoader.readerToClass(ModuleClassLoader.java:110) ~[securejarhandler-1.0.3.jar:?] at cpw.mods.cl.ModuleClassLoader.lambda$findClass$16(ModuleClassLoader.java:216) ~[securejarhandler-1.0.3.jar:?] at cpw.mods.cl.ModuleClassLoader.loadFromModule(ModuleClassLoader.java:226) ~[securejarhandler-1.0.3.jar:?] at cpw.mods.cl.ModuleClassLoader.findClass(ModuleClassLoader.java:216) ~[securejarhandler-1.0.3.jar:?] at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:132) ~[securejarhandler-1.0.3.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?] at com.mojang.blaze3d.vertex.Tesselator.<init>(Tesselator.java:19) ~[client-1.18.2-20220404.173914-srg.jar%23100!/:?] at com.mojang.blaze3d.vertex.Tesselator.<init>(Tesselator.java:23) ~[client-1.18.2-20220404.173914-srg.jar%23100!/:?] at com.mojang.blaze3d.vertex.Tesselator.<clinit>(Tesselator.java:11) ~[client-1.18.2-20220404.173914-srg.jar%23100!/:?] at com.mojang.blaze3d.systems.RenderSystem.<clinit>(RenderSystem.java:46) ~[client-1.18.2-20220404.173914-srg.jar%23100!/:?] at net.minecraft.client.main.Main.main(Main.java:167) ~[client-1.18.2-20220404.173914-srg.jar%23100!/:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:31) ~[fmlloader-1.18.2-40.1.74.jar%2317!/:?] at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.1.3.jar%235!/:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.1.3.jar%235!/:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.1.3.jar%235!/:?] at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.1.3.jar%235!/:?] at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.1.3.jar%235!/:?] at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.1.3.jar%235!/:?] at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.1.3.jar%235!/:?] at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:149) [bootstraplauncher-1.0.0.jar:?]

The error is "Mixin apply failed magnesium.mixins.json:core.pipeline.MixinBufferBuilder" in latest.log, which can be seen below. latest.log You can also see the mods loaded - hopefully it's an easy fix! :) (And I also hope it's not just me being stupid!)

It may be more accurate that it is closing, but I am not entirely certain. When I open the world without Magnesium everything is fine, but when it is in this error always occurs. latest.log

This should be the important part [23:02:50] [main/FATAL]: Preparing crash report with UUID 136ffd6b-6522-4a39-a2e8-0af5df605ec8 [23:02:50] [main/FATAL]: Unreported exception thrown! java.util.concurrent.CompletionException: java.lang.NullPointerException at java.util.concurrent.CompletableFuture.reportJoin(CompletableFuture.java:375) ~[?:1.8.0_51] at java.util.concurrent.CompletableFuture.join(CompletableFuture.java:1926) ~[?:1.8.0_51] at me.jellysquid.mods.sodium.common.util.collections.FutureDequeDrain.next(FutureDequeDrain.java:21) ~[?:1.5] at me.jellysquid.mods.sodium.client.render.chunk.backends.multidraw.MultidrawChunkRenderBackend.setupUploadBatches(MultidrawChunkRenderBackend.java:238) ~[?:1.5] at me.jellysquid.mods.sodium.client.render.chunk.backends.multidraw.MultidrawChunkRenderBackend.upload(MultidrawChunkRenderBackend.java:113) ~[?:1.5] at me.jellysquid.mods.sodium.client.render.chunk.ChunkRenderManager.updateChunks(ChunkRenderManager.java:462) ~[?:1.5] at me.jellysquid.mods.sodium.client.render.SodiumWorldRenderer.updateChunks(SodiumWorldRenderer.java:218) ~[?:1.5] at net.minecraft.client.renderer.WorldRenderer.func_228437_a_(WorldRenderer.java:9266) ~[?:?] at net.minecraft.client.renderer.WorldRenderer.func_228426_a_(WorldRenderer.java:936) ~[?:?] at net.minecraft.client.renderer.GameRenderer.func_228378_a_(GameRenderer.java:608) ~[?:?] at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:425) ~[?:?] at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:977) ~[?:?] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) [?:?] at net.minecraft.client.main.Main.main(Main.java:184) [?:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51] at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51] at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:37) [forge-1.16.5-36.2.39.jar:36.2] at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$497/1920032353.call(Unknown Source) [forge-1.16.5-36.2.39.jar:36.2] at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.1.3.jar:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.1.3.jar:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.1.3.jar:?] at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.1.3.jar:?] at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.1.3.jar:?] Caused by: java.lang.NullPointerException at net.minecraft.world.biome.BiomeColors.handler$zfe000$getWaterColor(SourceFile:558) ~[?:?] at net.minecraft.world.biome.BiomeColors.func_228363_c_(SourceFile:26) ~[?:?] at net.minecraftforge.fluids.FluidAttributes$Water.getColor(FluidAttributes.java:432) ~[?:?] at me.jellysquid.mods.sodium.client.render.pipeline.FluidRenderer.lambda$static$0(FluidRenderer.java:55) ~[?:1.5] at me.jellysquid.mods.sodium.client.render.pipeline.FluidRenderer$$Lambda$63039/1305432996.getColor(Unknown Source) ~[?:?] at me.jellysquid.mods.sodium.client.model.quad.blender.SmoothBiomeColorBlender.getBlockColor(SmoothBiomeColorBlender.java:51) ~[?:1.5] at me.jellysquid.mods.sodium.client.model.quad.blender.SmoothBiomeColorBlender.getInterpolatedVertexColor(SmoothBiomeColorBlender.java:72) ~[?:1.5] at me.jellysquid.mods.sodium.client.model.quad.blender.SmoothBiomeColorBlender.getColors(SmoothBiomeColorBlender.java:32) ~[?:1.5] at me.jellysquid.mods.sodium.client.render.pipeline.FluidRenderer.calculateQuadColors(FluidRenderer.java:364) ~[?:1.5] at me.jellysquid.mods.sodium.client.render.pipeline.FluidRenderer.render(FluidRenderer.java:237) ~[?:1.5] at me.jellysquid.mods.sodium.client.render.chunk.tasks.ChunkRenderRebuildTask.performBuild(ChunkRenderRebuildTask.java:126) ~[?:1.5] at me.jellysquid.mods.sodium.client.render.chunk.compile.ChunkBuilder$WorkerRunnable.run(ChunkBuilder.java:291) ~[?:1.5]

everything is explained here: https://github.com/Asek3/Rubidium/issues/75

demonstration of the bug: https://www.youtube.com/watch?v=JhyL5WllZyU&ab_channel=Romoslayer2.0

Just realized this now after using rubidium+oculus without helium and everything worked fine but once helium was added to the mix the bug was back.

I am trying to make a modpack for 1.16.5 and I wanted to use Magnesium, it worked fine for a while, but then all of a sudden it became incompatible with Twilight Forest and Astral Sorcery, apparently for some issues with mixins. It would seem as if there are some rendering incompatibilities with those two mods specifically, I have tried all that I could to make it work by disabling features on all three mods, but no matter what I attempt they just can't work together. I'll send the crash report, maybe something can be done about this, but I'd like to keep all three mods since they are all important for my modpack. I don't know much, but I hope this is enough to do something. crash-2022-07-09_23.24.48-client.txt