jrpcgen currently generates unwanted null checks when the iterative linked list encoding approach is used. This causes compile errors in the generated code for fields with primitive types. As an example

For Entry3 from the NFSv3 spec

struct Entry3 {
    unsigned hyper      fileid;
    string    name<>;
    unsigned hyper      cookie;
    Entry3       *nextentry;
};

jrpcgen currently generates

public long fileid;
public String name;
public long cookie;
public Entry3 nextentry;

public void xdrEncode(XdrEncodingStream xdr) throws OncRpcException, IOException {
    Entry3 $this = this;
    do {
        if( $this.fileid != null) xdr.xdrEncodeLong($this.fileid);
        if( $this.name != null) xdr.xdrEncodeString($this.name);
        if( $this.cookie != null) xdr.xdrEncodeLong($this.cookie);
        $this = $this.nextentry;
        xdr.xdrEncodeBoolean($this != null);
    } while ( $this != null );
}

This PR removes those null checks. As far as I can tell, codingMethod can be used without the additional check since it already generates code that deals with null values.

Signed-off-by: radai-rosenblatt [email protected]

basically an executable fat-jar to enable running portmap on operating systems that lack a functioning rpcbind (mac and gasp windows :-) ) you launch it as sudo java -jar ./jarpcbind-2.6.0-SNAPSHOT.jar and it will run and log to stdout until you hit ctrl-c

service bindings for osx to follow shortly

Fixed some minor issues and added some test case for portmapper set/unset/dump rpc calls. Also rpcb.match() might need some ideas as this can't be really used in other cases. i.e. when removing services rpcb content is different compared when adding services.

A call through GenericPortmapClient to client.dump agains a fresh OncRpcbindServer instance returns the following : prog: 100000, vers: 2, netid: tcp, addr: 0.0.0.0.0.111, owner: unspecified prog: 100000, vers: 2, netid: udp, addr: 0.0.0.0.0.111, owner: unspecified

here owner is "unspecified" while it is initialized to "superuser" in OncRpcbindServer constructor

new flag to jrpcgen ("-timeouts"), off by default (so should be no impact on existing users). generates methods that accept +2 arguments - long _timeoutValue, TimeUnit _timeoutUnit. backed by a ScheduledExecutorService in ReplyQueue (simple java.util.Timers arent reliable).

also fixes #14 along the way (what was a timeout to Future.get() now uses the new mechanism)

dont generate things like Future note, however, that this brings up an issue with primitive/immutable return types - we're forced to expose the underlying XdrAble wrapper - so we noe generate methods that return Future instead of Future.

Hi, I see that oncrpc4j says it is subject to the LGPL license, but it has a dependency on org.dcache.common:dcache-auth which contains source (such as DesiredRole.java) that is under AGPL. I believe that means oncrpc4j must also be licensed under AGPL.

Is there a way to break this dependency, so oncrpc4j can be cleanly under LGPL?

Add fixed vector encoding/decoding methods for int and long. jrpcgen assumes these are available. when processing the rpcbind IDL file the generated code does not compile due to these methods not being present.

if you look in org.glassfish.grizzly.nio.NIOTransport.start() at line 458 you'll see this:

} else if (kernelPoolConfig.getMaxPoolSize() < selectorRunnersCnt) {
    LOGGER.log(Level.INFO, "Adjusting kernel thread pool to max "
        + "size {0} to handle configured number of SelectorRunners",
        selectorRunnersCnt);
    kernelPoolConfig.setCorePoolSize(selectorRunnersCnt)
        .setMaxPoolSize(selectorRunnersCnt);
}

with the value for selectorRunnersCnt for TcpNioTransport coming from:

    @Override
    protected int getDefaultSelectorRunnersCount() {
        // Consider ACCEPTOR will occupy one selector thread, and depending
        // on usecase it might be idle for most of the time -
        // so allocate one more extra thread to process channel events
        return Runtime.getRuntime().availableProcessors() + 1;
    }

that means that anything under #cpus + 1 is overridden and an annoying message printed. i've fixed the util class to match grizzly

Xdr#xdrEncodeByteBuffer calls Buffer#flip on the input parameter before using it. This is rather surprising since Buffer based APIs normally use the position and limit of a Buffer to communicate which range of data should be used. Calling flip on the buffer makes it impossible to use any other position than 0. Is this intentional or a bug?

Hi,

Thanks for oncrpc4j. This project saved me a lot of time and headaches. For my RPC client app, I started to build a JNI wrapper for the .c files but using this project was very easy to use and integrate.

I noticed when I used the rpcgen project to generate source, that I was getting a stackoverflow error. My one line change fixed the issue.

    Developer's Certificate of Origin 1.1

    By making a contribution to this project, I certify that:

    (a) The contribution was created in whole or in part by me and I
        have the right to submit it under the open source license
        indicated in the file; or

    (b) The contribution is based upon previous work that, to the best
        of my knowledge, is covered under an appropriate open source
        license and I have the right under that license to submit that
        work with modifications, whether created in whole or in part
        by me, under the same open source license (unless I am
        permitted to submit under a different license), as indicated
        in the file; or

    (c) The contribution was provided directly to me by some other
        person who certified (a), (b) or (c) and I have not modified
        it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Tim Stoner [email protected]

The methods getLong and getInt in class Bytes do not check that the given array is sufficiently long, leading to occasional ArrayIndexOutOfBoundsExceptions.

Hi , I am not able to set the owner name for rpc service ..I already set the value for owner field in portmapper client .but when I type the rpcinfo . It is showing the service owner as unspecified.do you have any suggestions. I changed to portmapper v4.but there is no use

Hi, I have a multiple threads are calling the rpc server .in the code you gave the constructor .when I pass the parameters like port number , version , tcp .it is establishing connection with rpc server . But threads are making multiple call to rpc server .I don't want to open multiple connections .how can I hold the connection . Two threads need to open the one connection with rpc server and post the data to server.is there any methods I need to call from your code ?? .thanks in advance

AUTH_SYS is limited to 16 groups, however many deployments require more that 16 groups support. This is typically handled by discovering users membership information based only on provided uid and querying an external service for missing information.

Hi,

Cisco system recommends that client must not open more than 3 connection at a time at RPC server.

Is there any way we can achieve these?

Regards