GatewayIntent.GUILD_MEMBERS is required here: https://github.com/fooooooooooooooo/VelocityDiscord/blob/master/src/main/java/ooo/foooooooooooo/velocitydiscord/discord/Discord.java#L60. What for?

It would be nice to have a command to list the (number of) players on all servers and/or each specific server. Optimally this command would be available on both Discord and Minecraft.

Examples:

/list

[server1 3/20]
- player1
- player2
- player3

[server2 2/24]
- player4
- player5

[server3 0/40]
No one is online

/list server1

[server1 3/20]
- player1
- player2
- player3

The numbers after the server name would be #current players (out of) #max players allowed - though this may get tricky with plugins that spoof this.

~~(Off-topic - would [{username}@{current}] {message} be the correct way to prefix a player's message with the player's current server? Ex. [player4@server2] hello world)~~ See https://github.com/fooooooooooooooo/VelocityDiscord/issues/2 (Also, is this plugin compatible with "global chat" plugins such as chat or ChatRegulator?)

This is the only Velocity - Discord bridge kept up-to-date, so I really appreciate your work on this :)

This PR adds:

Showing the current amount of players connected to the proxy as Discord activity. The text/amount gets updated in method updateActivityPlayerAmount() which will be called when the bot is "ready" (initialize) or a player joined or left the game (regular updates). The activity text is configurable in the config.

Screenshot:

("Spielt" is "is playing" - Discord uses localized texts & my Discord client is setup with the German language.)

With the config line

[discord.chat]
join_message = "*{username} joined {server}*"

the wrong server is output in Discord. It shows the default server (lobby) instead of the server I'm actually joining. I'm using this plugin to rejoin the last server I was connected to: https://github.com/Matt-MX/ReconnectVelocity

I suggest making the /list command ephemeral. This is showing the response to the command only to the person that invoked it. I think that would be better to prevent spamming of Discord channels.

This commit allows the webhook username to be customized via the plugin config. Specifically, it adds a key "discord.webhook.webhook_username" to config.toml that is interpreted as the format of the webhook's username, replacing the variables {username} and {server} with the username and current server, respectively, of the player sending a Minecraft chat message.

Example: [{server}] {username} = [vanilla] player1

I also took the liberty of reformatting the default config file, so feel free to crucify me for that :) (on that note, it might be a good idea to reformat the config file (even more!) to make it more readable, but I figure I've gone far enough already)

Also, I merged the server connect methods, using ServerConnectedEvent rather than PlayerChooseInitialServerEvent and ServerPostConnectEvent separately. This fixes #11.

Currently you can only use the {previous} and {current} variables in the server_switch_message. However, it would be useful to be able to use these variables in other messages, especially the latter.

Some examples: ({username} = "player", {current} = "vanilla", {previous} = "modded")

~

This works fine:

server_switch_message="**{username} moved from {previous} to {current}**"

Result:

player moved from modded to vanilla

~

This does not work:

join_message="**{username} joined {current}**"

Result:

player joined {current}

Desired result:

player joined vanilla

~

Another case where this would be useful:

message="[{username}@{current}] {message}"

Desired result:

[player@vanilla] hello, world

When a Discord message is sent, it does not show in the Minecraft chat, and the following is printed to Velocity's log:

[JDA MainWS-ReadThread/WARN]: failed to get member: <member_id>

(with <member_id> being the ID of the Discord member sending the message)

I was able to fix this by reverting https://github.com/fooooooooooooooo/VelocityDiscord/commit/c07d0df460453e56640aef78bcaccb2d6c40f327 - but I'm not sure that was the cause, since I haven't done much testing...

Note that nothing has been changed in terms of the Discord bot itself (entitlements, server permissions, etc.) since prior to this issue, and that the Minecraft -> Discord bridge has been working fine all the while.

As the title says: E.g. writing "Hi @[some Discord name]" in Minecraft chat and the person will receive a Discord ping.

Further ideas:

• config option to enable/disable this feature
• distinguish usernames versus server nicknames?

In my Velocity config, I have a test server defined that I'm not always running. If the /list command fails to ping a server, it dies on an exception.

[12:16:09] [JDA MainWS-ReadThread/ERROR]: One of the EventListeners had an uncaught exception
java.lang.RuntimeException: java.util.concurrent.ExecutionException: io.netty.channel.AbstractChannel$AnnotatedConnectException: finishConnect(..) failed: Connection refused: /127.0.0.1:44444
	at ooo.foooooooooooo.velocitydiscord.discord.commands.ListCommand.handle(ListCommand.java:36) ~[?:?]
	at ooo.foooooooooooo.velocitydiscord.discord.Discord.onSlashCommandInteraction(Discord.java:187) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.api.hooks.ListenerAdapter.onEvent(ListenerAdapter.java:382) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.api.hooks.InterfacedEventManager.handle(InterfacedEventManager.java:96) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.hooks.EventManagerProxy.handleInternally(EventManagerProxy.java:88) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.hooks.EventManagerProxy.handle(EventManagerProxy.java:70) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.JDAImpl.handleEvent(JDAImpl.java:170) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.handle.InteractionCreateHandler.handleCommand(InteractionCreateHandler.java:109) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.handle.InteractionCreateHandler.handleInternally(InteractionCreateHandler.java:80) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.handle.SocketHandler.handle(SocketHandler.java:39) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.requests.WebSocketClient.onDispatch(WebSocketClient.java:953) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.requests.WebSocketClient.onEvent(WebSocketClient.java:840) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.requests.WebSocketClient.handleEvent(WebSocketClient.java:818) ~[?:?]
	at velocitydiscord.net.dv8tion.jda.internal.requests.WebSocketClient.onBinaryMessage(WebSocketClient.java:992) ~[?:?]
	at com.neovisionaries.ws.client.ListenerManager.callOnBinaryMessage(ListenerManager.java:385) ~[?:?]
	at com.neovisionaries.ws.client.ReadingThread.callOnBinaryMessage(ReadingThread.java:276) ~[?:?]
	at com.neovisionaries.ws.client.ReadingThread.handleBinaryFrame(ReadingThread.java:996) ~[?:?]
	at com.neovisionaries.ws.client.ReadingThread.handleFrame(ReadingThread.java:755) ~[?:?]
	at com.neovisionaries.ws.client.ReadingThread.main(ReadingThread.java:108) ~[?:?]
	at com.neovisionaries.ws.client.ReadingThread.runMain(ReadingThread.java:64) ~[?:?]
	at com.neovisionaries.ws.client.WebSocketThread.run(WebSocketThread.java:45) ~[?:?]
Caused by: java.util.concurrent.ExecutionException: io.netty.channel.AbstractChannel$AnnotatedConnectException: finishConnect(..) failed: Connection refused: /127.0.0.1:44444
	at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396) ~[?:?]
	at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073) ~[?:?]
	at ooo.foooooooooooo.velocitydiscord.discord.commands.ListCommand.handle(ListCommand.java:33) ~[?:?]
	... 20 more
Caused by: io.netty.channel.AbstractChannel$AnnotatedConnectException: finishConnect(..) failed: Connection refused: /127.0.0.1:44444
Caused by: java.net.ConnectException: finishConnect(..) failed: Connection refused
	at io.netty.channel.unix.Errors.newConnectException0(Errors.java:155) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.channel.unix.Errors.handleConnectErrno(Errors.java:128) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.channel.unix.Socket.finishConnect(Socket.java:321) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.doFinishConnect(AbstractEpollChannel.java:710) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.finishConnect(AbstractEpollChannel.java:687) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:567) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:477) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:385) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[velocity-3.1.2-SNAPSHOT-175.jar:3.1.2-SNAPSHOT (git-4b33d5fb-b175)]
	at java.lang.Thread.run(Thread.java:833) [?:?]

I propose that servers defined in Velocity's config that cannot be pinged be present in the /list command with something like "Server cannot be reached" in place of the player list.