Hello, Items are disapearing after you die.If keepinventory is set true, each time you die, I receive a bow.

Solution: Try to clear inventory and regive items back to player on death.

Tested on 1.19.2

Hey, can you make it so that the longer the game lasts, the more eggs you get, for example after 10 minutes of game, you get an egg every 10 seconds, after 20 minutes of game you get an egg every 5 seconds and so on

When an operator types in /mw restart or /mw appendrestart not only MissleWars restarts, but the whole Spigot server restarts as well. Even though this is expected behaviour this is not optimal in every situation and/ or is not conveyed enough. This can be problematic with Spigot servers that have other gamemodes and the operators just want to restart MissleWars.

So I would recommend either an option in the config.yml or an extension to the command so that they look like this: /mw restart <game|server> or /mw appendrestart <game|server> and when no parameter is given the game is the default option so that nothing else is bothered.

Here I would like to suggest a new file order, which is more intuitive to find the classes. The old order, especially the "wrapper", was based on technical aspects, but it feels harder to find the correct files while the developing.

Preview: I was able to build this restructuring without any access problems. https://github.com/RedstoneFuture/missilewars/tree/Workspace/Reorder_v1/missilewars-plugin/src/main/java/de/butzlabben/missilewars

Changes:

Commands:

• /cmd/* -> /commands/*

Configuration Management:

• MessageConfig.java -> /configuration/Messages.java
• Config.java -> /configuration/Config.java
• /wrapper/abstracts/arena/* -> /configuration/arena/*
• /wrapper/abstracts/Arena.java -> /configuration/arena/Arena.java
• /wrapper/abstracts/Lobby.java -> /configuration/Lobby.java

Equipment:

• /util/PlayerEquipmentRandomizer.java -> /game/equipment/PlayerEquipmentRandomizer.java
• /wrapper/game/MissileGameEquipment.java -> /game/equipment/MissileGameEquipment.java
• /wrapper/game/SpecialGameEquipment.java -> /game/equipment/SpecialGameEquipment.java

Misc Game Features:

• /util/ScoreboardManager.java -> /game/misc/ScoreboardManager.java
• /wrapper/game/RespawnGoldBlock.java -> /game/misc/RespawnGoldBlock.java
• /wrapper/game/Shield.java -> /game/misc/Shield.java
• /wrapper/stats/* -> /game/stats/*
• /wrapper/event/* ->/event/*
• /wrapper/geometry/* -> /util/geometry/*
• /wrapper/player/Interval.java -> /util/missile/Interval.java
• /wrapper/game/Team.java -> /game/Team.java
• /wrapper/abstracts/GameWorld.java -> /game/GameWorld.java
• /wrapper/missile/* -> /util/missile/*
• /wrapper/signs/* -> /util/signs/*

Player:

• /wrapper/player/MWPlayer.java -> /player/MWPlayer.java
• /wrapper/player/PlayerData.java -> /player/PlayerData.java

Game Enums:

• /game/GameState.java -> /game/enums/GameState.java
• /game/GameResult.java -> /game/enums/GameResult.java
• /wrapper/abstracts/MapChooseProcedure.java -> /game/enums/MapChooseProcedure.java

• Making PlayerArenaJoinEvent cancelable to cancel the game join
• Deleting of PrePlayerArenaJoinEvent, because it will not be used with the future changes

Currently, the player get a message with ever seconds about the fall-protection time, after death. This may be too much, so I suggest, to send the message only with the start of fall-protection. The second message is still the info about the end of it. This is enough, I think.

Hello, please update this wonderfull plugin to 1.19.2.Thank you in avance

[19:09:30 ERROR]: Error occurred while enabling MissileWars v4.3.1 (Is it up to date?)
java.lang.NullPointerException: Cannot invoke "de.butzlabben.missilewars.game.GameState.ordinal()" because "state" is null
        at de.butzlabben.missilewars.util.MotdManager.updateMOTD(MotdManager.java:44) ~[MissileWars-4.3.1.jar:?]
        at de.butzlabben.missilewars.game.Game.<init>(Game.java:144) ~[MissileWars-4.3.1.jar:?]
        at de.butzlabben.missilewars.game.GameManager.restartGame(GameManager.java:125) ~[MissileWars-4.3.1.jar:?]
        at de.butzlabben.missilewars.game.GameManager.loadGames(GameManager.java:98) ~[MissileWars-4.3.1.jar:?]
        at de.butzlabben.missilewars.game.GameManager.loadGames(GameManager.java:75) ~[MissileWars-4.3.1.jar:?]
        at de.butzlabben.missilewars.MissileWars.onEnable(MissileWars.java:101) ~[MissileWars-4.3.1.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:370) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:542) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_19_R1.CraftServer.enablePlugin(CraftServer.java:565) ~[paper-1.19.2.jar:git-Paper-299]
        at org.bukkit.craftbukkit.v1_19_R1.CraftServer.enablePlugins(CraftServer.java:479) ~[paper-1.19.2.jar:git-Paper-299]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:636) ~[paper-1.19.2.jar:git-Paper-299]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:422) ~[paper-1.19.2.jar:git-Paper-299]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:306) ~[paper-1.19.2.jar:git-Paper-299]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1100) ~[paper-1.19.2.jar:git-Paper-299]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305) ~[paper-1.19.2.jar:git-Paper-299]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

Describe the bug https://pastebin.com/fVPjByJx

To Reproduce first start-up

Server (please complete the following information):

• OS: linux/win
• Minecraft version: 1.17.1
• Java version 17
• Version 4.2.1

Additional context more info coming soon

• /PlayerListener OK
• /EndListener -> /game/EndListener
• /GameListener -> /game/GameListener
• /LobbyListener -> /game/LobbyListener
• /signs/ClickListener -> /SignListener (only 1 EventHandler)
• /signs/ManageListener -> /SignListener (only 2 EventHandler)

• Fix teleporting players to fallback spawn with server stop
• Fix twice calling of arena leave event (because of teleport)
• Fix #56 with using of newer methods to set the world gamerule - should work from 1.13.x - 1.19.x (The arena config option keep_inventory will change the keepInventory gamerule too.)
• Fix max_spectators calculation
• Fix warn Nag author(s): '[Butzlabben]' of 'MissileWars' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger).

New placeholders for plugins with PlaceholderAPI support:

• %missilewars_lobby_displayname_<lobby name or 'this'>%
• %missilewars_arena_displayname_<arena name or 'this'>%
• %missilewars_arena_missileamount_<arena name or 'this'>%

In the current dev build of ServerListPlus PlaceholderAPI placeholders can be used. Since about 130,000 admins use this plugin for their MOTD, I propose to delete the MotdManager completely and then explain the procedure in the wiki. (We have already implemented the generation of PAPI-supported placeholders.) ServerListPlus has been perfect for MOTD configurations for years and has many good features. If I leave the status configurable and then make it a PAPI placeholder "status", it is super to include in ServerListPlus. Of course, only when the PAPI support is in an official build of SLP in the future.

Our current motd manager is very limited. Outsourcing to ServerListPlus has more advantages for the admins as well.

Clean up the messages.yml / Using of message categories

The advantage here is that the admin knows better what these settings are when setting them up. It becomes altogether clearer.

Example: OLD

game_starts_new_in: Game starts new in &e%seconds% &7seconds
game_ends_in_minutes: Game ends in &e%minutes% &7minutes
game_ends_in_seconds: Game ends in &e%seconds% &7seconds
game_starts_in: Game starts in &e%seconds% &7seconds
not_enough_players: '&cThere are not enough players online'
teams_unequal: '&cThe teams are unequal distributed'
game_starts: '&aThe game starts'
fall_protection: '&cFall protection inactive in %seconds% seconds'
fall_protection_inactive: '&cFall protection inactive'
fall_protection_deactivated: '&cFall protection deactivated by sneaking'

NEW:

lobby:
  not_enough_players: '&cThere are not enough players online'
  teams_unequal: '&cThe teams are unequal distributed'
game_timer:
  game_starts_new_in: Game starts new in &e%seconds% &7seconds
  starts: '&aThe game starts'
  game_ends_in_minutes: Game ends in &e%minutes% &7minutes
  game_ends_in_seconds: Game ends in &e%seconds% &7seconds
endgame_timer:
  game_starts_in: Game starts in &e%seconds% &7seconds
fall_protection:
  timer: '&cFall protection inactive in %seconds% seconds'
  inactive: '&cFall protection inactive'
  deactivated: '&cFall protection deactivated by sneaking'

Using of variables for the settings in the messages.yml as for the config.yml:

The advantage here is that you no longer have to read the config within the plugin. In addition, you can also see which messages are no longer used in the plugin.

    public static boolean isContactAuth() {
        return cfg.getBoolean("contact_auth_server");
    }

https://github.com/RedstoneFuture/missilewars/blob/a2ff87644e7391db045ef5a34cba336548838cc1/missilewars-plugin/src/main/java/de/butzlabben/missilewars/Config.java#L180-L182