Describe the bug
In my project and libs I use custom nullability annotations that are almost one-to-one copies of spring ones, the purpose is to avoid depending on spring-core. I wanted to configure lombok to add them from fields to constructors and methods (getters/setters) for Value/Data annotated classes, but for some reason annotations are not added.
At the same time, when lombok is configured to use spring or checkerframework annotations they are added correctly.
In other words, sample class
@Value
public class Sample {
@Nullable
String prop1;
String prop2;
}
Produce different results depending on Nullable annotation.
For spring with (lombok.addLombokGeneratedAnnotation=true, lombok.addNullAnnotations=spring)
import org.springframework.lang.NonNull;
import org.springframework.lang.Nullable;
public final class Sample {
@Nullable
private final String prop1;
private final String prop2;
@Generated
public Sample(@Nullable String prop1, String prop2) {
this.prop1 = prop1;
this.prop2 = prop2;
}
@Nullable
@Generated
public String getProp1() {
return this.prop1;
}
For custom (lombok.addLombokGeneratedAnnotation=true, lombok.addNullAnnotations=CUSTOM:com.example.annotations.NonNull:com.example.annotations.Nullable)
import com.example.annotations.NonNull;
import com.example.annotations.Nullable;
import lombok.Generated;
public final class Sample {
@Nullable
private final String prop1;
private final String prop2;
@Generated
public Sample(String prop1, String prop2) {
this.prop1 = prop1;
this.prop2 = prop2;
}
@Generated
public String getProp1() {
return this.prop1;
}
To Reproduce
I've prepared a sample project that shows the problem: https://github.com/zeldigas/lombok-custom-nullable-problem. In spring module you can find usage of spring annotations and in custom - custom ones that are defined in this module as well (for simplicity)
Expected behavior
Both modules in sample project are working the same way.
Version info (please complete the following information):
- Lombok version -
1.18.24
- Platform - javac temurin-11.0.17 on Windows 10
![[FEATURE] Make Lombok compatible with JDK 16](https://avatars.githubusercontent.com/u/1064664?v=4)
![[BUG] [Regression] NetBeans integration broken in 1.18.16](https://avatars.githubusercontent.com/u/1002484?v=4)
![[FEATURE] @EasyComparable allowing relational operators on Comparables](https://avatars.githubusercontent.com/u/14800757?v=4)
![[BUG] lombok.config does not take effect for @Data](https://avatars.githubusercontent.com/u/3039112?v=4)
![[FEATURE] Augment @FieldNameConstants with asArray property](https://avatars.githubusercontent.com/u/873760?v=4)
![[BUG] Custom nullable annotations are not copied to constructors and methods for Value/Data classes](https://avatars.githubusercontent.com/u/749858?v=4)
7 Sep 7, 2022
1.1k Jan 5, 2023
3 Dec 2, 2022
3 Jan 24, 2022
29 Dec 20, 2022
5 May 3, 2022
5 Oct 5, 2022
5 Dec 27, 2022
9 Dec 9, 2022
0 Sep 1, 2022
1 Dec 24, 2021
48 Dec 27, 2022
6 May 25, 2022
579 Jan 7, 2023
12 Jun 3, 2022
19 Sep 24, 2022
3 Dec 5, 2022
7 Dec 17, 2022
26 Dec 29, 2022