Minecraft: 1.16.5 Forge: 36.2.8 Skin Layers 3D: 1.1.0 (Forge)

The game crashes when I'm loading into an existing world and I think that the game would crash with only this mod installed with Optifine and Better First Person Model mod in a freshly created world, doesn't matter but if you insist that I test with only the mods I'd mentioned above with Skin Layers 3D and create a new world then I'll do so but for now I'll provide the crash report and log.

Crash Report: https://pastebin.com/Wbub96my

Log: latest.log

Steps to reproduce

1. Have a skin which jacket layer intersects with the top part of leggings
2. Wear leggings in game with no chestplate

This bug might also affect other combinations, like armor textures that are bigger than they're intended (ex.: sleeves and gloves for chestplate). On my skin, the sides of the jacket layer clip with the sides of the leggings.

Whenever you use this mod and join a server that uses modified player heads - be it to display them in 2D or for more advanced stuff such as animations - does the mod break this stuff in one of two ways.

It either...

• ...breaks how the item looks in your inventory (When f.e. having a 2D head) or
• ...breaks how the item looks in-game (when applied to armor stands.

Quick comparison:

• With Mod:
  • 3D Animations (Using ItemsAdder. Servers such as OriginRealms are surprisingly fine...)
  • 2D Head in Inventory
• Without Mod:
  • 3D Animations
  • 2D Head in Inventory

I can't say if there would be any possible fix for this... Perhaps an option to disable the rendering on the Player head item itself?

I don't expect a fix for this, after all is what this mod does changing the models of the skin, so that certainly is nothing that could be changed easily. I wanted to spread awareness of it and share an idea for a possible solution.

Steps to reproduce:

1. /give @p player_head{SkullOwner:"(your name)"}
2. Place that skull in the world.
3. Exit Minecraft.
4. Change your skin.
5. Enter Minecraft.
6. /give @p player_head{SkullOwner:"(your name)"}
7. Place that skull in the world.
8. Note that the 3D layers are incorrect on one of the skulls.

Diagnosis:

GameProfile#equals considers two profiles to be equal if the name and UUID match, however skulls store the full GameProfile in their NBT, which includes all of the cached texture links. This means that when the user changes their skin, the skull maintains its appearance from when it was created.

This means that for skulls, it is not possible to correctly associate 3D head layer data to a GameProfile / UUID - rather, it must be associated to a texture location, whether that is the texture location stored in the NBT, or the ResourceLocation of the texture in TextureManager.

https://github.com/zlainsama/OfflineSkins/issues/57

It would be better if 3D Skin Layers mod provide an API package that accomplish this without hard dependency.

Whenever you hold an item when using the 1.8.9 version of this mod, the 2nd skin layer becomes very bright. This happens on a fresh install of Minecraft 1.8.9 (with forge 2318) without any other mods. I understand that legacy versions most likely aren't high priority, but it would be nice if this were to be fixed.

https://imgur.com/a/UHSJJ45

I play Questcraft on my oculus and your mod runs on it by default with fabric. When you go to settings or look into the inventory, the 3d skin layers are working. The issue is that it doesn't work with the hands that are used for your controllers. I was wondering if you could add support as you did for First Person Mod which also kind of works in VR. If this isn't possible I understand completely.

Thanks!

not working with LiteLoader [16:27:43] [main/ERROR] [mixin/]: 3dskinlayers.mixins.json:PlayerMixin: Unsupported mixin class version 52. Mixin requires compatibility level JAVA_8 or above. org.spongepowered.asm.mixin.transformer.InvalidMixinException: Unsupported mixin class version 52. Mixin requires compatibility level JAVA_8 or above. at org.spongepowered.asm.mixin.transformer.MixinInfo.validateClassVersion(MixinInfo.java:470) ~[liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinInfo.validateMixin(MixinInfo.java:444) ~[liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinInfo.validate(MixinInfo.java:289) ~[liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinConfig.postInitialise(MixinConfig.java:338) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer.initConfigs(MixinTransformer.java:580) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer.init(MixinTransformer.java:489) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer.transform(MixinTransformer.java:393) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer$Proxy.transform(MixinTransformer.java:109) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at net.minecraft.launchwrapper.LaunchClassLoader.runTransformers(LaunchClassLoader.java:279) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:176) [launchwrapper-1.12.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:418) [?:1.8.0_311] at java.lang.ClassLoader.loadClass(ClassLoader.java:351) [?:1.8.0_311] at java.lang.Class.forName0(Native Method) [?:1.8.0_311] at java.lang.Class.forName(Class.java:348) [?:1.8.0_311] at net.minecraft.launchwrapper.Launch.launch(Launch.java:131) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] [16:27:43] [main/ERROR] [mixin/]: 3dskinlayers.mixins.json:PlayerModelMixin: Unsupported mixin class version 52. Mixin requires compatibility level JAVA_8 or above. org.spongepowered.asm.mixin.transformer.InvalidMixinException: Unsupported mixin class version 52. Mixin requires compatibility level JAVA_8 or above. at org.spongepowered.asm.mixin.transformer.MixinInfo.validateClassVersion(MixinInfo.java:470) ~[liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinInfo.validateMixin(MixinInfo.java:444) ~[liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinInfo.validate(MixinInfo.java:289) ~[liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinConfig.postInitialise(MixinConfig.java:338) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer.initConfigs(MixinTransformer.java:580) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer.init(MixinTransformer.java:489) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer.transform(MixinTransformer.java:393) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer$Proxy.transform(MixinTransformer.java:109) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at net.minecraft.launchwrapper.LaunchClassLoader.runTransformers(LaunchClassLoader.java:279) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:176) [launchwrapper-1.12.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:418) [?:1.8.0_311] at java.lang.ClassLoader.loadClass(ClassLoader.java:351) [?:1.8.0_311] at java.lang.Class.forName0(Native Method) [?:1.8.0_311] at java.lang.Class.forName(Class.java:348) [?:1.8.0_311] at net.minecraft.launchwrapper.Launch.launch(Launch.java:131) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] [16:27:43] [main/ERROR] [mixin/]: 3dskinlayers.mixins.json:PlayerRendererMixin: Unsupported mixin class version 52. Mixin requires compatibility level JAVA_8 or above. org.spongepowered.asm.mixin.transformer.InvalidMixinException: Unsupported mixin class version 52. Mixin requires compatibility level JAVA_8 or above. at org.spongepowered.asm.mixin.transformer.MixinInfo.validateClassVersion(MixinInfo.java:470) ~[liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinInfo.validateMixin(MixinInfo.java:444) ~[liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinInfo.validate(MixinInfo.java:289) ~[liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinConfig.postInitialise(MixinConfig.java:338) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer.initConfigs(MixinTransformer.java:580) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer.init(MixinTransformer.java:489) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer.transform(MixinTransformer.java:393) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at org.spongepowered.asm.mixin.transformer.MixinTransformer$Proxy.transform(MixinTransformer.java:109) [liteloader-1.8.9-SNAPSHOT.jar:1.8.9-SNAPSHOT+unknown-b0.git-unknown] at net.minecraft.launchwrapper.LaunchClassLoader.runTransformers(LaunchClassLoader.java:279) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:176) [launchwrapper-1.12.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:418) [?:1.8.0_311] at java.lang.ClassLoader.loadClass(ClassLoader.java:351) [?:1.8.0_311] at java.lang.Class.forName0(Native Method) [?:1.8.0_311] at java.lang.Class.forName(Class.java:348) [?:1.8.0_311] at net.minecraft.launchwrapper.Launch.launch(Launch.java:131) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]

This statement is false:

This license does not allow others to distribute the software/derivative works(in source or binary form). You have to contact the author to get permission for redistribution.

Let's look at the license:

The Software may not be used to get a) a commercial advantage, or b) monetary compensation.

A person not working for Rinth Inc. (Modrinth's owner) uploading the mod to something like Modrinth is allowed, as there is no commercial advantage, nor is there any monetary compensation.

disclaimer: IANAL

Describe the bug

Expected: Config files to be saved into my custom game directory. Actual: Config files were saved to the .minecraft folder

To Reproduce

Launch game with different game directory set in the launcher

My profile is set to %APPDATA%/.wynntils, however, configs are being saved to %APPDATA%/.minecraft

Version Information

• OS: Tested on Mac and Windows
• Launcher: Official Minecraft Launcher
• Minecraft 1.18.2
• Fabric Loader version 0.14.9
• Mod Version 1.4.6

I've noticed that in PlayerRendererMixin::setModelProperties you use Minecraft.getInstance().player without a null check.

Normally this wouldn't be a problem, since no players will get rendered unless the user has a world loaded. However, this causes issues when a mod tries to render a PlayerEntity while no world is loaded, which one of my mods does. See crash report here.

This could likely be fixed very easily by adding a null check that either: cancels the method, or preferably, skips the distance check that causes the issue.

Hi, I really like your mod, but as it doesn't have a version for 1.8.9 Fabric and your license doesn't allow others to make their own port it would be really nice if you could port it.

Thanks in Advance, TheTrashCrafter

There is currently a bug within the 1.12.2 version of this mod. If you set your character to be left-handed, the 3d layers will be misaligned in 1st person. I haven't tested with every other version of minecraft except 1.16.5 which doesn't have this bug last time I checked.

As you can see here (in the glasses): https://imgur.com/a/m76gzF4

The partial transparency doesn't render properly inside the inventory layer. It renders correctly in F5 view.

When using Figura Models and 3D Skin Layers Mod at the same time in 1.18.1 causes the hat layer to be completely not rendered at the body part the model applies to.

I'm gonna post the same issue over on their github page.