Hello, When I use luck "GENERIC_LUCK": { "uuid": "bea1d20b-33cf-484d-8ee8-f967081a3b30", "name": "GENERIC_LUCK", "amount": 3, "operation": "ADD_NUMBER" } It works but it does this https://gyazo.com/0cf4448bc4e66c6443cc712e542b44dc I dont know if links work on here so i am also putting it in as a picture

But I dont want it to be so long, I cant see the other stuff on it, when I use luck like this and afterwards i add "slot": "HAND", Helm, or any other. It doesnt work, it breaks and I need to remove the "slot" out of it.

So how do i do it so that the luck doesnt "break" the tooltip?

When crafting a netherite sword out of a diamond sword, the netherite sword will be exactly the same as the diamond sword. No new quality and even the damage will be the same as diamond.

I noticed a tool while testing ended up having negative durability.

https://imgur.com/XiqS4Kz

I was actually testing about something some players mentioned.. Also a couple players talked about their tool nearly breaking then automatically almost full repairing.

is this suppose to occur? They did have the godly quality. But I couldnt recreate it due to the above thing I ran across while testing xD

Hello, i write you as you requested, images shows process when i try once again this bug. i found out that even if you put it to enchant everything but name disappear. No error in console. I know you wrote that it was fixed, i see that thats maybe not true or there is something else that make this bug.

Describe the bug - Please describe CLEARLY what went wrong.

Installing this plugin. Successfully Installed. version 1.1.0

Any item taken out of Creative or Crafted Adds the random Quality like it is supposed to.

It messes up any other Plugin. Whether it is Enchantments, Lore Name or Lore Description.

Most Noticeable with Tridents and Elytras since they sort of 'reload' or something during / after use.

Adding such modified items into something like Shopkeeper resets the item into a Item Quality (removes all lore, enchantments etc.) and creates a duplicate. (not an issue if you're in staff mode doing staff stuff. but thought I should mention this if it has useful info to it.)

To Reproduce - Please describe the steps you took to have this issue occur, if any. As explained above, basicly.

Expected behavior - Please describe the behavior you expected. As explained above, basicly.

Screenshots - Provide any applicable screenshots. Unnecessary.

Server Information - Please provide your server version, server build version (e.g paper 1.18.2 build #100) Paper 1.18.1 AND Paper 1.18.2 that I upgraded to. 'This server is running Paper version git-Paper-387 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT (Git:df630a2 on ver/1.18.2) Previous version: git-Paper-216 (MC:1.18.1)

Additional context - Please describe any additional information CLEARLY here. Plugins I'm using that seem to be interfering CrazyEnchantments CrazyEnchantments - Its GUI (Althought I suspect it is the Author of Crazy Enchantment's fault as Jobs GUI is not bothered by your plugin) LoreAttributesRecorded

Plugins I suspect may have difficulties with your Plugin but I have not tested it out properly, if you would, by any chance like me to do so... here is my discord: ★ Zhaaaaaaaaa ★#1533

I'm pretty sure you can pretty much ignore this list until reports are made

Shopkeepers <- the glitch as mentioned above in "Describe Bug" section Angelchest <- might do the reset bug ExecutableItems (Free version) <- Have not tested as I'm overloaded with other things, but I can. or I'll just report it seperately. Jobs <- Items bought from its Shop <- same thing, not tested yet. RoseStacker <- Items bought from its Shop <- same thing, not tested yet. PlayerAuctions <- Items bought from its Shop <- same thing, not tested yet.

Additionally, I would just like to thank you for your plugin. Nice work and I'll be adding some suggestions sometime later. Also sorry if my report was very cluttered or badly written.

noticed this error showed (spammed a bit). looking into what triggered it directly but wasn't on the server at the time the errors occurred. Still reporting the stack trace

[17:42:50 ERROR]: Could not pass event PlayerInteractEvent to ItemQualities v1.0.6 java.lang.IllegalArgumentException: bound must be positive at java.util.Random.nextInt(Random.java:322) ~[?:?] at com.abraxas.itemqualities.listeners.BlockListeners.reforgeItem(BlockListeners.java:239) ~[ItemQualities-1.0.6.jar:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor33.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:75) ~[purpur-api-1.19-R0.1-SNAPSHOT.jar:?] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[purpur-api-1.19-R0.1-SNAPSHOT.jar:git-Purpur-1670] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[purpur-api-1.19-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:666) ~[purpur-api-1.19-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_19_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:544) ~[purpur-1.19.jar:git-Purpur-1670] at net.minecraft.server.level.ServerPlayerGameMode.useItemOn(ServerPlayerGameMode.java:529) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.handleUseItemOn(ServerGamePacketListenerImpl.java:1945) ~[?:?] at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.handle(ServerboundUseItemOnPacket.java:37) ~[?:?] at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.a(ServerboundUseItemOnPacket.java:9) ~[?:?] at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:51) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[purpur-1.19.jar:git-Purpur-1670] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1385) ~[purpur-1.19.jar:git-Purpur-1670] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:183) ~[purpur-1.19.jar:git-Purpur-1670] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1362) ~[purpur-1.19.jar:git-Purpur-1670] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1355) ~[purpur-1.19.jar:git-Purpur-1670] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1333) ~[purpur-1.19.jar:git-Purpur-1670] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1218) ~[purpur-1.19.jar:git-Purpur-1670] at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:307) ~[purpur-1.19.jar:git-Purpur-1670] at java.lang.Thread.run(Thread.java:833) ~[?:?]

Hello,

so like said in the title, when I delete files in the directory that came with the plugin, they reappear after every 2nd server restart. First picture is what I want to have and the second is when files reappear. How can I make them not reappear after deletion?

Hope you have any idea why this happens, otherwise I'm loving the plugin.

Best regards

Apparently, all items get an NBT Tag so the plugin knows it is handcrafted. This caused quite the confusion among players on my server since they were no longer able to stack items of the same type since only some had NBT data due to the fact, that some items existed before the plugin was added and before the option for only allowing looted items to have qualities was added. Maybe there is a better way to implement this. :smile:

<censored name> has the following entity data: {id: "minecraft:oak_planks”, tag: {PublicBukkitValues: {"itemqualities:crafted"; 1}}, Count: 26b}

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the feature you'd like I would love to see a config, where i can toggle if i want the items i craft myself to be affected by the plugin. In my opinion it would be nice if the loot i get from endcitys, dungeons, villagers etc would have qualities but the stuff i craft myself should be +-0 or it should get better the more i craft.

Additional context Add any other context or screenshots about the feature request here.

[23:45:25 ERROR]: [org.bukkit.craftbukkit.v1_19_R1.CraftServer] This version of Minecraft is unsupported: 1.19.2 initializing ItemQualities v1.1.0 (Is it up to date?) dev.jorel.commandapi.exceptions.UnsupportedVersionException: This version of Minecraft is unsupported: 1.19.2 at dev.jorel.commandapi.CommandAPIVersionHandler.getNMS(CommandAPIVersionHandler.java:86) ~[ItemQualities-1.1.0.jar:?] at dev.jorel.commandapi.CommandAPIHandler.(CommandAPIHandler.java:155) ~[ItemQualities-1.1.0.jar:?] at dev.jorel.commandapi.CommandAPIHandler.getInstance(CommandAPIHandler.java:140) ~[ItemQualities-1.1.0.jar:?] at dev.jorel.commandapi.CommandAPI.onLoad(CommandAPI.java:166) ~[ItemQualities-1.1.0.jar:?] at com.abraxas.itemqualities.ItemQualities.onLoad(ItemQualities.java:40) ~[ItemQualities-1.1.0.jar:?] at org.bukkit.craftbukkit.v1_19_R1.CraftServer.loadPlugins(CraftServer.java:429) ~[paper-1.19.2.jar:git-Paper-191] at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:278) ~[paper-1.19.2.jar:git-Paper-191] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1100) ~[paper-1.19.2.jar:git-Paper-191] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305) ~[paper-1.19.2.jar:git-Paper-191] at java.lang.Thread.run(Thread.java:833) ~[?:?]

Holding an item with custom enchants on it removes the enchants. To reproduce put a custom enchant on any item and then hold it. Using Purpur 1.19 with build 1.1.0