To reproduce: The following generates a Concurrent Modification Exception:

@Test
public void testRemoveObj(){
   University uni = new University().withName("UniKasselVersitaet");
   Student student1 = uni.createStudents().withName("Peter");
   Student student2 = uni.createStudents().withName("Paul");
   Student student3 = uni.createStudents().withName("Mary");

   IdMap idMap = UniversityCreator.createIdMap("u");
   idMap.toJsonArray(uni);
   uni.removeYou();
}

One solution for this problem is to remove

Collection<?> continee = (Collection<?>) reference;
Iterator<?> i = continee.iterator();
while (i.hasNext()) {
   creator.setValue(oldValue, prop, i.next(),
   SendableEntityCreator.REMOVE);
}

and replace it with

Object[] array = ((Collection) reference).toArray();
for (int i = 0; i < array.length; i++) {
   Object object = array[i];
   creator.setValue(oldValue, prop, object,
   SendableEntityCreator.REMOVE);
}

(IdMap, line 422ff) This works for newly generated Models but not for the one, that is inside the test-package. And it is also slower.

GitHub recently changed the way they parse markdown, especially headlines. Because headlines now require a space after #, the table of the gradle commands is not rendered correctly.

This PR fixes the headlines of the README.md

fujaba/NetworkParser now has a Chat Room on Gitter

@StefanLindel has just created a chat room. You can visit it here: https://gitter.im/NetworkParser/Lobby.

This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.

Happy chatting.

PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Thanks for trying out GitMagic.

Use this pull request to discuss and define what contribution guidelines you want to enforce in this repository. Here's a list of all available rules.

If you're happy with the set of rules as it is, you can go ahead and merge it.

If there is any rule that you are missing, or if you have any questions, send us an email at [email protected], we're happy to help.

Good luck! :bowtie:

How to test this PR

It is not possible to test this pull request without merging it. Once merged, you can verify that your rules are being enforced by either opening a new pull request or creating an issue. _{This pull request was made by GitMagic – Magically enforcing your contribution guidelines.}

If you call someJsObject.getLong(someKey) and the value is a String like "1234567890", then the number will not parse as a long. There will just throw a runtime exception.

Description

This behaves like described on issue #2.

String foo = new JsonObject().withValue("{\"foo\": null }").getString("foo");
// foo is ""

Trying to solve the question of #2, I tried using the overload of getString(String key, String defaultValue):

String foo = new JsonObject().withValue("{\"foo\": null }").getString("foo", null);
// Expected:
// foo is either null or ""
// Actual behaviour:
// NullPointerException

Expected Behaviour

JsonObject#get(key, default) behaves like JsonObject#get(key) except it should return some kind of default value if the key/value was not found.

Actual Behaviour

NullPointerException, regardless of which value gets passed for defaultValue.

Affected NetworkParser: 4.4.246 (using version selector [4.2,)).

Consider this JSON document:

{"foo": null }

The foo property is either a string or null. When I try the following:

String json = "{\"foo\": null }";
JsonObject obj = new JsonObject().withValue(json);
String foo = obj.getString("foo");

I expected foo to be null, not "".

How to distinguish "foo": null from "foo": ""? I looked up how org.json handles this case. As stated here, it behaves similar: http://stackoverflow.com/questions/13118146

However, org.json provides an isNull method. Since there are no docs for the NetworkParser, I ended up looking in the source, ending up with nothing.

That leaves me with the question: How to distinguish between "" and null using the NetworkParser library when using getString?

Edit: I am currently using this workaround:

String nullable = (String)obj.get("foo");

However, considering this JSON document: {"foo": 5 }, the cast to String will fail because get() returns the int 5 (which seems good to me), whereas getString() returns "5" in this case.

Snyk has created this PR to upgrade diagramjs from 0.0.7 to 0.0.8.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

• The recommended version is 1 version ahead of your current version.
• The recommended version was released 4 years ago, on 2018-04-22.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs