See GEOT-6709 GeoTools v24 fails with ExceptionInInitializerError caused by an InaccessibleObjectException trying to access tech.units.indriya internals

• [x] Confirm you have read the contribution guidelines
• [x] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
• [x] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.
• [ ] The changes are not breaking the build in downstream projects using SNAPSHOT dependencies, GeoWebCache and GeoServer (there is an automatic PR check verifying this, check this when it turns green).

The following are required only for core and extension modules (they are welcomed, but not required, for unsupported modules):

• [x] There is an issue in Jira describing the bug/task/new feature (a notable exemptions is, changes not visible to end users). The ticket is for the GeoTools project, if the issue was found elsewhere it's a good practice to link to the origin ticket/issue.
• [x] The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it.
• [x] PR for bug fixes and small new features are presented as a single commit
• [x] Commit message(s) must be in the form "[GEOT-XYZW] Title of the Jira ticket"
• [ ] New unit tests have been added covering the changes
• [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• [ ] This PR passes the QA checks (QA checks results will be reported by travis-ci after opening this PR)
• [ ] Documentation has been updated accordingly.

The goal of this pull request is to migrate from the Units of Measure API 1.0 (JSR 363) to the Units of Measure API 2.0 (JSR 385).

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• [x] Confirm you have read the contribution guidelines
• [x] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
• [x] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.
• [ ] The changes are not breaking the build in downstream projects using SNAPSHOT dependencies, GeoWebCache and GeoServer.

The following are required only for core and extension modules (they are welcomed, but not required, for unsupported modules):

• [x] There is an issue in Jira describing the bug/task/new feature (a notable exemptions is, changes not visible to end users). The ticket is for the GeoTools project, if the issue was found elsewhere it's a good practice to link to the origin ticket/issue.
• [ ] The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it.
• [x] PR for bug fixes and small new features are presented as a single commit
• [x] Commit message must be in the form "[GEOT-XYZW] Title of the Jira ticket"
• [ ] New unit tests have been added covering the changes
• [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• [ ] This PR passes the QA checks (QA checks results will be reported by travis-ci after opening this PR)
• [ ] Documentation has been updated accordingly.

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

The main goal is to create a factory for creating HTTPClient. It will also extract some functionality from gt-main into a new library gt-http. The objective for this is to make it more visible, and include the external library Commons HTTPClient.

See also:

• https://osgeo-org.atlassian.net/browse/GEOT-6755
• https://github.com/geotools/geotools/wiki/HTTPClient-Factory

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• [X] Confirm you have read the contribution guidelines
• [X] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
• [X] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.
• [x] The changes are not breaking the build in downstream projects using SNAPSHOT dependencies, GeoWebCache and GeoServer (there is an automatic PR check verifying this, check this when it turns green).

The following are required only for core and extension modules (they are welcomed, but not required, for unsupported modules):

• [X] There is an issue in Jira describing the bug/task/new feature (a notable exemptions is, changes not visible to end users). The ticket is for the GeoTools project, if the issue was found elsewhere it's a good practice to link to the origin ticket/issue.
• [X] The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it.
• [ ] PR for bug fixes and small new features are presented as a single commit
• [ ] Commit message(s) must be in the form "[GEOT-XYZW] Title of the Jira ticket"
• [X] New unit tests have been added covering the changes
• [x] This PR passes all existing unit tests (test results will be reported by Continuous Integration after opening this PR)
• [x] This PR passes the QA checks (QA checks results will be reported by Continuous Integration after opening this PR)
• [x] Documentation has been updated accordingly.

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or not applicable.

Checklist

• [x] I have read the contribution guidelines.
• [x] I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• [x] First PR targets the main branch (backports managed later; ignore for branch specific issues).
• [x] Avoid Java 9+ split packages.
• [ ] All the build checks are green (see automated QA checks).

For core and extension modules:

• [ ] New unit tests have been added covering the changes.
• [ ] Documentation has been updated (if change is visible to end users).
• [x] There is an issue in GeoTools Jira (except for changes not visible to end users).
• [x] Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
• [x] Bug fixes and small new features are presented as a single commit.
• [x] The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

Fixes GEOT-5289 by extending FactoryRegistry to implement the ServiceRegistry API. Work similar to this has been done in #1064 but was not merged due to legal concerns. This reimplementation is solely based on the calls GeoTools classes make to the ServiceRegistry API - no JDK code was copied.

This PR is by no means complete. The main classes (FactoryRegistry, CategoryRegistry, and PartiallyOrderedSet) are littered with TODOs and I made some design decisions that need to be revisited. But GeoTools builds (on Java 8) and so does our project using it (compiling/testing on Java 9), so it fulfills the minimum requirements.

I decided not to add the open issues as line comments because it is harder to keep track of them, particularly when they get folded due to new commits. Instead I put all my concerns here - sorry for the wall of text.

Call Hierarchy Driven Design

I only implemented those ServiceRegistry methods that are called in the GeoTools code base as well as some overloads that seemed to make sense (mostly to make registration and deregistration symmetrical).

This could break clients that call ServiceRegistry methods that GeoTools does not call. Someone might have to investigate this.

Exceptions

The new code in FactoryRegistry can throw exception. At least one of the existing methods does some fancy exception creation. Maybe the new ones should do that, too?

Registrable Services

The service registry calls providers when they are (de)registered if they implement the RegisterableService interface. The methods expect a ServiceRegistry as parameter, though, and the FactoryRegistry no longer fufills that requirement.

My temporary solution was to create a RegistrableFactory interface and have registrable GeoTools classes implement it.

This change is in so far backwards incompatible that user implementations of RegisterableService will silently stop getting called. A weird way to address this could be to throw an exception when an implementation of RegisterableService is encountered.

Naming

Since this change is not 100% backwards compatible, it might make sense to go all the way and rename the methods inherited from ServiceRegistry. Since this class seems to be concerned with factories, I would replace ServiceProvider with Factory in all new methods. More explicit breakage might actually improve error-free migration because it highlights the changes and gives a good opportunity to inform the caller of the change to registrable services/factories.

Backwards-compatible, deprecated overloads could be provided.

Replace Filter With Predicate

Since we're breaking code anyway (maybe), why not replace Filter With Predicate? Would make integration with Java 8 more seamless.

Backwards-compatible, deprecated overloads could be provided.

Partially Ordered Set

I decided to reuse the existing PartiallyOrderedSet. To get it to where I can use it, I simply copied it into the gt-main project. It is entirely possible that a better place exists.

The implementation also had at least two bugs and while fixing them I ended up changing the code quite a lot. I'm happy to provide information on why exactly I picked the current design.

This adds a new "tpk" module. Authored by my colleague @murraymcdonald16

This is the pull request for this JIRA issue:

https://osgeo-org.atlassian.net/projects/GEOT/issues/GEOT-6393

Prior to this commit, JDBCJoiningFeatureReader had an off-by-one bug its column cursor management for joins on DataStores with exposed primary keys. See GEOS-5149 for an example of the kind of behavior this bug was causing.

Also added logic to exercise primary key exposition in JDBCFeatureReaderTest, and extended JDBCFeatureReaderTest to exercise JDBCJoiningFeatureReader.

This PR upgrades the SWT module as per discussions had in the mailinglist.

This basically upgrades swt libraries, updates to latest gt api and fixes the bugs reported in JIRA.

After some discussion, it has been decided to remove the RCP related part, since it is too complex to maintain (it would need an existing RCP project in a different repository). Also in the docs these parts were removed.

Checklist

• [x] I have read the contribution guidelines.
• [x] I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• [x] First PR targets the main branch (backports managed later; ignore for branch specific issues).
• [ ] Avoid Java 9+ split packages.
• [x] All the build checks are green (see automated QA checks).

Hopefully I have adressed all complaints about the older pull request (#1467). Now the PR is against master. I have removed all formatting issues (that was hard). I have as far as I see it now a more general version.

@mattkrusz / @vickdw - I am reviewing the MapBox Style stuff in chunks - here is part one (MBStyle, MBLayer, and children). I will be continuing to review the rest of the codebase, and add to this PR as I do.

I've done a bunch of fixup (mostly javadocs and formatting, but there is also some code changes that may or may not be correct).

I also have some general comments that should be addressed - feel free to add to this PR as these are dealt with.

Checklist

• [x] I have read the contribution guidelines.
• [x] I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• [x] First PR targets the main branch (backports managed later; ignore for branch specific issues).
• [ ] Avoid Java 9+ split packages.
• [ ] All the build checks are green (see automated QA checks).

For core and extension modules:

• [x] New unit tests have been added covering the changes.
• [ ] Documentation has been updated (if change is visible to end users).
• [x] There is an issue in GeoTools Jira (except for changes not visible to end users).
• [x] Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
• [ ] Bug fixes and small new features are presented as a single commit.
• [x] The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

So far, JDBCDataStore does not add select-hints to queries on virtual tables. This makes sense for some SQLDialects, but not for all.

This change adds a new method applyHintsOnVirtualTables() to the SQLDialect class that allows the concrete SQLDialect to control whether hints are added to queries on virtual tables. The default implementation of applyHintsOnVirtualTables() returns false to keep the current behavior.

For the HANA plugin, the behavior has been adapted to add select-hints to queries on virtual tables.

Checklist

• [X] I have read the contribution guidelines.
• [X] I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• [X] First PR targets the main branch (backports managed later; ignore for branch specific issues).
• [X] Avoid Java 9+ split packages.
• [ ] All the build checks are green (see automated QA checks).

For core and extension modules:

• [X] New unit tests have been added covering the changes.
• [ ] Documentation has been updated (if change is visible to end users).
• [X] There is an issue in GeoTools Jira (except for changes not visible to end users).
• [X] Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
• [X] Bug fixes and small new features are presented as a single commit.
• [X] The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

Adds support for locking on transformed feature types

Checklist

• [x] I have read the contribution guidelines.
• [x] I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• [x] First PR targets the main branch (backports managed later; ignore for branch specific issues).
• [x] Avoid Java 9+ split packages.
• [ ] All the build checks are green (see automated QA checks).

For core and extension modules:

• [x] New unit tests have been added covering the changes.
• [x] Documentation has been updated (if change is visible to end users).
• [x] There is an issue in GeoTools Jira (except for changes not visible to end users).
• [x] Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
• [x] Bug fixes and small new features are presented as a single commit.
• [x] The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

GDAL changed the return of ((Geometry) geom).WkbSize(); from int to long. Here a workaround

Checklist

• [x] I have read the contribution guidelines.
• [ ] I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• [x] First PR targets the main branch (backports managed later; ignore for branch specific issues).
• [x] Avoid Java 9+ split packages.
• [ ] All the build checks are green (see automated QA checks).

For core and extension modules:

• [ ] New unit tests have been added covering the changes.
• [ ] Documentation has been updated (if change is visible to end users).
• [ ] There is an issue in GeoTools Jira (except for changes not visible to end users).
• [ ] Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
• [x] Bug fixes and small new features are presented as a single commit.
• [x] The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

test: https://github.com/geoserver/geoserver/pull/6400

Checklist

• [x] I have read the contribution guidelines.
• [x] I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• [x] First PR targets the main branch (backports managed later; ignore for branch specific issues).
• [x] Avoid Java 9+ split packages.
• [x] All the build checks are green (see automated QA checks).

For core and extension modules:

• [x] New unit tests have been added covering the changes.
• [ ] Documentation has been updated (if change is visible to end users).
• [x] There is an issue in GeoTools Jira (except for changes not visible to end users).
• [x] Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
• [x] Bug fixes and small new features are presented as a single commit.
• [x] The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

Making the ReTypingFeatrueIterator more usable by reducing the limitations on attributes. Fixes a problem where AttributeType names are different. Therefor is the test somewhat small.

Checklist

• [X] I have read the contribution guidelines.
• [X] I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• [X] First PR targets the main branch (backports managed later; ignore for branch specific issues).
• [X] Avoid Java 9+ split packages.
• [x] All the build checks are green (see automated QA checks).

For core and extension modules:

• [X] New unit tests have been added covering the changes.
• [ ] Documentation has been updated (if change is visible to end users).
• [X] There is an issue in GeoTools Jira (except for changes not visible to end users).
• [X] Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
• [X] Bug fixes and small new features are presented as a single commit.
• [X] The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).