I ran into a bug in which I expected a result set of about 3600 rows and get 1. The row I get back is the last row of the result set I see in Oracle SQL Developer. I've traced the issue to handleRowValues() in NestedResultSetHandler. Based on tracing thru that code in the debugger the row value gets set by the line:

rowValue = getRowValue(rs, discriminatedResultMap, rowKey, rowKey, null, resultColumnCache, partialObject);

but then nothing actually happens with the value. It would appear that the if statement right after should be within the bracket directly above it (existing source below):

while (shouldProcessMoreRows(rs, resultContext, rowBounds)) {
  final ResultMap discriminatedResultMap = resolveDiscriminatedResultMap(rs, resultMap, null);
  final CacheKey rowKey = createRowKey(discriminatedResultMap, rs, null, resultColumnCache);
  Object partialObject = objectCache.get(rowKey);
  if (partialObject == null && rowValue != null) { // issue #542 delay calling ResultHandler until object ends
    if (mappedStatement.isResultOrdered()) objectCache.clear(); // issue #577 clear memory if ordered
    callResultHandler(resultHandler, resultContext, rowValue);
  } 
  rowValue = getRowValue(rs, discriminatedResultMap, rowKey, rowKey, null, resultColumnCache, partialObject);
}
if (rowValue != null) callResultHandler(resultHandler, resultContext, rowValue);

In the 3.1.1 release the rowValue is bieng put into another collection:

while (shouldProcessMoreRows(rs, resultContext, rowBounds)) {
  final ResultMap discriminatedResultMap = resolveDiscriminatedResultMap(rs, resultMap, null);
  final CacheKey rowKey = createRowKey(discriminatedResultMap, rs, null, resultColumnCache);
  final boolean knownValue = objectCache.containsKey(rowKey);
  Object rowValue = getRowValue(rs, discriminatedResultMap, rowKey, resultColumnCache);
  if (!knownValue) {
    resultContext.nextResultObject(rowValue);
    resultHandler.handleResult(resultContext);
  }
}

EDIT: maybe not quite that simple as I didn't look at the source enough before posting. Based on more debugging the callResultHandler inside the if statement (thats inside the while loop) is never getting called. That would explain why i am only seeing the last row of the resultset in the returned collection. its being put in there by the second if.

Hi,

Are there any plans to support support for Java's 8 Optional<T>. I guess however due to the type erasure you would always have to specify the wrapped javaType.

If not plans, did anybody developed either a plugin or type handler?

Thanks.,

Raphael

Hi,

We are using mybatis-3.3.0. Recently we got one strange error from mybatis code while executing a query that gets executed successfully many times during the day, but failed several times.

Below is the stacktrace:

org.apache.ibatis.ognl.NoSuchPropertyException: OrderXEO.cinemaAddress
    at org.apache.ibatis.scripting.xmltags.OgnlCache.getValue(OgnlCache.java:46) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.ExpressionEvaluator.evaluateBoolean(ExpressionEvaluator.java:32) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.IfSqlNode.apply(IfSqlNode.java:34) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.MixedSqlNode.apply(MixedSqlNode.java:33) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.TrimSqlNode.apply(TrimSqlNode.java:55) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.MixedSqlNode.apply(MixedSqlNode.java:33) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.DynamicSqlSource.getBoundSql(DynamicSqlSource.java:41) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.mapping.MappedStatement.getBoundSql(MappedStatement.java:280) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.executor.CachingExecutor.query(CachingExecutor.java:80) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.session.defaults.DefaultSqlSession.selectList(DefaultSqlSession.java:120) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.session.defaults.DefaultSqlSession.selectList(DefaultSqlSession.java:113) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.session.defaults.DefaultSqlSession.selectOne(DefaultSqlSession.java:73) ~[mybatis-3.3.0.jar:3.3.0]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_45]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_45]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45]
    at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45]
    at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:358) ~[mybatis-spring-1.2.2.jar:1.2.2]
    ... 36 more
Caused by: org.apache.ibatis.ognl.NoSuchPropertyException: OrderXEO.cinemaAddress
    at org.apache.ibatis.ognl.ObjectPropertyAccessor.getProperty(ObjectPropertyAccessor.java:151) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.OgnlRuntime.getProperty(OgnlRuntime.java:2434) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.ASTProperty.getValueBody(ASTProperty.java:114) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.SimpleNode.evaluateGetValueBody(SimpleNode.java:212) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.SimpleNode.getValue(SimpleNode.java:258) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.ASTChain.getValueBody(ASTChain.java:141) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.SimpleNode.evaluateGetValueBody(SimpleNode.java:212) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.SimpleNode.getValue(SimpleNode.java:258) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.ASTNotEq.getValueBody(ASTNotEq.java:50) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.SimpleNode.evaluateGetValueBody(SimpleNode.java:212) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.SimpleNode.getValue(SimpleNode.java:258) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.ASTAnd.getValueBody(ASTAnd.java:61) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.SimpleNode.evaluateGetValueBody(SimpleNode.java:212) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.SimpleNode.getValue(SimpleNode.java:258) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.Ognl.getValue(Ognl.java:494) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.ognl.Ognl.getValue(Ognl.java:458) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.OgnlCache.getValue(OgnlCache.java:44) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.ExpressionEvaluator.evaluateBoolean(ExpressionEvaluator.java:32) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.IfSqlNode.apply(IfSqlNode.java:34) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.MixedSqlNode.apply(MixedSqlNode.java:33) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.TrimSqlNode.apply(TrimSqlNode.java:55) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.MixedSqlNode.apply(MixedSqlNode.java:33) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.scripting.xmltags.DynamicSqlSource.getBoundSql(DynamicSqlSource.java:41) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.mapping.MappedStatement.getBoundSql(MappedStatement.java:280) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.executor.CachingExecutor.query(CachingExecutor.java:80) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.session.defaults.DefaultSqlSession.selectList(DefaultSqlSession.java:120) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.session.defaults.DefaultSqlSession.selectList(DefaultSqlSession.java:113) ~[mybatis-3.3.0.jar:3.3.0]
    at org.apache.ibatis.session.defaults.DefaultSqlSession.selectOne(DefaultSqlSession.java:73) ~[mybatis-3.3.0.jar:3.3.0]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_45]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_45]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45]
    at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45]
    at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:358) ~[mybatis-spring-1.2.2.jar:1.2.2]

Any help to find root cause of above error will be greatly appreciated. Ps. We have met a similar problem(https://github.com/mybatis/mybatis-3/issues/199) when using mybatis-3.1.0, which has fixed in mybatis-3.3.0. Is this the same cause?

MyBatis version

3.3.1

Database vendor and version

Test case or example project

Steps to reproduce

Expected result

Actual result

Support insert multiple rows and write-back id.

Multirow inserts

A SQL feature (since SQL-92) is the use of row value constructors to insert multiple rows at a time in a single SQL statement:

INSERT INTO tablename (column-a, [column-b, ...])
VALUES ('value-1a', ['value-1b', ...]),
       ('value-2a', ['value-2b', ...]),
       ...

This feature is supported by DB2, SQL Server (since version 10.0 - i.e. 2008), PostgreSQL (since version 8.2), MySQL, sqlite (since version 3.7.11) and H2.

More about insert see here:

http://en.wikipedia.org/wiki/Insert_(SQL)

More details of this pull request see here: https://github.com/mybatis/mybatis-3/pull/324

MyBatis version

3.5.0

Database vendor and version

Oracle

Test case or example project

Using the following spring 5.1.8 mybatis: 3.5.0 mybatis-spring - 2.0.1 ,

Context: a. We were using the mybatis 1.1.1 having no issues using criteriawithListvalue with earlier version of spring 3xx

b. We upgraded to spring 5.xx as part of app remediation.

c. we started getting the spring jdk version with respective mybatis 1.1.1 as it was pointing to spring core 3.xx and now we have 5.xx

d. So upgraded mybatis-spring 2.0.1 and mybatis 3.5.0 , with jdk 8

Then we started getting the ibatis builder exception with list.key as

org.apache.ibatis.ognl.NoSuchPropertyException java.string.String.key.

Please suggest the above stated issue fixed in mybatis 3.5.1 without any other consequences during runtime. ?

Steps to reproduce

Expected result

Actual result

It is currently not possible to reuse a resultmap created using the @ConstructorArgs and/or @Results annotation.

If would be nice if you could name and reference @Results, e.g.:

@Select("select * from users")
@Results(id = "User", value = {
  @Result(property = "id", column = "id", id = "true"),
  @Result(property = "firstName", column = "first_name")
  @Result(property = "lastName", column = "last_name")
})
List<User> getUsers();

@Select("select * from users where id = #{value}")
@ResultMap("User")
User getUserById(int id);

@Select("select * from users where first_name = #{value}")
@ResultMap("User")
List<User> getUsersByFirstName(String firstName);

Note: Please also consider implementing issue #81

When insert a list or array,resolve the useGeneratedKeys error.

The Sample:

Mapper.xml File:

<insert id="insertAll" keyProperty="id" useGeneratedKeys="true">
  insert into country(countryname,countrycode)
  VALUES
  <foreach collection="list" item="country" separator=",">
    (#{country.countryname},#{country.countrycode})
  </foreach>
</insert>

The Java code File:

List<Country> countryList = new ArrayList<Country>();
Country country = new Country();
country.setCountryname("Name1");
country.setCountrycode("N1");
countryList.add(country);

country = new Country();
country.setCountryname("Name2");
country.setCountrycode("N2");
countryList.add(country);

country = new Country();
country.setCountryname("Name3");
country.setCountrycode("N3");
countryList.add(country);

country = new Country();
country.setCountryname("Name4");
country.setCountrycode("N4");
countryList.add(country);
//ERROR:
//Caused by: org.apache.ibatis.binding.BindingException: 
//Parameter 'id' not found. Available parameters are [list]
int result = sqlSession.insert("insertAll",countryList);

for (Country country1 : countryList) {
    System.out.println(country1.getId());
}

Solution

Add a method to handle the parameters:

private Collection<Object> getParameters(Object parameter)

Add a first Key keys,and then developer can use keys to specify the reveive param.

If not specif,find listorarray.If not existed,use the parameter only.

Note:use Collectionsupport more than List,like Set.

MyBatis version

3.4.5

Database vendor and version

H2

Test case or example project

See attached

Steps to reproduce

Run BadChannelDaoTest Note the failure message contains "org.apache.ibatis.executor.ExecutorException: No constructor found ..."

Run GoodChannelDaoTest Note that the test passes.

Expected result

Both tests should pass.

Actual result

The BadChannelDaoTest fails. This is because the constructor selector code in Mybatis does not check whether the type mappings can be applied; it simply compares the DB column types with the constructor parameter types for an exact match, which it cannot find.

I added a new option for specify the behavior when detects an unknown column (or unknown property type) of automatic mapping target.

Options are as follow:

• NONE : Do nothing (Default) -> Same with current implementation
• WARNING : Output warning log with detail
• FAILING : Fail mapping (throw SqlSessionException with detail)

I think this option is useful for detects a type mistake during development.

What do you think ?

#1158

This PR is the implementation of the approach outlined in 1158. I am working on the tests but before I get too much further and spend more time I want to make sure I can get this merged in. The vast majority of changes are just about back-porting tests. All new code is in org.apache.ibatis.jdbc

1. It is backward compatible. Original functionality is maintained
2. This allows for subsequent implementations for MySqlScriptRunner and OracleScriptRunner etc.
3. The current parsing code doesn't handle ; within COMMENT 'this is a ; semicolon'; And allows for individual implementation
4. Resolves multiple ScriptRunners that may support the same DB type by assigning priority. This, for example, allows OriginalScriptRunner to always respond yes to any DB connection but taking a backseat to any others that claim to do the job better

I have a query that returns a single row, but the single row contains only nulls in each of its columns. When MyBatis executes this query, it returns null, rather than provide me with the appropriate object with its fields initialised to null.

I have debugged this and I can see that the MyBatis FastResultSetHandler throws the result away, even when callSettersOnNulls is set to true. The applyPropertyMappings method checks the value of the callSettersOnNulls, but if the field being mapped is null, the object is not returned, but simply thrown away.

I am using MyBatis 3.2.2. I have provided some simplified snippets of my Java code and MyBatis configuration below.

<select id="getSomething" parameterType="int" resultMap="getSomethingMap">
    SELECT top 1
           property_a,
           property_b
    FROM   SOME_USER..SOMETHING_TABLE
    WHERE  entity_id = #{entityId}
</select>

<resultMap id="getSomethingMap" type="Something">
    <result property="propertyA" column="property_a" javaType="java.lang.String" jdbcType="VARCHAR"/>
    <result property="propertyB" column="property_b" javaType="java.lang.String" jdbcType="VARCHAR"/>
</resultMap>    

// Snippet of "Something" Java class
public class Something {

    private String propertyA;
    private String propertyB;

    public void setPropertyA(String propertyA) {
        this.propertyA = propertyA;
    }

    public String getPropertyA() {
        return propertyA;
    }

    public void setPropertyB(String propertyB) {
        this.propertyB = propertyB;
    }

    public String getPropertyB() {
        return propertyB;
    }
}

In our work time it's is possible to write a error resultType in mapper.xml. I think we can resolve resultType by namespce and id in mapper.xml, then we can avoid this error

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | org.hsqldb:hsqldb (source) | 2.6.1 -> 2.7.1 | | | | |

GitHub Vulnerability Alerts

CVE-2022-41853

Those using java.sql.Statement or java.sql.PreparedStatement in hsqldb (HyperSQL DataBase) to process untrusted input may be vulnerable to a remote code execution attack. By default it is allowed to call any static method of any Java class in the classpath resulting in code execution. The issue can be prevented by updating to 2.7.1 or by setting the system property "hsqldb.method_class_names" to classes which are allowed to be called. For example, System.setProperty("hsqldb.method_class_names", "abc") or Java argument -Dhsqldb.method_class_names="abc" can be used. From version 2.7.1 all classes by default are not accessible except those in java.lang.Math and need to be manually enabled.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

I know this is really a big change, and may bring up some backward compatible problem, so suggest is welcome

Add future

1. Add ResolvedType, only wrap Jackson JavaType. For not depend on jackson, copy classes relate to JavaType into org.apache.ibatis.reflection.type.jackson package. Now use JavaType from external Jackson first. #2187
2. Add ResolvedMethod, to get returnType and parameterType easier
3. Implement ListTypeHandler SetTypeHandler. #1445
4. Register ListTypeHandler, SetTypeHandler and ArrayTypeHandler into TypeHandlerRegistry, then we don't need to write typeHandler="ArrayTypeHandler" in xml
5. resultType and resultMap in xml is not obligatory, get Mapper Class by namespace and get Method by id, then we can get returnType

Other changes

1. Add ParamNameResolver#getNamedParamsType, this may return a MapDescriptorResolvedType when ParamNameResolver#getNamedParams return a ParamMap, MapDescriptorResolvedType contains each value ResolvedType
2. List or array index access check, see PropertyTokenizer#isIndexAccess, without this change ArrayTypeHandler will use for #{array[0]}
3. LanguageDriver interface add two createSqlSource methods that use ResolvedType instead of Class, all createSqlSource methods are default for backward compatible
4. TypeReference do not resolve TypeParameter at construct time, getRawType is useless for now
5. Make some method and field protected. I tried to make my futures compatible with mybatisPlus, but fond they copy lost of code to their project. make method protected, so that mybatisPlus do not need copy

May be not backward compatible

1. TypeHandlerRegistry#typeHandlerMap use ResolvedType as map key, this may have problem for user custom typeHandler. For example user write a typeHandler for ArrayList<Object> but hope autoMapping for ArrayList<String>, this may no problem before, but now autoMapping will can't find typeHandler, because of typeParameter not match
2. TypeHandlerRegistry#getMappingTypeHandler will check whether the TypeHandler need a Class for construct. I hope user can just write typeHandler without write javaType, because javaType attribute can't resolve ParameterizedType. #995
3. Try to resolve TypeHandler at SqlSourceBuilder, not use UnknownTypeHandler, because in UnknownTypeHandler can only get parameter Class, not ParameterizedType
4. DynamicSqlSource add ParamType, for pass ParameterizedType, I add a parameterType parameter to constructor, this may occur exception if user pass instance that not instanceof parameterType
5. User can pass Map<String,String> into function with Map<Map,Integer> parameter by cast, just like (Map) stringValueMap. Mybatis use UnknownTypeHandler for Map parameter at before, there is no problem if user pass wrong type. but now we can know we just need use IntegerTypeHandler to handle Map values, use IntegerTypeHandler to handle String will occur exception

An attempt at fixing #2754 Related to #206 and #575

When processing DynamicSqlSource, evaluate param values in scripting phase and store them in ParameterMapping. This does not affect RawSqlSource.

Just to be clear, it still is not possible to invoke a method inside a parameter reference like #{_parameter.mymethod(_parameter.value)}. It might be possible to accept OGNL expression in a param reference (e.g. #{${_parameter.mymethod(_parameter.value)}}), but I'm not sure if that's a good idea.

This should not break backward compatibility for normal usages, however, plugins that manipulate internal stuff might be affected.

@emacarron @mnesarco If this does not seem like the right approach to you, please let me know!

I found the following problem and report it. If I have time, I will fix it and create a pull request.

MyBatis version

3.5.11

Database vendor and version

SQLite3 (probably for any vendor)

Test case or example project

https://github.com/tsasaki609/mybatis-3-sscce-foreach-with-bind

Steps to reproduce

check out the example project and run

Expected result

09:44:57.720 [main] DEBUG mybatis.sscce.foreach.with.bind.FooMapper.countBar - ==> Preparing: SELECT count(*) FROM bar WHERE id IN ( ? , ? ) 09:44:57.755 [main] DEBUG mybatis.sscce.foreach.with.bind.FooMapper.countBar - ==> Parameters: test001(String), test002(String) 09:44:57.787 [main] DEBUG mybatis.sscce.foreach.with.bind.FooMapper.countBar - <== Total: 1 2

Actual result

09:44:57.720 [main] DEBUG mybatis.sscce.foreach.with.bind.FooMapper.countBar - ==> Preparing: SELECT count(*) FROM bar WHERE id IN ( ? , ? ) 09:44:57.755 [main] DEBUG mybatis.sscce.foreach.with.bind.FooMapper.countBar - ==> Parameters: test002(String), test002(String) 09:44:57.787 [main] DEBUG mybatis.sscce.foreach.with.bind.FooMapper.countBar - <== Total: 1 1